]> source.dussan.org Git - vaadin-framework.git/commitdiff
Exclude PhantomJS from flaky GridComponentsTest
authorHenri Sara <hesara@vaadin.com>
Fri, 18 Aug 2017 11:27:16 +0000 (14:27 +0300)
committerHenri Sara <henri.sara@gmail.com>
Fri, 18 Aug 2017 12:25:21 +0000 (15:25 +0300)
The test testReuseTextFieldOnScroll() often crashes PhantomJS 1.

uitest/src/test/java/com/vaadin/tests/components/grid/GridComponentsTest.java

index 045d205f872de37652c5c88f42640fbbff5ace69..cd680d38047b42a93af4d8de957dc520420e48df 100644 (file)
@@ -14,12 +14,17 @@ import com.vaadin.testbench.elements.GridElement.GridCellElement;
 import com.vaadin.testbench.elements.GridElement.GridRowElement;
 import com.vaadin.testbench.elements.LabelElement;
 import com.vaadin.testbench.elements.NotificationElement;
+import com.vaadin.testbench.parallel.BrowserUtil;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class GridComponentsTest extends MultiBrowserTest {
 
     @Test
     public void testReuseTextFieldOnScroll() {
+        if (BrowserUtil.isPhantomJS(getDesiredCapabilities())) {
+            // skip test on PhantomJS as it often crashes the browser
+            return;
+        }
         openTestURL();
         GridElement grid = $(GridElement.class).first();
         editTextFieldInCell(grid, 0, 1);