]> source.dussan.org Git - jquery-ui.git/commitdiff
Button: modified the event bindings for focus and blur. Fixed #6711 - checkbox/radio...
authorGlenn Goodrich <glenn.goodrich@gmail.com>
Thu, 26 May 2011 15:28:17 +0000 (11:28 -0400)
committerScott González <scott.gonzalez@gmail.com>
Thu, 26 May 2011 15:28:17 +0000 (11:28 -0400)
tests/unit/button/button_tickets.js
ui/jquery.ui.button.js

index 79bbfeb5c0a731ad965ad435fbc00e07c7d47447..9a7ccae43127322fc51ffd0e6bb5ee102b51a3a0 100644 (file)
@@ -20,6 +20,14 @@ test( "#6262 - buttonset not applying ui-corner to invisible elements", function
        ok( set.find( "label:eq(2)" ).is( ".ui-button.ui-corner-right" ) );
 });
 
+test( "#6711 Checkbox/Radiobutton do not Show Focused State when using Keyboard Navigation", function() {
+       var check = $( "#check" ).button(),
+               label = $( "label[for='check']" );
+       ok( !label.is( ".ui-state-focus" ) );
+       check.focus();
+       ok( label.is( ".ui-state-focus" ) );
+});
+
 test( "#7092 - button creation that requires a matching label does not find label in all cases", function() {
        var group = $( "<span><label for='t7092a'/><input type='checkbox' id='t7092a'/></span>" );
        group.find( "input:checkbox" ).button();
index a95dddc6c011b2d4f5723237f58741d063f36dc9..3f3b90e925a4e8a641e4a643b69fb85cb3503d6d 100644 (file)
@@ -95,19 +95,21 @@ $.widget( "ui.button", {
                                }
                                $( this ).removeClass( hoverClass );
                        })
-                       .bind( "focus.button", function() {
-                               // no need to check disabled, focus won't be triggered anyway
-                               $( this ).addClass( focusClass );
-                       })
-                       .bind( "blur.button", function() {
-                               $( this ).removeClass( focusClass );
-                       })
                        .bind( "click.button", function( event ) {
                                if ( options.disabled ) {
                                        event.stopImmediatePropagation();
                                }
                        });
 
+               this.element
+                       .bind( "focus.button", function() {
+                               // no need to check disabled, focus won't be triggered anyway
+                               self.buttonElement.addClass( focusClass );
+                       })
+                       .bind( "blur.button", function() {
+                               self.buttonElement.removeClass( focusClass );
+                       });
+
                if ( toggleButton ) {
                        this.element.bind( "change.button", function() {
                                if ( clickDragged ) {