Fixes #2152: Embedded: document.onunload and document.onbeforeunload do not fire...

A clear bug in ICustomLayout: overriding onDetach()-method did not call super.onDetach().

This fix is for the 5.3 branch.

svn changeset:5733/svn branch:trunk

diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/ICustomLayout.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/ICustomLayout.java
index 09987f2b73ce780b0d9dc16bd37f27e963f41f18..6e65d9613c3b1634511396151418708c64233838 100644 (file)
--- a/src/com/itmill/toolkit/terminal/gwt/client/ui/ICustomLayout.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/ICustomLayout.java
@@ -383,6 +383,7 @@ public class ICustomLayout extends ComplexPanel implements Paintable,
     }
 
     /** Removes given widget from the layout */
+    @Override
     public boolean remove(Widget w) {
         client.unregisterPaintable((Paintable) w);
         final String location = getLocation(w);
@@ -401,11 +402,13 @@ public class ICustomLayout extends ComplexPanel implements Paintable,
     }
 
     /** Adding widget without specifying location is not supported */
+    @Override
     public void add(Widget w) {
         throw new UnsupportedOperationException();
     }
 
     /** Clear all widgets from the layout */
+    @Override
     public void clear() {
         super.clear();
         locationToWidget.clear();
@@ -427,7 +430,9 @@ public class ICustomLayout extends ComplexPanel implements Paintable,
         client.runDescendentsLayout(this);
     }
 
+    @Override
     public void onDetach() {
+        super.onDetach();
         detachResizedFunction(DOM.getFirstChild(getElement()));
     }