SONAR-21656 Drop old note classes

diff --git a/server/sonar-web/package.json b/server/sonar-web/package.json
index d8a3e036ab362754b3ed03e2cd0cf7e88f7b9d6e..648cb572bf0058f6bae9a013907ddba87537b10d 100644 (file)
--- a/server/sonar-web/package.json
+++ b/server/sonar-web/package.json
@@ -121,7 +121,8 @@
     "start:force": "node scripts/start.js --force-build-design-system",
     "build": "node scripts/build.js",
     "build-release": "yarn install --immutable && node scripts/build.js release",
-    "test": "jest",
+    "test": "NODE_OPTIONS=--max-old-space-size=1024 jest",
+    "test-ci": "NODE_OPTIONS=\"-r dd-trace/ci/init\" jest --coverage --maxWorkers=5 --workerIdleMemoryLimit=2G --ci",
     "test-eslint-local-rules": "jest -c eslint-local-rules/jest.config.js",
     "format": "prettier --write --list-different \"src/main/js/**/*.{js,ts,tsx,css}\"",
     "format-check": "prettier --check \"src/main/js/**/*.{js,ts,tsx,css}\"",
@@ -130,7 +131,7 @@
     "lint-report-ci": "yarn install --immutable && eslint --ext js,ts,tsx --config .eslintrc-ci -f json -o eslint-report/eslint-report.json src/main/js  || yarn lint",
     "ts-check": "tsc --noEmit",
     "validate": "yarn dep-check && yarn lint && yarn ts-check && yarn format-check && yarn test",
-    "validate-ci": "yarn install --immutable && yarn dep-check && NODE_OPTIONS=\"-r dd-trace/ci/init\" yarn test --coverage --maxWorkers=5 --workerIdleMemoryLimit=2G --ci",
+    "validate-ci": "yarn install --immutable && yarn dep-check && yarn test-ci",
     "check-ci": "yarn install --immutable && yarn ts-check && yarn format-check && yarn test-eslint-local-rules",
     "update-cwes": "node scripts/update-cwes.js",
     "dep-check": "node scripts/validate-package-json.js"

diff --git a/server/sonar-web/src/main/js/app/styles/init/misc.css b/server/sonar-web/src/main/js/app/styles/init/misc.css
index df466f2fa8ae078041804d7a7b672a76f8b995a5..e003b586cb980065929bf668291e54d6d055d0aa 100644 (file)
--- a/server/sonar-web/src/main/js/app/styles/init/misc.css
+++ b/server/sonar-web/src/main/js/app/styles/init/misc.css
@@ -34,11 +34,6 @@ th.hide-overflow {
   overflow: hidden;
 }
 
-.note {
-  color: var(--secondFontColor);
-  font-size: var(--smallFontSize);
-}
-
 .null-spacer-bottom {
   margin-bottom: 0 !important;
 }

diff --git a/server/sonar-web/src/main/js/app/styles/style.css b/server/sonar-web/src/main/js/app/styles/style.css
index 2767357145f9d68e5537cc6a4964457088a24f58..bb33e85bbe43d808ee3a38c73a0a515e55aa9adb 100644 (file)
--- a/server/sonar-web/src/main/js/app/styles/style.css
+++ b/server/sonar-web/src/main/js/app/styles/style.css
@@ -279,10 +279,6 @@ code.rule {
   vertical-align: text-top;
 }
 
-.property .note {
-  margin-top: 5px;
-}
-
 .shortcuts-modal h3 {
   margin-bottom: 0;
 }

diff --git a/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.tsx b/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.tsx
index bec08e2aa3f182470d127b42e98bff9c42e5ac85..829e23792f4056ec3db5e925ad439a2bf5681662 100644 (file)
--- a/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.tsx
@@ -18,8 +18,8 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 import { isSameDay } from 'date-fns';
-import { BarChart, DateRangePicker, FacetBox, FacetItem } from 'design-system';
-import { max } from 'lodash';
+import { BarChart, DateRangePicker, FacetBox, FacetItem, Note } from 'design-system';
+import { isEmpty, max } from 'lodash';
 import * as React from 'react';
 import { WrappedComponentProps, injectIntl } from 'react-intl';
 import { longFormatterOption } from '../../../components/intl/DateFormatter';
@@ -236,14 +236,14 @@ export class CreationDateFacetClass extends React.PureComponent<Props & WrappedC
   renderInner() {
     const { createdAfter, createdAfterIncludesTime, createdAt } = this.props;
 
-    if (createdAt) {
+    if (!isEmpty(createdAt)) {
       return (
         <div className="search-navigator-facet-container">
           <DateTimeFormatter date={this.props.createdAt} />
           <br />
-          <span className="note">
+          <Note>
             <DateFromNow date={this.props.createdAt} />
-          </span>
+          </Note>
         </div>
       );
     }

diff --git a/server/sonar-web/src/main/js/apps/issues/sidebar/ListStyleFacet.tsx b/server/sonar-web/src/main/js/apps/issues/sidebar/ListStyleFacet.tsx
index 0435087a152dbbbb55162a630f0345d680508e06..4552da2afc08326b6879bad81de710bcd9a38a97 100644 (file)
--- a/server/sonar-web/src/main/js/apps/issues/sidebar/ListStyleFacet.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/sidebar/ListStyleFacet.tsx
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software Foundation,
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
-import { FacetBox, FacetItem, FlagMessage, InputSearch } from 'design-system';
+import { FacetBox, FacetItem, FlagMessage, InputSearch, Note } from 'design-system';
 import { max, sortBy, values, without } from 'lodash';
 import * as React from 'react';
 import ListFooter from '../../../components/controls/ListFooter';
@@ -332,7 +332,9 @@ export class ListStyleFacet<S> extends React.Component<Props<S>, State<S>> {
 
         {selectedBelowLimit.length > 0 && (
           <>
-            <div className="note spacer-bottom text-center">⋯</div>
+            <Note as="div" className="sw-mb-2 sw-text-center">
+              ⋯
+            </Note>
 
             <FacetItemsList labelledby={this.getFacetHeaderId(property)}>
               {selectedBelowLimit.map((item) => (

diff --git a/server/sonar-web/src/main/js/apps/issues/sidebar/StandardFacet.tsx b/server/sonar-web/src/main/js/apps/issues/sidebar/StandardFacet.tsx
index c3bfec2dd73c0c83dcdead5439376d2a36088e99..6913a0dcf1f40d9120407cb6389fed1ca5f1f213 100644 (file)
--- a/server/sonar-web/src/main/js/apps/issues/sidebar/StandardFacet.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/sidebar/StandardFacet.tsx
@@ -19,7 +19,7 @@
  */
 /* eslint-disable react/no-unused-prop-types */
 
-import { FacetBox, FacetItem, TextMuted } from 'design-system';
+import { FacetBox, FacetItem, Note, TextMuted } from 'design-system';
 import { omit, sortBy, without } from 'lodash';
 import * as React from 'react';
 import { translate, translateWithParameters } from '../../../helpers/l10n';
@@ -364,7 +364,11 @@ export class StandardFacet extends React.PureComponent<Props, State> {
 
         {selectedBelowLimit.length > 0 && (
           <>
-            {!allItemShown && <div className="note spacer-bottom text-center">⋯</div>}
+            {!allItemShown && (
+              <Note as="div" className="sw-mb-2 sw-text-center">
+                ⋯
+              </Note>
+            )}
             {selectedBelowLimit.map((item) => (
               <FacetItem
                 active

diff --git a/server/sonar-web/src/main/js/apps/issues/sidebar/VariantFacet.tsx b/server/sonar-web/src/main/js/apps/issues/sidebar/VariantFacet.tsx
index a459c95558c02d1ae8369da561fa45d8bde52941..e63684e0844c49736c9a1c0e800621d576cb527c 100644 (file)
--- a/server/sonar-web/src/main/js/apps/issues/sidebar/VariantFacet.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/sidebar/VariantFacet.tsx
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software Foundation,
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
-import { FacetBox, FacetItem } from 'design-system';
+import { FacetBox, FacetItem, Note } from 'design-system';
 import { orderBy, sortBy, without } from 'lodash';
 import * as React from 'react';
 import { translate, translateWithParameters } from '../../../helpers/l10n';
@@ -89,7 +89,9 @@ export function VariantFacet(props: VariantFacetProps) {
     >
       <FacetItemsList labelledby={id}>
         {nbSelectableItems === 0 && (
-          <div className="note spacer-bottom">{translate('no_results')}</div>
+          <Note as="div" className="sw-mb-2 sw-text-center">
+            {translate('no_results')}
+          </Note>
         )}
 
         {sortBy(

diff --git a/server/sonar-web/src/main/js/components/common/VisibilitySelector.tsx b/server/sonar-web/src/main/js/components/common/VisibilitySelector.tsx
index 4a71ec2eb1969faeb973251fdd1a48559cdb29a1..88bf598a83d40be1565027f07aa3bf6386889112 100644 (file)
--- a/server/sonar-web/src/main/js/components/common/VisibilitySelector.tsx
+++ b/server/sonar-web/src/main/js/components/common/VisibilitySelector.tsx
@@ -18,7 +18,7 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 import classNames from 'classnames';
-import { RadioButton } from 'design-system';
+import { Note, RadioButton } from 'design-system';
 import * as React from 'react';
 import { translate } from '../../helpers/l10n';
 import { Visibility } from '../../types/component';
@@ -48,9 +48,7 @@ export default function VisibilitySelector(props: VisibilitySelectorProps) {
         >
           <div>
             {translate('visibility', v)}
-            {showDetails && (
-              <p className="note">{translate('visibility', v, 'description.long')}</p>
-            )}
+            {showDetails && <Note as="p">{translate('visibility', v, 'description.long')}</Note>}
           </div>
         </RadioButton>
       ))}

diff --git a/server/sonar-web/src/main/js/components/search-navigator.css b/server/sonar-web/src/main/js/components/search-navigator.css
index ed02a21a13e1842552fe5c78f4e8cb58a3bba82f..f470ac723eefcb1b3513706532d2eaadcf4a2886 100644 (file)
--- a/server/sonar-web/src/main/js/components/search-navigator.css
+++ b/server/sonar-web/src/main/js/components/search-navigator.css
@@ -228,10 +228,6 @@ button.search-navigator-facet:focus,
   color: var(--darkBlue);
 }
 
-.search-navigator-facet-header > .note {
-  font-weight: 400;
-}
-
 .search-navigator-facet-header > h3,
 .search-navigator-facet-header > h4 {
   line-height: inherit;