]> source.dussan.org Git - sonarqube.git/commitdiff
Fix warnings
authorDavid Gageot <david@gageot.net>
Mon, 14 May 2012 10:24:30 +0000 (12:24 +0200)
committerDavid Gageot <david@gageot.net>
Mon, 14 May 2012 11:01:11 +0000 (13:01 +0200)
17 files changed:
sonar-batch/src/main/java/org/sonar/batch/bootstrapper/Batch.java
sonar-colorizer/src/test/java/org/sonar/colorizer/HtmlRendererTest.java
sonar-core/pom.xml
sonar-core/src/test/java/org/sonar/core/rule/DefaultRuleFinderTest.java
sonar-plugin-api/src/test/java/org/sonar/api/batch/BatchExtensionDictionnaryTest.java
sonar-plugin-api/src/test/java/org/sonar/api/checks/AnnotationCheckFactoryTest.java
sonar-plugin-api/src/test/java/org/sonar/api/measures/SumChildDistributionFormulaTest.java
sonar-server/src/main/java/org/sonar/server/filters/FilterResult.java
sonar-server/src/main/java/org/sonar/server/ui/JRubyFacade.java
sonar-server/src/test/java/org/sonar/server/platform/ServletFiltersTest.java
sonar-squid/src/test/java/org/sonar/squid/measures/AbstractnessFormulaTest.java
sonar-squid/src/test/java/org/sonar/squid/measures/CommentLinesDensityFormulaTest.java
sonar-squid/src/test/java/org/sonar/squid/measures/CommentLinesWithoutHeaderFormulaTest.java
sonar-squid/src/test/java/org/sonar/squid/measures/DistanceFormulaTest.java
sonar-squid/src/test/java/org/sonar/squid/measures/InstabilityFormulaTest.java
sonar-squid/src/test/java/org/sonar/squid/measures/MeanAggregationFormulaTest.java
sonar-squid/src/test/java/org/sonar/squid/measures/PublicDocumentedApiDensityFormulaTest.java

index 5a58208d90272f67cc73ebf307ad7e9f1e45e74b..b580455032238d43e8ea4a21b8a813b5168d135e 100644 (file)
@@ -37,7 +37,7 @@ import java.util.Map;
 public final class Batch {
 
   private LoggingConfiguration logging;
-  private List components;
+  private List<Object> components;
   private ProjectReactor projectReactor;
 
   private Batch(Builder builder) {
index c2f168efcad1a1fb91408bfa830ac1e5cd0a85dd..237e5d2c48adcdd0e98acf1edd547025e1f581ee 100644 (file)
  */
 package org.sonar.colorizer;
 
+import org.apache.commons.io.FileUtils;
+import org.junit.Test;
+
 import java.io.File;
 import java.io.FileReader;
 import java.io.IOException;
 import java.io.StringReader;
 import java.util.Arrays;
 
-import org.apache.commons.io.FileUtils;
-import org.junit.Test;
-import org.sonar.channel.Channel;
-
 import static org.hamcrest.CoreMatchers.is;
 import static org.junit.Assert.assertThat;
 import static org.junit.internal.matchers.StringContains.containsString;
@@ -39,16 +38,18 @@ public class HtmlRendererTest {
 
   @Test
   public void renderJavaSyntax() {
-    String html = new HtmlRenderer(HtmlOptions.ONLY_SYNTAX).render(new StringReader("public class Hello {"), Arrays
-        .<Channel<HtmlCodeBuilder>> asList(javaKeywordTokenizer));
+    HtmlRenderer htmlRenderer = new HtmlRenderer(HtmlOptions.ONLY_SYNTAX);
+
+    String html = htmlRenderer.render(new StringReader("public class Hello {"), Arrays.asList(javaKeywordTokenizer));
 
     assertThat(html, is("<span class='k'>public</span> <span class='k'>class</span> Hello {"));
   }
 
   @Test
   public void supportHtmlSpecialCharacters() {
-    String html = new HtmlRenderer(HtmlOptions.ONLY_SYNTAX).render(new StringReader("foo(\"<html>\");"), Arrays
-        .<Channel<HtmlCodeBuilder>> asList(new LiteralTokenizer("<s>", "</s>")));
+    HtmlRenderer htmlRenderer = new HtmlRenderer(HtmlOptions.ONLY_SYNTAX);
+
+    String html = htmlRenderer.render(new StringReader("foo(\"<html>\");"), Arrays.asList(new LiteralTokenizer("<s>", "</s>")));
 
     assertThat(html, is("foo(<s>\"&lt;html&gt;\"</s>);"));
   }
@@ -57,7 +58,7 @@ public class HtmlRendererTest {
   public void renderJavaFile() throws IOException {
     File java = FileUtils.toFile(getClass().getResource("/org/sonar/colorizer/HtmlRendererTest/Sample.java"));
 
-    String html = new HtmlRenderer().render(new FileReader(java), Arrays.<Channel<HtmlCodeBuilder>> asList(javaKeywordTokenizer));
+    String html = new HtmlRenderer().render(new FileReader(java), Arrays.asList(javaKeywordTokenizer));
 
     assertThat(html, containsString("<html>"));
     assertThat(html, containsString("<style"));
index ab91393085ab3fbdea504f3f60277acbc62c0050..44ce2aa268f72368d0e5cf2d321084af84ef8b5b 100644 (file)
       <artifactId>dbunit</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.easytesting</groupId>
+      <artifactId>fest-assert</artifactId>
+      <scope>test</scope>
+    </dependency>
 
     <!--
          JDBC drivers for MyBatis integration tests.
index b5b9685e81578e4706ded7d466bebaf237ac3f44..568b84bf6755a716aa54580d36bbf9df59828640 100644 (file)
@@ -23,15 +23,16 @@ import org.junit.Test;
 import org.sonar.api.rules.Rule;
 import org.sonar.api.rules.RuleFinder;
 import org.sonar.api.rules.RuleQuery;
-import org.sonar.core.rule.DefaultRuleFinder;
 import org.sonar.jpa.test.AbstractDbUnitTestCase;
 
 import java.util.Collection;
 
-import static org.hamcrest.CoreMatchers.anyOf;
+import static org.fest.assertions.Assertions.assertThat;
 import static org.hamcrest.core.Is.is;
 import static org.hamcrest.core.IsNull.nullValue;
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertThat;
 
 public class DefaultRuleFinderTest extends AbstractDbUnitTestCase {
 
@@ -72,8 +73,8 @@ public class DefaultRuleFinderTest extends AbstractDbUnitTestCase {
     setupData("shared");
     RuleFinder finder = new DefaultRuleFinder(getSessionFactory());
     Collection<Rule> rules = finder.findAll(RuleQuery.create().withRepositoryKey("checkstyle"));
-    assertNotNull(rules);
-    assertThat(rules.size(), is(2)); // only enabled checkstyle rules
+
+    assertThat(rules).hasSize(2);
   }
 
   @Test
@@ -81,11 +82,8 @@ public class DefaultRuleFinderTest extends AbstractDbUnitTestCase {
     setupData("shared");
     RuleFinder finder = new DefaultRuleFinder(getSessionFactory());
     Collection<Rule> rules = finder.findAll(RuleQuery.create());
-    assertNotNull(rules);
-    assertThat(rules.size(), is(3)); // only enabled checkstyle+pmd rules
-    for (Rule rule : rules) {
-      assertThat(rule.getId(), anyOf(is(1), is(3), is(4)));
-    }
+
+    assertThat(rules).onProperty("id").containsOnly(1, 3, 4);
   }
 
   @Test
index 0b6eedbddf8e698128f60388bf44ea076a77b579..fe4feda7d5ec43f23bfe9ac676a422361b2387d1 100644 (file)
@@ -196,7 +196,6 @@ public class BatchExtensionDictionnaryTest {
     BatchExtensionDictionnary selector = newSelector();
     BatchExtension wrong = new BatchExtension() {
       @DependsUpon
-      @SuppressWarnings("unused")
       private Object foo() {
         return "foo";
       }
index 895e37952e689408d8ef35806e1f747f8ccb79e4..093fe3576b23b689b82a7ced76bc647fcc045692 100644 (file)
@@ -19,7 +19,6 @@
  */
 package org.sonar.api.checks;
 
-import org.hamcrest.Matcher;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
 import org.sonar.api.profiles.RulesProfile;
@@ -29,9 +28,7 @@ import org.sonar.api.utils.SonarException;
 
 import java.util.Arrays;
 
-import static org.hamcrest.Matchers.hasItems;
-import static org.hamcrest.Matchers.not;
-import static org.hamcrest.Matchers.nullValue;
+import static org.fest.assertions.Assertions.assertThat;
 import static org.hamcrest.core.Is.is;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertSame;
@@ -167,7 +164,7 @@ public class AnnotationCheckFactoryTest {
     profile.activateRule(clonedRule, null);
     AnnotationCheckFactory factory = AnnotationCheckFactory.create(profile, "repo", Arrays.<Class> asList(CheckWithKey.class));
 
-    assertThat(factory.getChecks(), (Matcher) not(hasItems(nullValue())));
+    assertThat(factory.getChecks()).excludes(new Object[] {null});
   }
 
   /**
index 18421ed4df38803a12996f6914b2f3994053fb85..d19ac7e83e24364c66e2f38fafd5c73b97d5d561 100644 (file)
@@ -60,7 +60,7 @@ public class SumChildDistributionFormulaTest {
   @Test
   public void testWhenGetChildrenReturnsEmpty() {
     when(context.getTargetMetric()).thenReturn(new Metric("foo"));
-    when(data.getChildrenMeasures(new Metric("foo"))).thenReturn((List) Collections.emptyList());
+    when(data.getChildrenMeasures(new Metric("foo"))).thenReturn(Collections.<Measure> emptyList());
     assertNull(formula.calculate(data, context));
   }
 
index a09a3dcfd294e36b4ddc4bcd6e76291031627d04..421e53f138e0be6404ea51b7a0a45372c7f90cfa 100644 (file)
@@ -30,7 +30,7 @@ public class FilterResult {
   public static final int SORTED_COLUMN_INDEX = 3;
 
   public FilterResult(Filter filter, List rows) {
-    this.rows = new ArrayList(rows);
+    this.rows = new ArrayList<Object[]>(rows);
     this.filter = filter;
   }
 
index 65ef210a2cb557e9ff0ca4448bfd0262c5961af1..a7b5b34efbda0282997882fdb4e2580be5715c68 100644 (file)
@@ -362,7 +362,7 @@ public final class JRubyFacade {
     }
 
     try {
-      Class aClass = Class.forName(className);
+      Class<?> aClass = Class.forName(className);
       return getContainer().getComponentByType(aClass);
 
     } catch (ClassNotFoundException e) {
@@ -374,7 +374,7 @@ public final class JRubyFacade {
   public Object getComponentByClassname(String pluginKey, String className) {
     Object component = null;
     ComponentContainer container = getContainer();
-    Class componentClass = container.getComponentByType(DefaultServerPluginRepository.class).getClass(pluginKey, className);
+    Class<?> componentClass = container.getComponentByType(DefaultServerPluginRepository.class).getClass(pluginKey, className);
     if (componentClass != null) {
       component = container.getComponentByType(componentClass);
     }
index c6a715c069696b9469f0a16f89714255cd646732..6070b4891bfd3c044a32337f217700a4a98945ed 100644 (file)
@@ -22,7 +22,6 @@ package org.sonar.server.platform;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
-import org.mockito.InOrder;
 import org.sonar.api.web.ServletFilter;
 
 import javax.servlet.*;
index 9aa726b12464b798454094da2ee9bb7bb199e0c7..a3705488374a42eeee94f09cc13300ae08803907 100644 (file)
@@ -30,7 +30,7 @@ import static org.junit.Assert.assertEquals;
 public class AbstractnessFormulaTest {
 
   AbstractnessFormula abstractness = new AbstractnessFormula();
-  Measurable measurable = new SourcePackage("pac1");
+  Measurable<Metric> measurable = new SourcePackage("pac1");
 
   @Test
   public void testCalculate() {
@@ -40,7 +40,7 @@ public class AbstractnessFormulaTest {
 
     assertEquals(0.2, abstractness.calculate(measurable), 0);
   }
-  
+
   @Test
   public void testCalculateOnEmptyProject() {
     measurable.setMeasure(Metric.CLASSES, 0);
index 28a4a44fcab2b57cbdbea598989742dc6d470628..496d62ce9638f36d50f7b116ade45bdbf96055e7 100644 (file)
@@ -25,11 +25,10 @@ import org.sonar.squid.api.SourceClass;
 
 import static org.junit.Assert.*;
 
-
 public class CommentLinesDensityFormulaTest {
-  
+
   CommentLinesDensityFormula formula = new CommentLinesDensityFormula();
-  Measurable measurable = new SourceClass("com.Toto");
+  Measurable<Metric> measurable = new SourceClass("com.Toto");
 
   @Test
   public void calculateDensityOnEmptyFile() {
@@ -37,7 +36,7 @@ public class CommentLinesDensityFormulaTest {
     measurable.setMeasure(Metric.COMMENT_LINES, 0);
     assertEquals(0, measurable.getDouble(Metric.COMMENT_LINES_DENSITY), 0.01);
   }
-  
+
   @Test
   public void calculate() {
     measurable.setMeasure(Metric.LINES_OF_CODE, 10);
index 886184546fdda1158af58f873da5ca08121cdd7a..9fb255e3e2cc5bdf227098f61477c94267ea4c83 100644 (file)
@@ -27,8 +27,8 @@ import static org.junit.Assert.assertEquals;
 
 public class CommentLinesWithoutHeaderFormulaTest {
 
-  CommentLinesWithoutHeaderFormula formula    = new CommentLinesWithoutHeaderFormula();
-  Measurable                       measurable = new SourceClass("com.Toto");
+  CommentLinesWithoutHeaderFormula formula = new CommentLinesWithoutHeaderFormula();
+  Measurable<Metric> measurable = new SourceClass("com.Toto");
 
   @Test
   public void calculateDensityOnEmptyFile() {
index f4d4f39eb42470974747039c22ddea356c5c562d..406fb2611712ac2f354b95a3973fa97794a5e714 100644 (file)
@@ -27,8 +27,8 @@ import static org.junit.Assert.assertEquals;
 
 public class DistanceFormulaTest {
 
-  DistanceFormula distance   = new DistanceFormula();
-  Measurable      measurable = new SourcePackage("pac1");
+  DistanceFormula distance = new DistanceFormula();
+  Measurable<Metric> measurable = new SourcePackage("pac1");
 
   @Test
   public void calculateBestDistance() {
@@ -38,7 +38,7 @@ public class DistanceFormulaTest {
     measurable.setMeasure(Metric.CE, 10);
     assertEquals(0.5, measurable.getDouble(Metric.DISTANCE), 0.01);
   }
-  
+
   @Test
   public void calculateWorstDistance() {
     measurable.setMeasure(Metric.CLASSES, 5);
index 641f227695cf8125d36336b50d10ce63a1c53ff9..92f3aca2ace67d2aff537b946dc5a27c610101f8 100644 (file)
@@ -27,8 +27,8 @@ import static org.junit.Assert.assertEquals;
 
 public class InstabilityFormulaTest {
 
-  InstabilityFormula distance   = new InstabilityFormula();
-  Measurable      measurable = new SourcePackage("pac1");
+  InstabilityFormula distance = new InstabilityFormula();
+  Measurable<Metric> measurable = new SourcePackage("pac1");
 
   @Test
   public void calculateBestStability() {
@@ -36,14 +36,14 @@ public class InstabilityFormulaTest {
     measurable.setMeasure(Metric.CE, 0);
     assertEquals(0, measurable.getDouble(Metric.INSTABILITY), 0.01);
   }
-  
+
   @Test
   public void calculateWorstStability() {
     measurable.setMeasure(Metric.CA, 0);
     measurable.setMeasure(Metric.CE, 10);
     assertEquals(1, measurable.getDouble(Metric.INSTABILITY), 0.01);
   }
-  
+
   @Test
   public void calculateOnIsolatedProject() {
     measurable.setMeasure(Metric.CA, 0);
index 84d8ace882da3ebbd4e374290e45d6e482167d40..80796ff9be1f5de0ee9285a5ba208cd34766e472 100644 (file)
@@ -28,9 +28,8 @@ import static org.junit.Assert.*;
 
 import org.sonar.squid.api.SourceClass;
 
-
 public class MeanAggregationFormulaTest {
-  
+
   MeanAggregationFormula formula = new MeanAggregationFormula();
 
   @Test
@@ -42,10 +41,10 @@ public class MeanAggregationFormulaTest {
     SourceClass class2 = new SourceClass("com.My");
     class2.setMeasure(Metric.COMPLEXITY, 3);
     measurables.add(class2);
-    
+
     assertEquals(2.5, formula.aggregate(Metric.COMPLEXITY, measurables), 0.01);
   }
-  
+
   @Test
   public void testAggregateEmptyCollections() {
     List<Measurable> measurables = new ArrayList<Measurable>();
index bf20ee2c41913fb7e2366ef9b7fd688350fa5de6..bfc38bba20622a3c12c0812089a2ce4d662646be 100644 (file)
@@ -25,11 +25,10 @@ import org.sonar.squid.api.SourceClass;
 
 import static org.junit.Assert.*;
 
-
 public class PublicDocumentedApiDensityFormulaTest {
-  
+
   PublicDocumentedApiDensityFormula formula = new PublicDocumentedApiDensityFormula();
-  Measurable measurable = new SourceClass("com.Toto");
+  Measurable<Metric> measurable = new SourceClass("com.Toto");
 
   @Test
   public void calculateWhenNoPublicApi() {
@@ -37,7 +36,7 @@ public class PublicDocumentedApiDensityFormulaTest {
     measurable.setMeasure(Metric.PUBLIC_DOC_API, 0);
     assertEquals(1, measurable.getDouble(Metric.PUBLIC_DOCUMENTED_API_DENSITY), 0.01);
   }
-  
+
   @Test
   public void calculate() {
     measurable.setMeasure(Metric.PUBLIC_API, 10);