Fix IT's false positive

diff --git a/server/sonar-web/src/main/js/components/common/PageCounter.tsx b/server/sonar-web/src/main/js/components/common/PageCounter.tsx
index 9eb58003ef6b565397ff695eb75456320d9773f0..033b822bba73257353e1c96712d17c5135369369 100644 (file)
--- a/server/sonar-web/src/main/js/components/common/PageCounter.tsx
+++ b/server/sonar-web/src/main/js/components/common/PageCounter.tsx
@@ -21,19 +21,19 @@ import * as classNames from 'classnames';
 import * as React from 'react';
 import { formatMeasure } from 'sonar-ui-common/helpers/measures';
 
-interface Props {
+export interface PageCounterProps {
   className?: string;
   current?: number;
   label: string;
   total: number;
 }
 
-export default function PageCounter({ className, current, label, total }: Props) {
+export default function PageCounter({ className, current, label, total }: PageCounterProps) {
   return (
     <div className={classNames('display-inline-block', className)}>
       <strong className="little-spacer-right">
         {current !== undefined && formatMeasure(current + 1, 'INT') + ' / '}
-        <span className="js-page-counter-total">{formatMeasure(total, 'INT')}</span>
+        <span className="it__page-counter-total">{formatMeasure(total, 'INT')}</span>
       </strong>
       {label}
     </div>

diff --git a/server/sonar-web/src/main/js/components/common/__tests__/PageCounter-test.tsx b/server/sonar-web/src/main/js/components/common/__tests__/PageCounter-test.tsx
new file mode 100644 (file)
index 0000000..cb3db15
--- /dev/null
+++ b/server/sonar-web/src/main/js/components/common/__tests__/PageCounter-test.tsx
@@ -0,0 +1,34 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2021 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+import { shallow } from 'enzyme';
+import * as React from 'react';
+import PageCounter, { PageCounterProps } from '../PageCounter';
+
+it('should render correctly', () => {
+  const wrapper = shallowRender();
+  expect(wrapper).toMatchSnapshot();
+});
+
+function shallowRender(props: Partial<PageCounterProps> = {}) {
+  return shallow<PageCounterProps>(
+    <PageCounter label="label" current={123} total={1234} {...props} />
+  );
+}

diff --git a/server/sonar-web/src/main/js/components/common/__tests__/__snapshots__/PageCounter-test.tsx.snap b/server/sonar-web/src/main/js/components/common/__tests__/__snapshots__/PageCounter-test.tsx.snap
new file mode 100644 (file)
index 0000000..46cc3bc
--- /dev/null
+++ b/server/sonar-web/src/main/js/components/common/__tests__/__snapshots__/PageCounter-test.tsx.snap
@@ -0,0 +1,19 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`should render correctly 1`] = `
+<div
+  className="display-inline-block"
+>
+  <strong
+    className="little-spacer-right"
+  >
+    124 / 
+    <span
+      className="it__page-counter-total"
+    >
+      1,234
+    </span>
+  </strong>
+  label
+</div>
+`;