fix tests and outputs.

diff --git a/server/sonar-process/src/main/java/org/sonar/process/ProcessWrapper.java b/server/sonar-process/src/main/java/org/sonar/process/ProcessWrapper.java
index f1997f2d09a7c5f1193f0d8b254064500b00725a..5f14e83b45cc682149479acbbf400ab33229b8fd 100644 (file)
--- a/server/sonar-process/src/main/java/org/sonar/process/ProcessWrapper.java
+++ b/server/sonar-process/src/main/java/org/sonar/process/ProcessWrapper.java
@@ -141,7 +141,7 @@ public class ProcessWrapper {
     processBuilder.environment().putAll(properties);
     processBuilder.environment().put(Process.NAME_PROPERTY, this.getName());
     processBuilder.environment().put(Process.PORT_PROPERTY, Integer.toString(port));
-    System.out.println("processBuilder.toString(); = " + processBuilder.toString());
+
     try {
       java.lang.Process process = processBuilder.start();
       errorGobbler = new StreamGobbler(process.getErrorStream(), this.getName() + "-ERROR");

diff --git a/server/sonar-process/src/test/java/org/sonar/process/ProcessTest.java b/server/sonar-process/src/test/java/org/sonar/process/ProcessTest.java
index 08e7d24a5b403c1a5db0c6dc73d2e4afb6ce9b3d..7d300208a5cabb544501ad7a6d41b836455cdadc 100644 (file)
--- a/server/sonar-process/src/test/java/org/sonar/process/ProcessTest.java
+++ b/server/sonar-process/src/test/java/org/sonar/process/ProcessTest.java
@@ -54,6 +54,26 @@ public class ProcessTest {
     }
   }
 
+  @Test
+  public void fails_invalid_name() {
+    try {
+      Process.objectNameFor("::");
+      fail();
+    } catch (Exception e) {
+      assertThat(e.getMessage()).isEqualTo("Cannot create ObjectName for ::");
+    }
+  }
+
+  @Test
+  public void fail_missing_properties() {
+    Properties properties = new Properties();
+    try {
+      new TestProcess(Props.create(properties));
+    } catch (Exception e) {
+      assertThat(e.getMessage()).isEqualTo(Process.MISSING_NAME_ARGUMENT);
+    }
+  }
+
   @Test
   public void should_register_mbean() throws Exception {