Fixup getURLParameter behavior

This commit further changes the behavior of getURLParmeter to handle
encoded parameter values and returns the decoded string and improves
behavior for parameters without value and multiple equals and other
similar cases which did not work before. See the comments at
http://stackoverflow.com/questions/1403888/get-escaped-url-parameter for
a list of the issues handled by the updated implementation.

This change does not change the general behavior of the function. Empty
or non existing parameters still return an empty string ('').

diff --git a/core/js/js.js b/core/js/js.js
index 0a83f1104aa31f009d0b02db6ad07c3588ab6244..67487ec979c4127a039a6bb4545596540c985740 100644 (file)
--- a/core/js/js.js
+++ b/core/js/js.js
@@ -1722,9 +1722,10 @@ function formatDate(timestamp){
  * @return {string}
  */
 function getURLParameter(name) {
-       return decodeURI(
-                       (RegExp(name + '=' + '(.+?)(&|$)').exec(location.search) || [, ''])[1]
-                       );
+       return decodeURIComponent(
+               (new RegExp('[?|&]' + name + '=' + '([^&;]+?)(&|#|;|$)').exec(
+                       location.search)||[,''])[1].replace(/\+/g, '%20')
+               )||'';
 }
 
 /**