Datepicker: show inline datepicker setting explicit display:block instead of using...

author Richard D. Worth <rdworth@gmail.com>

Tue, 19 Jul 2011 11:59:21 +0000 (07:59 -0400)

committer Richard D. Worth <rdworth@gmail.com>

Tue, 19 Jul 2011 12:12:41 +0000 (08:12 -0400)
author Richard D. Worth <rdworth@gmail.com>
Tue, 19 Jul 2011 11:59:21 +0000 (07:59 -0400)
committer Richard D. Worth <rdworth@gmail.com>
Tue, 19 Jul 2011 12:12:41 +0000 (08:12 -0400)
diff --git a/tests/visual/datepicker/datepicker_ticket_7552.html b/tests/visual/datepicker/datepicker_ticket_7552.html

new file mode 100644 (file)

index 0000000..a78a848
--- /dev/null
+++ b/tests/visual/datepicker/datepicker_ticket_7552.html
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+       <meta charset="UTF-8" />
+       <title>Datepicker Visual Test : Datepicker ticket #7552</title>
+       <link rel="stylesheet" href="../visual.css" type="text/css" />
+       <link rel="stylesheet" href="../../../themes/base/jquery.ui.all.css" type="text/css">
+       <script type="text/javascript" src="../../../jquery-1.5.1.js"></script>
+       <script type="text/javascript" src="../../../ui/jquery.ui.core.js"></script>
+       <script type="text/javascript" src="../../../ui/jquery.ui.widget.js"></script>
+       <script type="text/javascript" src="../../../ui/jquery.ui.datepicker.js"></script>
+       <script type="text/javascript">
+       $(function() {
+               $('<div></div>').datepicker().appendTo("body");
+       });
+       </script>
+</head>
+<body>
+
+<h1 class="ui-widget-header"><a href="http://dev.jqueryui.com/ticket/7552">#7552 - A Datepicker created on a detached div has zero height</a></h1>
+
+</body>
+</html>
diff --git a/ui/jquery.ui.datepicker.js b/ui/jquery.ui.datepicker.js

index 19696236cb60cfe8ece83d776b22297771583833..921f48760b7ee2b1444105d7807ca1448d6906cf 100644 (file)
--- a/ui/jquery.ui.datepicker.js
+++ b/ui/jquery.ui.datepicker.js
@@ -285,7 +285,9 @@ $.extend(Datepicker.prototype, {
                 if( inst.settings.disabled ) {
                         this._disableDatepicker( target );
                 }
-               inst.dpDiv.show();
+               // Set display:block in place of inst.dpDiv.show() which won't work on disconnected elements
+               // http://bugs.jqueryui.com/ticket/7552 - A Datepicker created on a detached div has zero height
+               inst.dpDiv.css( "display", "block" );
         },
  
         /* Pop-up the date picker in a "dialog" box.
author	Richard D. Worth <rdworth@gmail.com>
	Tue, 19 Jul 2011 11:59:21 +0000 (07:59 -0400)
committer	Richard D. Worth <rdworth@gmail.com>
	Tue, 19 Jul 2011 12:12:41 +0000 (08:12 -0400)
tests/visual/datepicker/datepicker_ticket_7552.html	[new file with mode: 0644]	patch \| blob
ui/jquery.ui.datepicker.js		patch \| blob \| history