]> source.dussan.org Git - jquery-ui.git/commitdiff
Accordion: First pass at splitting out tests for deprecated functionality.
authorScott González <scott.gonzalez@gmail.com>
Mon, 24 Jan 2011 19:38:23 +0000 (14:38 -0500)
committerScott González <scott.gonzalez@gmail.com>
Mon, 24 Jan 2011 19:38:23 +0000 (14:38 -0500)
tests/unit/accordion/accordion.html
tests/unit/accordion/accordion_defaults.js
tests/unit/accordion/accordion_defaults_deprecated.js [new file with mode: 0644]
tests/unit/accordion/accordion_deprecated.html [new file with mode: 0644]
tests/unit/accordion/accordion_deprecated.js [new file with mode: 0644]
tests/unit/accordion/accordion_methods.js
tests/unit/accordion/accordion_options.js
ui/jquery.ui.accordion.js

index 61d1683864192708b86fafa861866a8e6aecd2f6..88226be31ab25619d193dfd6a58add1ed1b55ab3 100644 (file)
@@ -1,55 +1,58 @@
 <!DOCTYPE html>
 <html lang="en">
 <head>
-       <meta charset="UTF-8" />
+       <meta charset="utf-8">
        <title>jQuery UI Accordion Test Suite</title>
 
-       <link type="text/css" href="../../../themes/base/jquery.ui.accordion.css" rel="stylesheet" />
+       <link rel="stylesheet" href="../../../themes/base/jquery.ui.accordion.css">
 
-       <script type="text/javascript" src="../../../jquery-1.4.4.js"></script>
-       <script type="text/javascript" src="../../../ui/jquery.ui.core.js"></script>
-       <script type="text/javascript" src="../../../ui/jquery.ui.widget.js"></script>
-       <script type="text/javascript" src="../../../ui/jquery.ui.accordion.js"></script>
+       <script src="../../../jquery-1.4.4.js"></script>
+       <script>
+       $.uiBackCompat = false;
+       </script>
+       <script src="../../../ui/jquery.ui.core.js"></script>
+       <script src="../../../ui/jquery.ui.widget.js"></script>
+       <script src="../../../ui/jquery.ui.accordion.js"></script>
 
-       <link rel="stylesheet" href="../../../external/qunit.css" type="text/css"/>
-       <script type="text/javascript" src="../../../external/qunit.js"></script>
-       <script type="text/javascript" src="../../jquery.simulate.js"></script>
-       <script type="text/javascript" src="../testsuite.js"></script>
+       <link rel="stylesheet" href="../../../external/qunit.css">
+       <script src="../../../external/qunit.js"></script>
+       <script src="../../jquery.simulate.js"></script>
+       <script src="../testsuite.js"></script>
 
-       <script type="text/javascript">
-               $.ui.accordion.prototype.options.animated = false;
+       <script>
+       $.ui.accordion.prototype.options.animated = false;
 
-               function state(accordion) {
-                       var args = $.makeArray(arguments).slice(1);
-                       var result = [];
-                       $.each(args, function(i, n) {
-                               result.push( accordion.find(".ui-accordion-content").eq(i).filter(function() {
-                                       return $(this).css("display") != "none"
-                               }).length ? 1 : 0 );
-                       });
-                       same(args, result)
-               }
-               function equalHeights(accordion, min, max) {
-                       var sizes = [];
-                       accordion.find(".ui-accordion-content").each(function() {
-                               sizes.push($(this).outerHeight());
-                       });
-                       ok( sizes[0] >= min && sizes[0] <= max, "must be within " + min + " and " + max + ", was " + sizes[0] );
-                       same(sizes[0], sizes[1]);
-                       same(sizes[0], sizes[2]);
-               }
+       function state(accordion) {
+               var args = $.makeArray(arguments).slice(1);
+               var result = [];
+               $.each(args, function(i, n) {
+                       result.push( accordion.find(".ui-accordion-content").eq(i).filter(function() {
+                               return $(this).css("display") != "none"
+                       }).length ? 1 : 0 );
+               });
+               same(args, result)
+       }
+       function equalHeights(accordion, min, max) {
+               var sizes = [];
+               accordion.find(".ui-accordion-content").each(function() {
+                       sizes.push($(this).outerHeight());
+               });
+               ok( sizes[0] >= min && sizes[0] <= max, "must be within " + min + " and " + max + ", was " + sizes[0] );
+               same(sizes[0], sizes[1]);
+               same(sizes[0], sizes[2]);
+       }
        </script>
-       <script type="text/javascript" src="accordion_core.js"></script>
-       <script type="text/javascript" src="accordion_defaults.js"></script>
-       <script type="text/javascript" src="accordion_events.js"></script>
-       <script type="text/javascript" src="accordion_methods.js"></script>
-       <script type="text/javascript" src="accordion_options.js"></script>
-       <script type="text/javascript" src="accordion_tickets.js"></script>
-       
-       <script type="text/javascript" src="../swarminject.js"></script>
+       <script src="accordion_core.js"></script>
+       <script src="accordion_defaults.js"></script>
+       <script src="accordion_events.js"></script>
+       <script src="accordion_methods.js"></script>
+       <script src="accordion_options.js"></script>
+       <script src="accordion_tickets.js"></script>
+
+       <script src="../swarminject.js"></script>
        <style>
-               #main { font-size: 10pt; font-family: 'trebuchet ms', verdana, arial; }
-               #list, #list1 *, #navigation, #navigation * { margin: 0; padding: 0; font-size: 12px; }
+       #main { font-size: 10pt; font-family: "trebuchet ms", verdana, arial; }
+       #list, #list1 *, #navigation, #navigation * { margin: 0; padding: 0; font-size: 12px; }
        </style>
 </head>
 <body>
index d29c1e84852a57d9ba30d75b89768764dfe73f86..78630adc7a248d67614e82c234fedd5114aa3b67 100644 (file)
@@ -5,19 +5,15 @@
 var accordion_defaults = {
        active: 0,
        animated: false,
-       autoHeight: true,
-       clearStyle: false,
        collapsible: false,
        disabled: false,
        event: "click",
-       fillSpace: false,
        header: "> li > :first-child,> :not(li):even",
-       heightStyle: null,
-       icons: { "header": "ui-icon-triangle-1-e", 
-                       "activeHeader": null,
-                       "headerSelected": "ui-icon-triangle-1-s" },
-       navigation: false,
-       navigationFilter: function() {}
+       heightStyle: "auto",
+       icons: {
+               "header": "ui-icon-triangle-1-e",
+               "activeHeader": "ui-icon-triangle-1-s"
+       }
 };
 
-commonWidgetTests('accordion', { defaults: accordion_defaults });
+commonWidgetTests( "accordion", { defaults: accordion_defaults } );
diff --git a/tests/unit/accordion/accordion_defaults_deprecated.js b/tests/unit/accordion/accordion_defaults_deprecated.js
new file mode 100644 (file)
index 0000000..41998ea
--- /dev/null
@@ -0,0 +1,25 @@
+/*
+ * accordion_defaults.js
+ */
+
+var accordion_defaults = {
+       active: 0,
+       animated: false,
+       autoHeight: true,
+       clearStyle: false,
+       collapsible: false,
+       disabled: false,
+       event: "click",
+       fillSpace: false,
+       header: "> li > :first-child,> :not(li):even",
+       heightStyle: null,
+       icons: {
+               "header": "ui-icon-triangle-1-e",
+               "activeHeader": null,
+               "headerSelected": "ui-icon-triangle-1-s"
+       },
+       navigation: false,
+       navigationFilter: function() {}
+};
+
+commonWidgetTests( "accordion", { defaults: accordion_defaults } );
diff --git a/tests/unit/accordion/accordion_deprecated.html b/tests/unit/accordion/accordion_deprecated.html
new file mode 100644 (file)
index 0000000..c104df4
--- /dev/null
@@ -0,0 +1,139 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+       <meta charset="utf-8">
+       <title>jQuery UI Accordion Test Suite</title>
+
+       <link rel="stylesheet" href="../../../themes/base/jquery.ui.accordion.css">
+
+       <script src="../../../jquery-1.4.4.js"></script>
+       <script src="../../../ui/jquery.ui.core.js"></script>
+       <script src="../../../ui/jquery.ui.widget.js"></script>
+       <script src="../../../ui/jquery.ui.accordion.js"></script>
+
+       <link rel="stylesheet" href="../../../external/qunit.css">
+       <script src="../../../external/qunit.js"></script>
+       <script src="../../jquery.simulate.js"></script>
+       <script src="../testsuite.js"></script>
+
+       <script>
+       $.ui.accordion.prototype.options.animated = false;
+
+       function state(accordion) {
+               var args = $.makeArray(arguments).slice(1);
+               var result = [];
+               $.each(args, function(i, n) {
+                       result.push( accordion.find(".ui-accordion-content").eq(i).filter(function() {
+                               return $(this).css("display") != "none"
+                       }).length ? 1 : 0 );
+               });
+               same(args, result)
+       }
+       function equalHeights(accordion, min, max) {
+               var sizes = [];
+               accordion.find(".ui-accordion-content").each(function() {
+                       sizes.push($(this).outerHeight());
+               });
+               ok( sizes[0] >= min && sizes[0] <= max, "must be within " + min + " and " + max + ", was " + sizes[0] );
+               same(sizes[0], sizes[1]);
+               same(sizes[0], sizes[2]);
+       }
+       </script>
+       <script src="accordion_core.js"></script>
+       <script src="accordion_defaults_deprecated.js"></script>
+       <script src="accordion_events.js"></script>
+       <script src="accordion_methods.js"></script>
+       <script src="accordion_options.js"></script>
+       <script src="accordion_tickets.js"></script>
+       <script src="accordion_deprecated.js"></script>
+
+       <script src="../swarminject.js"></script>
+       <style>
+       #main { font-size: 10pt; font-family: "trebuchet ms", verdana, arial; }
+       #list, #list1 *, #navigation, #navigation * { margin: 0; padding: 0; font-size: 12px; }
+       </style>
+</head>
+<body>
+
+<h1 id="qunit-header">jQuery UI Accordion Test Suite</h1>
+<h2 id="qunit-banner"></h2>
+<h2 id="qunit-userAgent"></h2>
+<ol id="qunit-tests">
+</ol>
+
+<div id="main" style="position: absolute; top: -10000px; left: -10000px;">
+
+       <div>
+               <div id="list1" class="foo">
+               <h3 class="bar"><a class="anchor">There is one obvious advantage:</a></h3>
+               <div class="foo">
+                   <p>
+                       You've seen it coming!
+                       <br/>
+                       Buy now and get nothing for free!
+                       <br/>
+                       Well, at least no free beer. Perhaps a bear, if you can afford it.
+                   </p>
+               </div>
+               <h3 class="bar"><a class="anchor">Now that you've got...</a></h3>
+               <div class="foo">
+                   <p>
+                       your bear, you have to admit it!
+                       <br/>
+                       No, we aren't selling bears.
+                   </p>
+                   <p>
+                       We could talk about renting one.
+                   </p>
+               </div>
+               <h3 class="bar"><a class="anchor">Rent one bear, ...</a></h3>
+               <div class="foo">
+                   <p>
+                       get two for three beer.
+                   </p>
+                   <p>
+                       And now, for something completely different.
+                   </p>
+               </div>
+               </div>
+       </div>
+
+<div id="navigationWrapper">
+       <ul id="navigation">
+               <li>
+                       <h2><a href="?p=1.1.1">Guitar</a></h2>
+                       <ul>
+                               <li><a href="?p=1.1.1.1">Electric</a></li>
+                               <li><a href="?p=1.1.1.2">Acoustic</a></li>
+                               <li><a href="?p=1.1.1.3">Amps</a></li>
+                               <li><a href="?p=1.1.1.4">Effects</a></li>
+                               <li><a href="?p=1.1.1.5">Accessories</a></li>
+                       </ul> 
+               </li>
+               <li>
+                       <h2><a href="?p=1.1.2"><span>Bass</span></a></h2>
+                       <ul>
+                               <li><a href="?p=1.1.2.1">Electric</a></li>
+                               <li><a href="?p=1.1.2.2">Acoustic</a></li>
+                               <li><a href="?p=1.1.2.3">Amps</a></li>
+                               <li><a href="?p=1.1.2.4">Effects</a></li>
+                               <li><a href="?p=1.1.2.5">Accessories</a></li>
+                               <li><a href="?p=1.1.2.5">Accessories</a></li>
+                               <li><a href="?p=1.1.2.5">Accessories</a></li>
+                       </ul> 
+               </li>
+               <li>
+                       <h2><a href="?p=1.1.3">Drums</a></h2>
+                       <ul>
+                               <li><a href="?p=1.1.3.2">Acoustic Drums</a></li>
+                               <li><a href="?p=1.1.3.3">Electronic Drums</a></li>
+                               <li><a href="?p=1.1.3.6">Accessories</a></li>
+                       </ul> 
+               </li>
+       </ul>
+</div>
+
+</div>
+
+</body>
+</html>
diff --git a/tests/unit/accordion/accordion_deprecated.js b/tests/unit/accordion/accordion_deprecated.js
new file mode 100644 (file)
index 0000000..b219cf8
--- /dev/null
@@ -0,0 +1,154 @@
+/*
+ * accordion_core.js
+ */
+
+
+(function($) {
+
+module("accordion (deprecated): expanded active option, activate method");
+
+test("activate", function() {
+       var expected = $('#list1').accordion(),
+               actual = expected.accordion('activate', 2);
+       equals(actual, expected, 'activate is chainable');
+});
+
+test("activate, numeric", function() {
+       var ac = $('#list1').accordion({ active: 1 });
+       state(ac, 0, 1, 0);
+       ac.accordion("activate", 2);
+       state(ac, 0, 0, 1);
+       ac.accordion("activate", 0);
+       state(ac, 1, 0, 0);
+       ac.accordion("activate", 1);
+       state(ac, 0, 1, 0);
+       ac.accordion("activate", 2);
+       state(ac, 0, 0, 1);
+});
+
+test("activate, boolean and numeric, collapsible:true", function() {
+       var ac = $('#list1').accordion({collapsible: true}).accordion("activate", 2);
+       state(ac, 0, 0, 1);
+       ok("x", "----");
+       ac.accordion("activate", 0);
+       state(ac, 1, 0, 0);
+       ok("x", "----");
+       ac.accordion("activate", -1);
+       state(ac, 0, 0, 0);
+});
+
+test("activate, boolean, collapsible: false", function() {
+       var ac = $('#list1').accordion().accordion("activate", 2);
+       state(ac, 0, 0, 1);
+       ac.accordion("activate", false);
+       state(ac, 0, 0, 1);
+});
+
+test("activate, string expression", function() {
+       var ac = $('#list1').accordion({ active: "h3:last" });
+       state(ac, 0, 0, 1);
+       ac.accordion("activate", ":first");
+       state(ac, 1, 0, 0);
+       ac.accordion("activate", ":eq(1)");
+       state(ac, 0, 1, 0);
+       ac.accordion("activate", ":last");
+       state(ac, 0, 0, 1);
+});
+
+test("activate, jQuery or DOM element", function() {
+       var ac = $('#list1').accordion({ active: $("#list1 h3:last") });
+       state(ac, 0, 0, 1);
+       ac.accordion("activate", $("#list1 h3:first"));
+       state(ac, 1, 0, 0);
+       ac.accordion("activate", $("#list1 h3")[1]);
+       state(ac, 0, 1, 0);
+});
+
+test("{ active: Selector }", function() {
+       var ac = $("#list1").accordion({
+               active: "h3:last"
+       });
+       state(ac, 0, 0, 1);
+       ac.accordion('option', 'active', "h3:eq(1)");
+       state(ac, 0, 1, 0);
+});
+
+test("{ active: Element }", function() {
+       var ac = $("#list1").accordion({
+               active: $("#list1 h3:last")[0]
+       });
+       state(ac, 0, 0, 1);
+       ac.accordion('option', 'active', $("#list1 h3:eq(1)")[0]);
+       state(ac, 0, 1, 0);
+});
+
+test("{ active: jQuery Object }", function() {
+       var ac = $("#list1").accordion({
+               active: $("#list1 h3:last")
+       });
+       state(ac, 0, 0, 1);
+       ac.accordion('option', 'active', $("#list1 h3:eq(1)"));
+       state(ac, 0, 1, 0);
+});
+
+
+
+
+
+
+module("accordion (deprecated) - height options");
+
+test("{ autoHeight: true }, default", function() {
+       equalHeights($('#navigation').accordion({ autoHeight: true }), 95, 130);
+});
+
+test("{ autoHeight: false }", function() {
+       var accordion = $('#navigation').accordion({ autoHeight: false });
+       var sizes = [];
+       accordion.find(".ui-accordion-content").each(function() {
+               sizes.push($(this).height());
+       });
+       ok( sizes[0] >= 70 && sizes[0] <= 90, "was " + sizes[0] );
+       ok( sizes[1] >= 98 && sizes[1] <= 126, "was " + sizes[1] );
+       ok( sizes[2] >= 42 && sizes[2] <= 54, "was " + sizes[2] );
+});
+
+// fillSpace: false == autoHeight: true, covered above
+test("{ fillSpace: true }", function() {
+       $("#navigationWrapper").height(500);
+       equalHeights($('#navigation').accordion({ fillSpace: true }), 446, 458);
+});
+
+test("{ fillSpace: true } with sibling", function() {
+       $("#navigationWrapper").height(500);
+       var sibling = $("<p>Lorem Ipsum</p>");
+       $("#navigationWrapper").prepend( sibling.height(100) );
+       //sibling.outerHeight(true) == 126
+       equalHeights($('#navigation').accordion({ fillSpace: true}), 320, 332);
+});
+
+test("{ fillSpace: true } with multiple siblings", function() {
+       $("#navigationWrapper").height(500);
+       var sibling = $("<p>Lorem Ipsum</p>");
+       $("#navigationWrapper")
+               .prepend( sibling.clone().height(100) )
+               .prepend( sibling.clone().height(100).css( "position", "absolute" ) )
+               .prepend( sibling.clone().height(50) );
+       //sibling.outerHeight(true) == 126
+       equalHeights($('#navigation').accordion({ fillSpace: true}), 244, 256);
+});
+
+
+
+
+module("accordion (deprecated) - icons");
+
+test("change headerSelected option after creation", function() {
+       var list = $("#list1");
+       list.accordion( { icons: { "activeHeader": "test" } } );
+       equals( $( "#list1 span.test" ).length, 1);
+       list.accordion( "option", "icons", { "headerSelected": "deprecated" } );
+       equals( $( "#list1 span.deprecated" ).length, 1);
+});
+
+})(jQuery);
index c801851d0c24bbee144366f7e61c49ba169224ea..c6754d2773fcb2b04ab9421b7e025d5bb710a6b5 100644 (file)
@@ -57,66 +57,9 @@ test("disable", function() {
        state(expected, 0, 1, 0)
 });
 
-test("activate", function() {
-       var expected = $('#list1').accordion(),
-               actual = expected.accordion('activate', 2);
-       equals(actual, expected, 'activate is chainable');
-});
-
-test("activate, numeric", function() {
-       var ac = $('#list1').accordion({ active: 1 });
-       state(ac, 0, 1, 0);
-       ac.accordion("activate", 2);
-       state(ac, 0, 0, 1);
-       ac.accordion("activate", 0);
-       state(ac, 1, 0, 0);
-       ac.accordion("activate", 1);
-       state(ac, 0, 1, 0);
-       ac.accordion("activate", 2);
-       state(ac, 0, 0, 1);
-});
-
-test("activate, boolean and numeric, collapsible:true", function() {
-       var ac = $('#list1').accordion({collapsible: true}).accordion("activate", 2);
-       state(ac, 0, 0, 1);
-       ok("x", "----");
-       ac.accordion("activate", 0);
-       state(ac, 1, 0, 0);
-       ok("x", "----");
-       ac.accordion("activate", -1);
-       state(ac, 0, 0, 0);
-});
-
-test("activate, boolean, collapsible: false", function() {
-       var ac = $('#list1').accordion().accordion("activate", 2);
-       state(ac, 0, 0, 1);
-       ac.accordion("activate", false);
-       state(ac, 0, 0, 1);
-});
-
-test("activate, string expression", function() {
-       var ac = $('#list1').accordion({ active: "h3:last" });
-       state(ac, 0, 0, 1);
-       ac.accordion("activate", ":first");
-       state(ac, 1, 0, 0);
-       ac.accordion("activate", ":eq(1)");
-       state(ac, 0, 1, 0);
-       ac.accordion("activate", ":last");
-       state(ac, 0, 0, 1);
-});
-
-test("activate, jQuery or DOM element", function() {
-       var ac = $('#list1').accordion({ active: $("#list1 h3:last") });
-       state(ac, 0, 0, 1);
-       ac.accordion("activate", $("#list1 h3:first"));
-       state(ac, 1, 0, 0);
-       ac.accordion("activate", $("#list1 h3")[1]);
-       state(ac, 0, 1, 0);
-});
-
 test("refresh", function() {
        var expected = $('#navigation').parent().height(300).end().accordion({
-               fillSpace: true
+               heightStyle: "fill"
        });
        equalHeights(expected, 246, 258);
        
index abfb82d784b9e1865a24106c4e87f2e535f1bdd8..c7b4038efe3f784a7bf3739e77c3f69cd632d917 100644 (file)
@@ -11,33 +11,6 @@ test("{ active: first child }, default", function() {
        state(ac, 1, 0, 0)
 });
 
-test("{ active: Selector }", function() {
-       var ac = $("#list1").accordion({
-               active: "h3:last"
-       });
-       state(ac, 0, 0, 1);
-       ac.accordion('option', 'active', "h3:eq(1)");
-       state(ac, 0, 1, 0);
-});
-
-test("{ active: Element }", function() {
-       var ac = $("#list1").accordion({
-               active: $("#list1 h3:last")[0]
-       });
-       state(ac, 0, 0, 1);
-       ac.accordion('option', 'active', $("#list1 h3:eq(1)")[0]);
-       state(ac, 0, 1, 0);
-});
-
-test("{ active: jQuery Object }", function() {
-       var ac = $("#list1").accordion({
-               active: $("#list1 h3:last")
-       });
-       state(ac, 0, 0, 1);
-       ac.accordion('option', 'active', $("#list1 h3:eq(1)"));
-       state(ac, 0, 1, 0);
-});
-
 test("{ active: false }", function() {
        var ac = $("#list1").accordion({
                active: false,
@@ -65,25 +38,10 @@ test("{ active: Number }", function() {
        equals( $("#list1").accordion('option', 'active'), 0);
 });
 
-test("{ autoHeight: true }, default", function() {
-       equalHeights($('#navigation').accordion({ autoHeight: true }), 95, 130);
-});
-
 test("{ heightStyle: 'auto' }, default", function() {
        equalHeights($('#navigation').accordion({ heightStyle: 'auto' }), 95, 130);
 });
 
-test("{ autoHeight: false }", function() {
-       var accordion = $('#navigation').accordion({ autoHeight: false });
-       var sizes = [];
-       accordion.find(".ui-accordion-content").each(function() {
-               sizes.push($(this).height());
-       });
-       ok( sizes[0] >= 70 && sizes[0] <= 90, "was " + sizes[0] );
-       ok( sizes[1] >= 98 && sizes[1] <= 126, "was " + sizes[1] );
-       ok( sizes[2] >= 42 && sizes[2] <= 54, "was " + sizes[2] );
-});
-
 test("{ heightStyle: 'content' }", function() {
        var accordion = $('#navigation').accordion({ heightStyle: 'content' });
        var sizes = [];
@@ -110,36 +68,11 @@ test("{ collapsible: true }", function() {
        state(ac, 0, 0, 0);
 });
 
-// fillSpace: false == autoHeight: true, covered above
-test("{ fillSpace: true }", function() {
-       $("#navigationWrapper").height(500);
-       equalHeights($('#navigation').accordion({ fillSpace: true }), 446, 458);
-});
-
 test("{ heightStyle: 'fill' }", function() {
        $("#navigationWrapper").height(500);
        equalHeights($('#navigation').accordion({ heightStyle: 'fill' }), 446, 458);
 });
 
-test("{ fillSpace: true } with sibling", function() {
-       $("#navigationWrapper").height(500);
-       var sibling = $("<p>Lorem Ipsum</p>");
-       $("#navigationWrapper").prepend( sibling.height(100) );
-       //sibling.outerHeight(true) == 126
-       equalHeights($('#navigation').accordion({ fillSpace: true}), 320, 332);
-});
-
-test("{ fillSpace: true } with multiple siblings", function() {
-       $("#navigationWrapper").height(500);
-       var sibling = $("<p>Lorem Ipsum</p>");
-       $("#navigationWrapper")
-               .prepend( sibling.clone().height(100) )
-               .prepend( sibling.clone().height(100).css( "position", "absolute" ) )
-               .prepend( sibling.clone().height(50) );
-       //sibling.outerHeight(true) == 126
-       equalHeights($('#navigation').accordion({ fillSpace: true}), 244, 256);
-});
-
 test("{ header: '> li > :first-child,> :not(li):even' }, default", function() {
        state($("#list1").accordion(), 1, 0, 0);
        state($("#navigation").accordion(), 1, 0, 0);
@@ -192,12 +125,4 @@ test("{ navigation: true, navigationFilter: content }", function() {
        equals( $("#navigation .ui-accordion-content:eq(2)").size(), 1, "third content active" );
 });
 
-test("change headerSelected option after creation", function() {
-       var list = $("#list1");
-       list.accordion( { icons: { "activeHeader": "test" } } );
-       equals( $( "#list1 span.test" ).length, 1);
-       list.accordion( "option", "icons", { "headerSelected": "deprecated" } );
-       equals( $( "#list1 span.deprecated" ).length, 1);
-});
-
 })(jQuery);
index b9147abe08e22647c1840491da81645ee33c2cc8..a06cd2a2a6cfaa2d37145afb63afcfbe7e7afc3f 100644 (file)
@@ -20,12 +20,10 @@ $.widget( "ui.accordion", {
                collapsible: false,
                event: "click",
                header: "> li > :first-child,> :not(li):even",
-               // TODO: set to "auto" in 2.0 (#5868, #5872)
-               heightStyle: null, // "auto"
+               heightStyle: "auto",
                icons: {
                        header: "ui-icon-triangle-1-e",
-                       // TODO: set to "ui-icon-triangle-1-s" in 2.0 (#6835)
-                       activeHeader: null // "ui-icon-triangle-1-s"
+                       activeHeader: "ui-icon-triangle-1-s"
                }
        },
 
@@ -599,115 +597,120 @@ $.extend( $.ui.accordion, {
 
 
 // DEPRECATED
-
-// navigation options
-(function( $, prototype ) {
-       $.extend( prototype.options, {
-               navigation: false,
-               navigationFilter: function() {
-                       return this.href.toLowerCase() === location.href.toLowerCase();
-               }
-       });
-
-       var _create = prototype._create;
-       prototype._create = function() {
-               if ( this.options.navigation ) {
-                       var self = this,
-                               headers = this.element.find( this.options.header ),
-                               content = headers.next();
-                               current = headers.add( content )
-                                       .find( "a" )
-                                       .filter( this.options.navigationFilter )
-                                       [ 0 ];
-                       if ( current ) {
-                               headers.add( content ).each( function( index ) {
-                                       if ( $.contains( this, current ) ) {
-                                               self.options.active = Math.floor( index / 2 );
-                                               return false;
-                                       }
-                               });
+if ( $.uiBackCompat !== false ) {
+       // navigation options
+       (function( $, prototype ) {
+               $.extend( prototype.options, {
+                       navigation: false,
+                       navigationFilter: function() {
+                               return this.href.toLowerCase() === location.href.toLowerCase();
+                       }
+               });
+
+               var _create = prototype._create;
+               prototype._create = function() {
+                       if ( this.options.navigation ) {
+                               var self = this,
+                                       headers = this.element.find( this.options.header ),
+                                       content = headers.next();
+                                       current = headers.add( content )
+                                               .find( "a" )
+                                               .filter( this.options.navigationFilter )
+                                               [ 0 ];
+                               if ( current ) {
+                                       headers.add( content ).each( function( index ) {
+                                               if ( $.contains( this, current ) ) {
+                                                       self.options.active = Math.floor( index / 2 );
+                                                       return false;
+                                               }
+                                       });
+                               }
                        }
-               }
-               _create.call( this );
-       };
-}( jQuery, jQuery.ui.accordion.prototype ) );
-
-// height options
-(function( $, prototype ) {
-       $.extend( prototype.options, {
-               autoHeight: true, // use heightStyle: "auto"
-               clearStyle: false, // use heightStyle: "content"
-               fillSpace: false // use heightStyle: "fill"
-       });
-
-       var _create = prototype._create,
-               _setOption = prototype._setOption;
-
-       $.extend( prototype, {
-               _create: function() {
-                       this.options.heightStyle = this.options.heightStyle ||
-                               this._mergeHeightStyle();
-
                        _create.call( this );
-               },
+               };
+       }( jQuery, jQuery.ui.accordion.prototype ) );
+
+       // height options
+       (function( $, prototype ) {
+               $.extend( prototype.options, {
+                       heightStyle: null, // remove default so we fall back to old values
+                       autoHeight: true, // use heightStyle: "auto"
+                       clearStyle: false, // use heightStyle: "content"
+                       fillSpace: false // use heightStyle: "fill"
+               });
+
+               var _create = prototype._create,
+                       _setOption = prototype._setOption;
+
+               $.extend( prototype, {
+                       _create: function() {
+                               this.options.heightStyle = this.options.heightStyle ||
+                                       this._mergeHeightStyle();
+
+                               _create.call( this );
+                       },
 
-               _setOption: function( key, value ) {
-                       if ( key === "autoHeight" || key === "clearStyle" || key === "fillSpace" ) {
-                               this.options.heightStyle = this._mergeHeightStyle();
-                       }
-                       _setOption.apply( this, arguments );
-               },
+                       _setOption: function( key, value ) {
+                               if ( key === "autoHeight" || key === "clearStyle" || key === "fillSpace" ) {
+                                       this.options.heightStyle = this._mergeHeightStyle();
+                               }
+                               _setOption.apply( this, arguments );
+                       },
 
-               _mergeHeightStyle: function() {
-                       var options = this.options;
+                       _mergeHeightStyle: function() {
+                               var options = this.options;
 
-                       if ( options.fillSpace ) {
-                               return "fill";
-                       }
+                               if ( options.fillSpace ) {
+                                       return "fill";
+                               }
 
-                       if ( options.clearStyle ) {
-                               return "content";
-                       }
+                               if ( options.clearStyle ) {
+                                       return "content";
+                               }
 
-                       if ( options.autoHeight ) {
-                               return "auto";
+                               if ( options.autoHeight ) {
+                                       return "auto";
+                               }
                        }
-               }
-       });
-}( jQuery, jQuery.ui.accordion.prototype ) );
-
-// icon options
-(function( $, prototype ) {
-       prototype.options.icons.headerSelected = "ui-icon-triangle-1-s";
-
-       var _createIcons = prototype._createIcons;
-       prototype._createIcons = function() {
-               this.options.icons.activeHeader = this.options.icons.activeHeader ||
-                       this.options.icons.headerSelected;
-               _createIcons.call( this );
-       };
-}( jQuery, jQuery.ui.accordion.prototype ) );
-
-// expanded active option, activate method
-(function( $, prototype ) {
-       prototype.activate = prototype._activate;
-
-       var _findActive = prototype._findActive;
-       prototype._findActive = function( index ) {
-               if ( index === -1 ) {
-                       index = false;
-               }
-               if ( index && typeof index !== "number" ) {
-                       index = this.headers.index( this.headers.filter( index ) );
+               });
+       }( jQuery, jQuery.ui.accordion.prototype ) );
+
+       // icon options
+       (function( $, prototype ) {
+               $.extend( prototype.options.icons, {
+                       activeHeader: null, // remove default so we fall back to old values
+                       headerSelected: "ui-icon-triangle-1-s"
+               });
+
+               var _createIcons = prototype._createIcons;
+               prototype._createIcons = function() {
+                       this.options.icons.activeHeader = this.options.icons.activeHeader ||
+                               this.options.icons.headerSelected;
+                       _createIcons.call( this );
+               };
+       }( jQuery, jQuery.ui.accordion.prototype ) );
+
+       // expanded active option, activate method
+       (function( $, prototype ) {
+               prototype.activate = prototype._activate;
+
+               var _findActive = prototype._findActive;
+               prototype._findActive = function( index ) {
                        if ( index === -1 ) {
                                index = false;
                        }
-               }
-               return _findActive.call( this, index );
-       };
-}( jQuery, jQuery.ui.accordion.prototype ) );
+                       if ( index && typeof index !== "number" ) {
+                               index = this.headers.index( this.headers.filter( index ) );
+                               if ( index === -1 ) {
+                                       index = false;
+                               }
+                       }
+                       return _findActive.call( this, index );
+               };
+       }( jQuery, jQuery.ui.accordion.prototype ) );
 
-// resize method
-jQuery.ui.accordion.prototype.resize = jQuery.ui.accordion.prototype.refresh;
+       // resize method
+       jQuery.ui.accordion.prototype.resize = jQuery.ui.accordion.prototype.refresh;
+}
 
 })( jQuery );