]> source.dussan.org Git - archiva.git/commitdiff
revise tasklist
authorBrett Porter <brett@apache.org>
Wed, 7 Jun 2006 07:44:47 +0000 (07:44 +0000)
committerBrett Porter <brett@apache.org>
Wed, 7 Jun 2006 07:44:47 +0000 (07:44 +0000)
git-svn-id: https://svn.apache.org/repos/asf/maven/repository-manager/trunk@412316 13f79535-47bb-0310-9956-ffa450edef68

12 files changed:
maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java
maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java
maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java
maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java
maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java
maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java
maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java
maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java
maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java
maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java
maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java

index 635d8edfaed18ca961d1fba1cdbf0f66b9d747bd..da93693504d4757b66e3c11b8fd48668f0c8e5b6 100644 (file)
@@ -29,7 +29,7 @@ import java.security.NoSuchAlgorithmException;
 import java.security.PrivilegedAction;
 
 /**
- * TODO: Description.
+ * Applet that takes a file on the local filesystem and checksums it for sending to the server.
  *
  * @author <a href="mailto:brett@apache.org">Brett Porter</a>
  */
index d2efc3a58a70e317b4944c27d7db5e3c53906a9c..65db8a50d6c9168a9f5726cfc8ff562e9b9b1f0d 100644 (file)
@@ -28,7 +28,7 @@ import java.util.Iterator;
 import java.util.List;
 
 /**
- * TODO [!]: Description.
+ * Base class for the artifact and metadata discoverers.
  *
  * @author <a href="mailto:brett@apache.org">Brett Porter</a>
  */
index dc1d3c9b8ea62760beda15605897d1f9ef328018..52b011b77b4169998f2f4cf367be1e8d31f9af9a 100644 (file)
@@ -39,7 +39,6 @@ public interface ArtifactDiscoverer
      * @param blacklistedPatterns pattern that lists any files to prevent from being included when scanning
      * @param includeSnapshots    whether to discover snapshots
      * @return the list of artifacts discovered
-     * @todo replace repositoryBase with wagon repository
      * @todo do we want blacklisted patterns in another form? Part of the object construction?
      * @todo should includeSnapshots be configuration on the component?
      * @todo instead of a returned list, should a listener be passed in?
@@ -53,7 +52,6 @@ public interface ArtifactDiscoverer
      * @param blacklistedPatterns pattern that lists any files to prevent from being included when scanning
      * @param includeSnapshots    whether to discover snapshots
      * @return the list of artifacts discovered
-     * @todo replace repositoryBase with wagon repository
      * @todo do we want blacklisted patterns in another form? Part of the object construction?
      * @todo should includeSnapshots be configuration on the component?
      * @todo instead of a returned list, should a listener be passed in?
index 20f9d3d87184ffc175f8f2107712a8c97e20ee17..f68e799be0d25c86a8b527c1a63ea0c99cf2ce53 100644 (file)
@@ -179,19 +179,19 @@ public class DefaultMetadataDiscoverer
         }
         catch ( FileNotFoundException fe )
         {
-            // TODO: log ignored metadata
+            // TODO: log ignored metadata!
         }
         catch ( XmlPullParserException xe )
         {
-            // TODO: log ignored metadata
+            // TODO: log ignored metadata!
         }
         catch ( MalformedURLException e )
         {
-            // TODO: log ignored metadata
+            // TODO: log ignored metadata!
         }
         catch ( IOException ie )
         {
-            // TODO: log ignored metadata
+            // TODO: log ignored metadata!
         }
 
         return metadata;
index 0eaf52a66f7a71055ec8cc923b69a58260abf682..08812b4de89d66e9bf79cd53ec71b01502eef09d 100644 (file)
@@ -52,7 +52,7 @@ import java.util.Map;
  * @author Edwin Punzalan
  * @plexus.component role="org.apache.maven.repository.proxy.ProxyManager"
  * @todo too much of wagon manager is reproduced here because checksums need to be downloaded separately - is that necessary?
- * @todo this isn't reusing the parts of wagon manager than handle snapshots
+ * @todo this isn't reusing the parts of wagon manager than handle snapshots [!]
  */
 public class DefaultProxyManager
     extends AbstractLogEnabled
@@ -297,13 +297,13 @@ public class DefaultProxyManager
 
     private ArtifactRepositoryPolicy getReleasesPolicy()
     {
-        //todo get policy configuration from ProxyConfiguration
+        //todo get policy configuration from ProxyConfiguration [!]
         return new ArtifactRepositoryPolicy();
     }
 
     private ArtifactRepositoryPolicy getSnapshotsPolicy()
     {
-        //todo get policy configuration from ProxyConfiguration
+        //todo get policy configuration from ProxyConfiguration [!]
         return new ArtifactRepositoryPolicy();
     }
 
@@ -392,7 +392,7 @@ public class DefaultProxyManager
         {
             wagon = wagonManager.getWagon( repository.getProtocol() );
 
-            //@todo configure wagonManager
+            //@todo configure wagonManager [!]
 
             if ( useChecksum )
             {
index aec5ec0686f7c0280d350f8aa00f19d9771ddf10..b03bde0baec2943e549275e7a578b7a21e02cfd7 100644 (file)
@@ -25,7 +25,7 @@ import java.io.File;
  * Class used to bridge the servlet to the repository proxy implementation.
  *
  * @author Edwin Punzalan
- * @todo the names get() and getRemoteFile() are confusing
+ * @todo the names get() and getRemoteFile() are confusing [!]
  */
 public interface ProxyManager
 {
index d873c0af2e57b7b617ecd327a4620267154b67ad..b46acd1e0250ab438f668ea074410bb73e8e1413 100644 (file)
@@ -29,7 +29,7 @@ import java.util.List;
  *
  * @author Edwin Punzalan
  * @plexus.component role="org.apache.maven.repository.proxy.configuration.ProxyConfiguration"
- * @todo investigate how these should be set - probably plexus configuration
+ * @todo investigate how these should be set - probably plexus configuration [!]
  */
 public class ProxyConfiguration
 {
index f4bf85ff6dca9c100304c8326565e4b523db02ae..b0c1eac2748fe1ff50a5b5f2feace5a1562d86eb 100644 (file)
@@ -30,8 +30,7 @@ public class CachedRepositoryQueryLayer
 {
     private Cache cache;
 
-    private static final double CACHE_HIT_RATIO = 0.5;
-
+    public static final double CACHE_HIT_RATIO = 0.5;
 
     public CachedRepositoryQueryLayer( ArtifactRepository repository )
     {
index 6c8e535cba19f3b0308ce269998b7e6bd5bee431..11c0b8e9560386715fad8f142ff9887dfe60af11 100644 (file)
@@ -22,8 +22,6 @@ package org.apache.maven.repository.reporting;
 public class CachedRepositoryQueryLayerTest
     extends AbstractRepositoryQueryLayerTestCase
 {
-    // TODO: share
-    private static final double CACHE_HIT_RATIO = 0.5;
 
     protected void setUp()
         throws Exception
@@ -38,7 +36,7 @@ public class CachedRepositoryQueryLayerTest
         testContainsArtifactTrue();
         assertEquals( 0, queryLayer.getCacheHitRate(), 0 );
         testContainsArtifactTrue();
-        assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
+        assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
     }
 
     public void testUseMetadataCache()
@@ -47,7 +45,7 @@ public class CachedRepositoryQueryLayerTest
         testArtifactVersionsTrue();
         assertEquals( 0, queryLayer.getCacheHitRate(), 0 );
         testArtifactVersionsTrue();
-        assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
+        assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
     }
 
     public void testUseFileCacheOnSnapshot()
@@ -55,6 +53,6 @@ public class CachedRepositoryQueryLayerTest
         testContainsSnapshotArtifactTrue();
         assertEquals( 0, queryLayer.getCacheHitRate(), 0 );
         testContainsSnapshotArtifactTrue();
-        assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
+        assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
     }
 }
index 409dcc179aa47b684b7d5a36244d27fc51d32762..b13a48416d1615ddecad87bec4458dd28bb023ad 100644 (file)
@@ -33,7 +33,7 @@ import java.net.MalformedURLException;
 import java.util.List;
 
 /**
- * TODO: Description.
+ * Search by package name.
  *
  * @author <a href="mailto:brett@apache.org">Brett Porter</a>
  * @plexus.component role="com.opensymphony.xwork.Action" role-hint="org.apache.maven.repository.manager.web.action.PackageSearchAction"
@@ -82,7 +82,7 @@ public class PackageSearchAction
             return ERROR;
         }
 
-        // TODO: better config
+        // TODO: better config [!]
         String indexPath = configuration.getIndexDirectory();
 
         // TODO: reduce the amount of lookup?
index 870fe06fd683131cad8a888804432a95f042e9dc..764adae5b15865a33970790097b8209eaeede782 100644 (file)
@@ -31,7 +31,7 @@ import java.util.Map;
 import java.util.TreeMap;\r
 \r
 /**\r
- * TODO: Description.\r
+ * Browse the repository.\r
  *\r
  * @plexus.component role="com.opensymphony.xwork.Action" role-hint="org.apache.maven.repository.manager.web.action.RepositoryBrowseAction"\r
  */\r
index dcff2a79869db1efa42b1a63fd86b57643d8e3cf..975808b96fab2fd19d953f402f3f89ce652b2c01 100644 (file)
@@ -156,7 +156,7 @@ public class DiscovererExecution
      *
      * @throws MalformedURLException
      * @throws RepositoryIndexException
-     * @todo why is this any different from legacy?
+     * @todo why is this any different from legacy? [!]
      */
     protected void executeDiscovererInDefaultRepo()
         throws MalformedURLException, RepositoryIndexException