}
String data = batchMeasure.hasStringValue() ? batchMeasure.getStringValue() : null;
- switch (metric.getMetricType().getValueType()) {
+ switch (metric.getType().getValueType()) {
case INT:
return toIntegerMeasure(batchMeasure, data);
case LONG:
case NO_VALUE:
return toNoValueMeasure(batchMeasure);
default:
- throw new IllegalArgumentException("Unsupported Measure.ValueType " + metric.getMetricType().getValueType());
+ throw new IllegalArgumentException("Unsupported Measure.ValueType " + metric.getType().getValueType());
}
}
* <p>
* If the measure type is {@link Measure.ValueType#STRING}, the value returned by this function is the same as {@link #getStringValue()}.
* </p>
- *
- * @throws IllegalStateException if the value type of the measure is not {@link Measure.ValueType#BOOLEAN}
*/
@CheckForNull
String getData();
Double value = measureDto.getValue();
String data = measureDto.getData();
- switch (metric.getMetricType().getValueType()) {
+ switch (metric.getType().getValueType()) {
case INT:
return toIntegerMeasure(measureDto, value, data);
case LONG:
case NO_VALUE:
return toNoValueMeasure(measureDto);
default:
- throw new IllegalArgumentException("Unsupported Measure.ValueType " + metric.getMetricType().getValueType());
+ throw new IllegalArgumentException("Unsupported Measure.ValueType " + metric.getType().getValueType());
}
}
String getName();
- MetricType getMetricType();
+ MetricType getType();
enum MetricType {
INT(Measure.ValueType.INT),
private final String key;
private final String name;
- private final MetricType metricType;
+ private final MetricType type;
- public MetricImpl(String key, String name, MetricType metricType) {
+ public MetricImpl(String key, String name, MetricType type) {
this.key = requireNonNull(key);
this.name = requireNonNull(name);
- this.metricType = requireNonNull(metricType);
+ this.type = requireNonNull(type);
}
@Override
}
@Override
- public MetricType getMetricType() {
- return metricType;
+ public MetricType getType() {
+ return type;
}
@Override
}
MetricImpl metric = (MetricImpl) o;
return Objects.equals(key, metric.key) &&
- Objects.equals(metricType, metric.metricType);
+ Objects.equals(type, metric.type);
}
@Override
public int hashCode() {
- return Objects.hash(key, metricType);
+ return Objects.hash(key, type);
}
@Override
return com.google.common.base.Objects.toStringHelper(this)
.add("key", key)
.add("name", name)
- .add("metricType", metricType)
+ .add("type", type)
.toString();
}
}
@Before
public void setUp() throws Exception {
when(metric1.getKey()).thenReturn(METRIC_KEY_1);
- when(metric1.getMetricType()).thenReturn(Metric.MetricType.STRING);
+ when(metric1.getType()).thenReturn(Metric.MetricType.STRING);
when(metric2.getKey()).thenReturn(METRIC_KEY_2);
- when(metric2.getMetricType()).thenReturn(Metric.MetricType.STRING);
+ when(metric2.getType()).thenReturn(Metric.MetricType.STRING);
// references to metrics are consistent with DB by design
when(metricRepository.getByKey(METRIC_KEY_1)).thenReturn(metric1);
assertThat(metric.getKey()).isEqualTo(SOME_KEY);
assertThat(metric.getName()).isEqualTo(SOME_NAME);
- assertThat(metric.getMetricType()).isEqualTo(Metric.MetricType.FLOAT);
+ assertThat(metric.getType()).isEqualTo(Metric.MetricType.FLOAT);
}
@Test
@Test
public void all_fields_are_displayed_in_toString() {
assertThat(new MetricImpl(SOME_KEY, SOME_NAME, Metric.MetricType.FLOAT).toString())
- .isEqualTo("MetricImpl{key=key, name=name, metricType=FLOAT}");
+ .isEqualTo("MetricImpl{key=key, name=name, type=FLOAT}");
}
}
assertThat(metric.getKey()).isEqualTo(metricDto.getKey());
assertThat(metric.getName()).isEqualTo(metricDto.getShortName());
- assertThat(metric.getMetricType()).isEqualTo(expected);
+ assertThat(metric.getType()).isEqualTo(expected);
}
@Test(expected = IllegalArgumentException.class)