Let the database count the entries

Signed-off-by: Joas Schilling <coding@schilljs.com>

diff --git a/lib/private/Security/Bruteforce/Throttler.php b/lib/private/Security/Bruteforce/Throttler.php
index 8e4850466029288a2ec59243eee405270e4de1e8..e5d3c3503ba23f23028fd2d08cf7f826ac9592bd 100644 (file)
--- a/lib/private/Security/Bruteforce/Throttler.php
+++ b/lib/private/Security/Bruteforce/Throttler.php
@@ -228,7 +228,7 @@ class Throttler {
                $cutoffTime = $this->getCutoffTimestamp();
 
                $qb = $this->db->getQueryBuilder();
-               $qb->select('*')
+               $qb->select($qb->func()->count('*', 'attempts'))
                        ->from('bruteforce_attempts')
                        ->where($qb->expr()->gt('occurred', $qb->createNamedParameter($cutoffTime)))
                        ->andWhere($qb->expr()->eq('subnet', $qb->createNamedParameter($ipAddress->getSubnet())));
@@ -237,7 +237,11 @@ class Throttler {
                        $qb->andWhere($qb->expr()->eq('action', $qb->createNamedParameter($action)));
                }
 
-               $attempts = count($qb->execute()->fetchAll());
+               $result = $qb->execute();
+               $row = $result->fetch();
+               $result->closeCursor();
+
+               $attempts = (int) $row['attempts'];
 
                if ($attempts === 0) {
                        return 0;