Fix quality flaws

diff --git a/sonar-db/src/main/java/org/sonar/db/version/DecimalColumnDef.java b/sonar-db/src/main/java/org/sonar/db/version/DecimalColumnDef.java
index e131f917496e2311a671d3d7075201d6f2815db1..733564a1164471452c56dfb2fa1c81dcec30239e 100644 (file)
--- a/sonar-db/src/main/java/org/sonar/db/version/DecimalColumnDef.java
+++ b/sonar-db/src/main/java/org/sonar/db/version/DecimalColumnDef.java
@@ -32,8 +32,8 @@ import static org.sonar.db.version.ColumnDefValidation.validateColumnName;
 
 public class DecimalColumnDef extends AbstractColumnDef {
 
-  public static int DEFAULT_PRECISION = 38;
-  public static int DEFAULT_SACLE = 20;
+  public final static int DEFAULT_PRECISION = 38;
+  public final static int DEFAULT_SCALE = 20;
 
   private final int precision;
   private final int scale;
@@ -76,7 +76,7 @@ public class DecimalColumnDef extends AbstractColumnDef {
     @CheckForNull
     private String columnName;
     private int precision = DEFAULT_PRECISION;
-    private int scale = DEFAULT_SACLE;
+    private int scale = DEFAULT_SCALE;
     private boolean isNullable = false;
 
     public Builder setColumnName(String columnName) {

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Formula.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Formula.java
index 30f923c727e7e98ab3229d9f33ed3b35b466f379..83fecc8b27428e6780fc0ea1f2ed872bab051b10 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Formula.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Formula.java
@@ -23,8 +23,7 @@ import java.util.List;
 
 /**
  * @since 1.11
- * @deprecated since 5.2 there's no more decorator on batch side
- * TODO add link to new API
+ * @deprecated since 5.2 there's no more decorator on batch side, please use {@link org.sonar.api.ce.measure.MeasureComputer} instead
  */
 @Deprecated
 public interface Formula {

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java
index cd4304e53490b4b2190d5c91cd56d3a0040f6666..949e0ab603c9ff80a18cae1f31a87f126cbf4a58 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java
@@ -231,8 +231,7 @@ public class Metric<G extends Serializable> implements Serializable, org.sonar.a
 
   /**
    * @return the metric formula
-   * @deprecated since 5.2 there's no more decorator on batch side
-   * TODO add link to new API
+   * @deprecated since 5.2 there's no more decorator on batch side, please use {@link org.sonar.api.ce.measure.MeasureComputer} instead
    */
   @Deprecated
   public Formula getFormula() {
@@ -244,8 +243,7 @@ public class Metric<G extends Serializable> implements Serializable, org.sonar.a
    *
    * @param formula the formula
    * @return this
-   * @deprecated since 5.2 there's no more decorator on batch side
-   * TODO add link to new API
+   * @deprecated since 5.2 there's no more decorator on batch side, please use {@link org.sonar.api.ce.measure.MeasureComputer} instead
    */
   @Deprecated
   public Metric<G> setFormula(Formula formula) {
@@ -657,8 +655,7 @@ public class Metric<G extends Serializable> implements Serializable, org.sonar.a
      * @param f the formula
      * @return the builder
      *
-     * @deprecated since 5.2, it's no more possible to define a formula on a metric
-     * TODO add a link to the new API to declare formulas
+     * @deprecated since 5.2, it's no more possible to define a formula on a metric, please use {@link org.sonar.api.ce.measure.MeasureComputer} instead
      */
     @Deprecated
     public Builder setFormula(Formula f) {