Disable tooltip tests for Firefox.

Since the fix for #13370 which causes tooltips to react to mouseOut,
TB tests for tooltips fail on Firefox because of an extraneous
mouseOut event from FirefoxDriver.

Tooltips do work in manual tests also on Firefox.

Change-Id: Ic6d73bb4487749618bbc5c7e3a8416107adb4856

diff --git a/uitest/src/test/java/com/vaadin/tests/components/grid/basicfeatures/GridDescriptionGeneratorTest.java b/uitest/src/test/java/com/vaadin/tests/components/grid/basicfeatures/GridDescriptionGeneratorTest.java
index ed712361a66e32e01c375f817191e45e81e9c7c2..ac494efc2c4c9ec1401729d080ef9876d73e2aa3 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/grid/basicfeatures/GridDescriptionGeneratorTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/grid/basicfeatures/GridDescriptionGeneratorTest.java
@@ -18,8 +18,11 @@ package com.vaadin.tests.components.grid.basicfeatures;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 
+import java.util.List;
+
 import org.junit.Test;
 import org.openqa.selenium.By;
+import org.openqa.selenium.remote.DesiredCapabilities;
 
 public class GridDescriptionGeneratorTest extends GridBasicFeaturesTest {
 
@@ -71,4 +74,9 @@ public class GridDescriptionGeneratorTest extends GridBasicFeaturesTest {
         assertEquals("Tooltip text", "Row tooltip for row 5", tooltipText);
     }
 
+    @Override
+    public List<DesiredCapabilities> getBrowsersToTest() {
+        return getBrowsersExcludingFirefox();
+    }
+
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/components/label/LabelTooltipTest.java b/uitest/src/test/java/com/vaadin/tests/components/label/LabelTooltipTest.java
index 600cc4231a46c0d165654efae9b5c78388ddebba..36606b9972c883ef878fafb6ce9541e2c82aa310 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/label/LabelTooltipTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/label/LabelTooltipTest.java
@@ -16,10 +16,12 @@
 package com.vaadin.tests.components.label;
 
 import java.io.IOException;
+import java.util.List;
 
 import org.junit.Assert;
 import org.junit.Test;
 import org.openqa.selenium.interactions.Actions;
+import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.LabelElement;
 import com.vaadin.tests.tb3.MultiBrowserTest;
@@ -69,4 +71,11 @@ public class LabelTooltipTest extends MultiBrowserTest {
         /* Visual comparison */
         compareScreen("tooltipVisible");
     }
+
+    @Override
+    public List<DesiredCapabilities> getBrowsersToTest() {
+        // this test also works on IEs, but Firefox has problems with tooltips
+        return getBrowsersExcludingFirefox();
+    }
+
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/components/window/ToolTipInWindowTest.java b/uitest/src/test/java/com/vaadin/tests/components/window/ToolTipInWindowTest.java
index 40332e7730b57ba4b6c9cfdae4e3d0f80a186b30..abe2bcbe361bdcdfe5aa621e74487f022eb9f1df 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/window/ToolTipInWindowTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/window/ToolTipInWindowTest.java
@@ -71,7 +71,7 @@ public class ToolTipInWindowTest extends MultiBrowserTest {
     @Override
     public List<DesiredCapabilities> getBrowsersToTest() {
         // Test with the same browsers as in the other tooltip tests
-        return getBrowsersExcludingIE();
+        return getBrowsersSupportingTooltip();
     }
 
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/fieldgroup/BooleanTextFieldTest.java b/uitest/src/test/java/com/vaadin/tests/fieldgroup/BooleanTextFieldTest.java
index 7a74deb2e0ebeaf34f5f794c648d544a44644c69..abbe4128dd99114e19cbc008210b7d86c230e1f4 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/fieldgroup/BooleanTextFieldTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/fieldgroup/BooleanTextFieldTest.java
@@ -1,9 +1,12 @@
 package com.vaadin.tests.fieldgroup;
 
+import java.util.List;
+
 import org.junit.Assert;
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.Keys;
+import org.openqa.selenium.remote.DesiredCapabilities;
 
 public class BooleanTextFieldTest extends BasicPersonFormTest {
 
@@ -57,4 +60,11 @@ public class BooleanTextFieldTest extends BasicPersonFormTest {
                 "4. Person [firstName=John, lastName=Dover, email=john@doe.com, age=64, sex=Male, address=Address [streetAddress=John street, postalCode=11223, city=John's town, country=USA], deceased=true, salary=null, salaryDouble=null, rent=null]",
                 getLogRow(0));
     }
+
+    @Override
+    public List<DesiredCapabilities> getBrowsersToTest() {
+        // this test also works on IEs, but Firefox has problems with tooltips
+        return getBrowsersExcludingFirefox();
+    }
+
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserTest.java b/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserTest.java
index 9bb146b8e46a585f3cd394b1c17d6fb9eab99b4f..ec40510d96a3e1d64664a593ab316b62b8e907b5 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserTest.java
@@ -57,6 +57,13 @@ public abstract class MultiBrowserTest extends PrivateTB3Configuration {
                 Browser.PHANTOMJS);
     }
 
+    protected List<DesiredCapabilities> getBrowsersExcludingFirefox() {
+        // this is sometimes needed as the Firefox driver causes extra mouseOut
+        // events that make tooltips disappear etc.
+        return getBrowserCapabilities(Browser.IE8, Browser.IE9, Browser.IE10,
+                Browser.IE11, Browser.CHROME, Browser.PHANTOMJS);
+    }
+
     protected List<DesiredCapabilities> getBrowsersExcludingIE8() {
         return getBrowserCapabilities(Browser.IE9, Browser.IE10, Browser.IE11,
                 Browser.FIREFOX, Browser.CHROME, Browser.PHANTOMJS);
@@ -79,6 +86,17 @@ public abstract class MultiBrowserTest extends PrivateTB3Configuration {
                 Browser.FIREFOX, Browser.CHROME);
     }
 
+    protected List<DesiredCapabilities> getBrowsersSupportingTooltip() {
+        // With IEDriver, the cursor seems to jump to default position after the
+        // mouse move, so we are not able to test the tooltip behaviour properly
+        // unless using requireWindowFocusForIE() { return true; } .
+        // See #13854.
+        // On Firefox, the driver causes additional mouseOut events causing the
+        // tooltip to disappear immediately. Tooltips may work in some
+        // particular cases, but not in general.
+        return getBrowserCapabilities(Browser.CHROME, Browser.PHANTOMJS);
+    }
+
     @Override
     public List<DesiredCapabilities> getBrowsersToTest() {
         // Uncomment Safari and Opera if those become tested browsers again.

diff --git a/uitest/src/test/java/com/vaadin/tests/tb3/TooltipTest.java b/uitest/src/test/java/com/vaadin/tests/tb3/TooltipTest.java
index 86ea44287a3306e07676b938f03af8929c3683e8..e455abc9f06fdc6a240d43572961c5ce1a042260 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/tb3/TooltipTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/tb3/TooltipTest.java
@@ -110,8 +110,6 @@ public abstract class TooltipTest extends MultiBrowserTest {
 
     @Override
     public List<DesiredCapabilities> getBrowsersToTest() {
-        // TODO Once we figure out how to get mouse hovering work with the IE
-        // webdriver, exclude them from these tests (#13854)
-        return getBrowsersExcludingIE();
+        return getBrowsersSupportingTooltip();
     }
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/tooltip/AdjacentElementsWithTooltipsTest.java b/uitest/src/test/java/com/vaadin/tests/tooltip/AdjacentElementsWithTooltipsTest.java
index af7a3036294f4fbe9e92ffe48ecef50b4c43d70d..555168f155e7ea22b8f812830d1be963895c564b 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/tooltip/AdjacentElementsWithTooltipsTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/tooltip/AdjacentElementsWithTooltipsTest.java
@@ -23,10 +23,8 @@ import static org.junit.Assert.assertThat;
 import java.util.List;
 
 import org.junit.Test;
-import org.openqa.selenium.interactions.HasInputDevices;
 import org.openqa.selenium.interactions.Mouse;
 import org.openqa.selenium.interactions.internal.Coordinates;
-import org.openqa.selenium.internal.Locatable;
 import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.ButtonElement;
@@ -42,7 +40,7 @@ public class AdjacentElementsWithTooltipsTest extends MultiBrowserTest {
 
     @Override
     public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersExcludingIE();
+        return getBrowsersSupportingTooltip();
     }
 
     @Test

diff --git a/uitest/src/test/java/com/vaadin/tests/tooltip/StationaryTooltipTest.java b/uitest/src/test/java/com/vaadin/tests/tooltip/StationaryTooltipTest.java
index 6b751e7a6b7e9d95af8215bc5b36997cfc2f1a85..b4ce5ff903394891f16ff49ee2785943e75c2089 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/tooltip/StationaryTooltipTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/tooltip/StationaryTooltipTest.java
@@ -19,10 +19,7 @@ public class StationaryTooltipTest extends MultiBrowserTest {
 
     @Override
     public List<DesiredCapabilities> getBrowsersToTest() {
-        // With IEDriver, the cursor seems to jump to default position after the
-        // mouse move,
-        // so we are not able to test the tooltip behaviour properly.
-        return getBrowsersExcludingIE();
+        return getBrowsersSupportingTooltip();
     }
 
     @Test

diff --git a/uitest/src/test/java/com/vaadin/tests/validation/ValidationOfRequiredEmptyFieldsTest.java b/uitest/src/test/java/com/vaadin/tests/validation/ValidationOfRequiredEmptyFieldsTest.java
index ab77ba6b26092f09c4a5920c4d31cc4e72032006..f8c1025975d1f3859fa653dac6ffa7f8e27d6f1d 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/validation/ValidationOfRequiredEmptyFieldsTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/validation/ValidationOfRequiredEmptyFieldsTest.java
@@ -1,10 +1,13 @@
 package com.vaadin.tests.validation;
 
+import java.util.List;
+
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.Keys;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
+import org.openqa.selenium.remote.DesiredCapabilities;
 import org.openqa.selenium.support.ui.ExpectedCondition;
 
 import com.vaadin.testbench.elements.CheckBoxElement;
@@ -19,6 +22,12 @@ public class ValidationOfRequiredEmptyFieldsTest extends MultiBrowserTest {
         return true;
     }
 
+    @Override
+    public List<DesiredCapabilities> getBrowsersToTest() {
+        // Firefox causes extra mouseOut events breaking tooltips.
+        return getBrowsersExcludingFirefox();
+    }
+
     @Test
     public void requiredErrorMessage() throws Exception {
         openTestURL();