Refactor: rename UsersController#add to #new

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4229 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
index 3fb11103d665b00efde2c2270a8bb7ed251b0304..1fd8347b7a875c359f3adad1362d99e2fd2998ef 100644 (file)
--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
@@ -71,7 +71,7 @@ class UsersController < ApplicationController
     render_404
   end
 
-  def add
+  def new
     @notification_options = User::MAIL_NOTIFICATION_OPTIONS
     @notification_option = Setting.default_notification_option
 
@@ -100,14 +100,14 @@ class UsersController < ApplicationController
 
       Mailer.deliver_account_information(@user, params[:password]) if params[:send_information]
       flash[:notice] = l(:notice_successful_create)
-      redirect_to(params[:continue] ? {:controller => 'users', :action => 'add'} : 
+      redirect_to(params[:continue] ? {:controller => 'users', :action => 'new'} : 
                                       {:controller => 'users', :action => 'edit', :id => @user})
       return
     else
       @auth_sources = AuthSource.find(:all)
       @notification_option = @user.mail_notification
 
-      render :action => 'add'
+      render :action => 'new'
     end
   end
 

diff --git a/app/views/users/add.rhtml b/app/views/users/add.rhtml
deleted file mode 100644 (file)
index 0e7a333..0000000
--- a/app/views/users/add.rhtml
+++ /dev/null
@@ -1,10 +0,0 @@
-<h2><%= link_to l(:label_user_plural), :controller => 'users', :action => 'index' %> &#187; <%=l(:label_user_new)%></h2>
-
-<% labelled_tabular_form_for :user, @user, :url => { :action => "create" }, :html => { :class => nil } do |f| %>
-       <%= render :partial => 'form', :locals => { :f => f } %>
-       <p><label><%= check_box_tag 'send_information', 1, true %> <%= l(:label_send_information) %></label></p>
-       <p>
-               <%= submit_tag l(:button_create) %>
-               <%= submit_tag l(:button_create_and_continue), :name => 'continue' %>
-       </p>
-<% end %>

diff --git a/app/views/users/index.rhtml b/app/views/users/index.rhtml
index 1b4702872e012d613432704bae06f5738bca59a2..804678959a05b3a3b50cc7d812375f15997ec369 100644 (file)
--- a/app/views/users/index.rhtml
+++ b/app/views/users/index.rhtml
@@ -1,5 +1,5 @@
 <div class="contextual">
-<%= link_to l(:label_user_new), {:action => 'add'}, :class => 'icon icon-add' %>
+<%= link_to l(:label_user_new), {:action => 'new'}, :class => 'icon icon-add' %>
 </div>
 
 <h2><%=l(:label_user_plural)%></h2>

diff --git a/app/views/users/new.html.erb b/app/views/users/new.html.erb
new file mode 100644 (file)
index 0000000..0e7a333
--- /dev/null
+++ b/app/views/users/new.html.erb
@@ -0,0 +1,10 @@
+<h2><%= link_to l(:label_user_plural), :controller => 'users', :action => 'index' %> &#187; <%=l(:label_user_new)%></h2>
+
+<% labelled_tabular_form_for :user, @user, :url => { :action => "create" }, :html => { :class => nil } do |f| %>
+       <%= render :partial => 'form', :locals => { :f => f } %>
+       <p><label><%= check_box_tag 'send_information', 1, true %> <%= l(:label_send_information) %></label></p>
+       <p>
+               <%= submit_tag l(:button_create) %>
+               <%= submit_tag l(:button_create_and_continue), :name => 'continue' %>
+       </p>
+<% end %>

diff --git a/config/routes.rb b/config/routes.rb
index 0e60c555fc95df6953af24f44ce276ef077e502c..d9c22d6cc71003e23ba777cb3d6967aa5d64ca6e 100644 (file)
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -143,11 +143,10 @@ ActionController::Routing::Routes.draw do |map|
     users.with_options :conditions => {:method => :get} do |user_views|
       user_views.connect 'users', :action => 'index'
       user_views.connect 'users/:id', :action => 'show', :id => /\d+/
-      user_views.connect 'users/new', :action => 'add'
+      user_views.connect 'users/new', :action => 'new'
       user_views.connect 'users/:id/edit/:tab', :action => 'edit', :tab => nil
     end
     users.with_options :conditions => {:method => :post} do |user_actions|
-      user_actions.connect 'users', :action => 'add'
       user_actions.connect 'users/new', :action => 'create'
       user_actions.connect 'users/:id/edit', :action => 'edit'
       user_actions.connect 'users/:id/memberships', :action => 'edit_membership'

diff --git a/test/functional/users_controller_test.rb b/test/functional/users_controller_test.rb
index 6131c7e7dd00ba93f0caf93589c765b5cb79c46c..577f54b0771d858cfaf4d7844e1b3966715d731f 100644 (file)
--- a/test/functional/users_controller_test.rb
+++ b/test/functional/users_controller_test.rb
@@ -107,14 +107,14 @@ class UsersControllerTest < ActionController::TestCase
     assert project_ids.include?(2) #private project admin can see
   end
 
-  context "GET :add" do
+  context "GET :new" do
     setup do
-      get :add
+      get :new
     end
 
     should_assign_to :user
     should_respond_with :success
-    should_render_template :add
+    should_render_template :new
   end
 
   context "POST :create" do
@@ -148,7 +148,7 @@ class UsersControllerTest < ActionController::TestCase
 
       should_assign_to :user
       should_respond_with :success
-      should_render_template :add
+      should_render_template :new
     end
 
   end

diff --git a/test/integration/admin_test.rb b/test/integration/admin_test.rb
index 62ddc533f56b35c3eba0d398b17c77146b2f979d..dd52859cfbf4033dca059056c889de053918d63b 100644 (file)
--- a/test/integration/admin_test.rb
+++ b/test/integration/admin_test.rb
@@ -22,9 +22,9 @@ class AdminTest < ActionController::IntegrationTest
 
   def test_add_user
     log_user("admin", "admin")
-    get "/users/add"
+    get "/users/new"
     assert_response :success
-    assert_template "users/add"
+    assert_template "users/new"
     post "/users/create", :user => { :login => "psmith", :firstname => "Paul", :lastname => "Smith", :mail => "psmith@somenet.foo", :language => "en" }, :password => "psmith09", :password_confirmation => "psmith09"
     
     user = User.find_by_login("psmith")

diff --git a/test/integration/routing_test.rb b/test/integration/routing_test.rb
index 74b7d990dd33e92381d45741fa48ad3f07b3deb1..341efe3cd1f7c15fbe5f431d1af591c4ec3281fd 100644 (file)
--- a/test/integration/routing_test.rb
+++ b/test/integration/routing_test.rb
@@ -246,7 +246,7 @@ class RoutingTest < ActionController::IntegrationTest
   context "users" do
     should_route :get, "/users", :controller => 'users', :action => 'index'
     should_route :get, "/users/44", :controller => 'users', :action => 'show', :id => '44'
-    should_route :get, "/users/new", :controller => 'users', :action => 'add'
+    should_route :get, "/users/new", :controller => 'users', :action => 'new'
     should_route :get, "/users/444/edit", :controller => 'users', :action => 'edit', :id => '444'
     should_route :get, "/users/222/edit/membership", :controller => 'users', :action => 'edit', :id => '222', :tab => 'membership'