]> source.dussan.org Git - poi.git/commitdiff
bug 60128: exclude openxml4j/invalid.xlsx from additional integration (stress) tests
authorJaven O'Neal <onealj@apache.org>
Wed, 14 Sep 2016 18:41:21 +0000 (18:41 +0000)
committerJaven O'Neal <onealj@apache.org>
Wed, 14 Sep 2016 18:41:21 +0000 (18:41 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760743 13f79535-47bb-0310-9956-ffa450edef68

src/integrationtest/org/apache/poi/TestAllFiles.java
src/integrationtest/org/apache/poi/stress/XSSFFileHandler.java

index be3fb66363b721b17fc602e09453ca74d0341b12..e364c9f28ade7677424efa05a154d2074d89e514 100644 (file)
@@ -298,7 +298,10 @@ public class TestAllFiles {
         List<Object[]> files = new ArrayList<Object[]>();
         for(String file : scanner.getIncludedFiles()) {
             file = file.replace('\\', '/'); // ... failures/handlers lookup doesn't work on windows otherwise
-            if (IGNORED.contains(file)) continue;
+            if (IGNORED.contains(file)) {
+                System.out.println("Ignoring " + file);
+                continue;
+            }
             FileHandler handler = HANDLERS.get(getExtension(file));
             files.add(new Object[] { file, handler });
             
index be60397071b4cb51427e7616122039e84d8c79d9..0e24f048623706f0239f62f45dc53f24fa83667e 100644 (file)
@@ -30,6 +30,7 @@ import javax.xml.transform.TransformerException;
 
 import org.apache.poi.POIXMLException;
 import org.apache.poi.openxml4j.exceptions.InvalidFormatException;
+import org.apache.poi.openxml4j.exceptions.NotOfficeXmlFileException;
 import org.apache.poi.openxml4j.exceptions.OLE2NotOfficeXmlFileException;
 import org.apache.poi.openxml4j.exceptions.OpenXML4JException;
 import org.apache.poi.openxml4j.opc.OPCPackage;
@@ -134,6 +135,9 @@ public class XSSFFileHandler extends SpreadsheetHandler {
         EXPECTED_ADDITIONAL_FAILURES.add("spreadsheet/Simple.xlsb");
         // TODO: good to ignore?
         EXPECTED_ADDITIONAL_FAILURES.add("spreadsheet/sample-beta.xlsx");
+        
+        // corrupt/invalid
+        EXPECTED_ADDITIONAL_FAILURES.add("openxml4j/invalid.xlsx");
     }
 
     @SuppressWarnings("resource")