public class IssueFilterWs implements WebService {
+ private static final String PARAM_ID = "id";
private final IssueFilterService service;
public IssueFilterWs(IssueFilterService service) {
app(request, response);
}
});
+ app.createParam(PARAM_ID).setDescription("Optionally, the ID of the current filter");
NewAction show = controller.createAction("show");
show
show(request, response);
}
})
- .createParam("id");
+ .createParam(PARAM_ID).setRequired(true);
NewAction fav = controller.createAction("favorites");
fav
public void handle(Request request, Response response) {
favorites(request, response);
}
- })
- .createParam("id");
+ });
controller.done();
}
json.beginObject();
// Current filter (optional)
- int filterId = request.paramAsInt("id", -1);
+ int filterId = request.paramAsInt(PARAM_ID, -1);
DefaultIssueFilter filter = null;
if (filterId >= 0) {
filter = service.find((long) filterId, session);
for (DefaultIssueFilter favorite : favorites) {
json
.beginObject()
- .prop("id", favorite.id())
+ .prop(PARAM_ID, favorite.id())
.prop("name", favorite.name())
.endObject();
}
private void show(Request request, Response response) {
UserSession session = UserSession.get();
- DefaultIssueFilter filter = service.find(Long.parseLong(request.mandatoryParam("id")), session);
+ DefaultIssueFilter filter = service.find(Long.parseLong(request.mandatoryParam(PARAM_ID)), session);
JsonWriter json = response.newJsonWriter();
json.beginObject();
if (session.isLoggedIn()) {
for (DefaultIssueFilter favorite : service.findFavoriteFilters(session)) {
json.beginObject();
- json.prop("id", favorite.id());
+ json.prop(PARAM_ID, favorite.id());
json.prop("name", favorite.name());
json.prop("user", favorite.user());
json.prop("shared", favorite.shared());
private JsonWriter writeFilterJson(UserSession session, DefaultIssueFilter filter, JsonWriter json) {
return json.beginObject()
- .prop("id", filter.id())
+ .prop(PARAM_ID, filter.id())
.prop("name", filter.name())
.prop("description", filter.description())
.prop("user", filter.user())