SONAR-20547 Add conditional check CC category for security hotspot

diff --git a/server/sonar-web/src/main/js/apps/quality-profiles/compare/ComparisonResults.tsx b/server/sonar-web/src/main/js/apps/quality-profiles/compare/ComparisonResults.tsx
index 800733aa422a018e1a7cfaef66d25d94f6881315..80abc67bffdd1172acef44281199e6d34a9c3d3e 100644 (file)
--- a/server/sonar-web/src/main/js/apps/quality-profiles/compare/ComparisonResults.tsx
+++ b/server/sonar-web/src/main/js/apps/quality-profiles/compare/ComparisonResults.tsx
@@ -233,16 +233,22 @@ function RuleCell({ rule, severity }: Readonly<{ rule: RuleCompare; severity?: s
       <Link className="sw-ml-1" to={getRulesUrl({ rule_key: rule.key, open: rule.key })}>
         {rule.name}
       </Link>
-      <ul className="sw-mt-3 sw-flex sw-items-center">
-        <li>
-          <CleanCodeAttributePill cleanCodeAttributeCategory={rule.cleanCodeAttributeCategory} />
-        </li>
-        {rule.impacts.map(({ severity, softwareQuality }) => (
-          <li key={softwareQuality} className="sw-ml-2">
-            <SoftwareImpactPill type="rule" quality={softwareQuality} severity={severity} />
-          </li>
-        ))}
-      </ul>
+      {(rule.cleanCodeAttributeCategory || rule.impacts.length > 0) && (
+        <ul className="sw-mt-3 sw-flex sw-items-center">
+          {rule.cleanCodeAttributeCategory && (
+            <li>
+              <CleanCodeAttributePill
+                cleanCodeAttributeCategory={rule.cleanCodeAttributeCategory}
+              />
+            </li>
+          )}
+          {rule.impacts.map(({ severity, softwareQuality }) => (
+            <li key={softwareQuality} className="sw-ml-2">
+              <SoftwareImpactPill type="rule" quality={softwareQuality} severity={severity} />
+            </li>
+          ))}
+        </ul>
+      )}
     </div>
   );
 }

diff --git a/server/sonar-web/src/main/js/helpers/testMocks.ts b/server/sonar-web/src/main/js/helpers/testMocks.ts
index 1b593839bddf4767ea35b9dc86f908bbd3ac64b0..53fc466a14a8af0293d28011969df74f73957bb9 100644 (file)
--- a/server/sonar-web/src/main/js/helpers/testMocks.ts
+++ b/server/sonar-web/src/main/js/helpers/testMocks.ts
@@ -505,13 +505,7 @@ export function mockCompareResult(overrides: Partial<CompareResponse> = {}): Com
     ],
     modified: [
       {
-        cleanCodeAttributeCategory: CleanCodeAttributeCategory.Consistent,
-        impacts: [
-          {
-            softwareQuality: SoftwareQuality.Maintainability,
-            severity: SoftwareImpactSeverity.Low,
-          },
-        ],
+        impacts: [],
         key: 'java:S1698',
         name: '== and != should not be used when equals is overridden',
         left: { params: {}, severity: 'MINOR' },