Update to latest Sonar Common Rules 1.0.1

diff --git a/plugins/sonar-java-plugin/pom.xml b/plugins/sonar-java-plugin/pom.xml
index a4c61b9c94fae2775155f5272dc016f79bce1726..a72252f6f6ebd51925aaef08a2cbee985464588a 100644 (file)
--- a/plugins/sonar-java-plugin/pom.xml
+++ b/plugins/sonar-java-plugin/pom.xml
@@ -22,7 +22,7 @@
     <dependency>
       <groupId>org.codehaus.sonar.common-rules</groupId>
       <artifactId>sonar-common-rules</artifactId>
-      <version>1.0</version>
+      <version>1.0.1</version>
     </dependency>
 
     <!-- unit tests -->

diff --git a/plugins/sonar-java-plugin/src/main/java/org/sonar/plugins/java/JavaCommonRulesEngineProvider.java b/plugins/sonar-java-plugin/src/main/java/org/sonar/plugins/java/JavaCommonRulesEngineProvider.java
index e72d78ec3ae63e2db1b0174f42acd02103d716a4..0fdd3cd15ba4300763b58ca2e7006b79496af7c3 100644 (file)
--- a/plugins/sonar-java-plugin/src/main/java/org/sonar/plugins/java/JavaCommonRulesEngineProvider.java
+++ b/plugins/sonar-java-plugin/src/main/java/org/sonar/plugins/java/JavaCommonRulesEngineProvider.java
@@ -19,25 +19,32 @@
  */
 package org.sonar.plugins.java;
 
-import org.sonar.api.BatchExtension;
-import org.sonar.api.ExtensionProvider;
-import org.sonar.api.ServerExtension;
 import org.sonar.api.resources.Java;
+import org.sonar.api.resources.Project;
 import org.sonar.commonrules.api.CommonRulesEngine;
+import org.sonar.commonrules.api.CommonRulesEngineProvider;
 
-import java.util.List;
+public class JavaCommonRulesEngineProvider extends CommonRulesEngineProvider {
 
-public class JavaCommonRulesEngineProvider extends ExtensionProvider implements ServerExtension, BatchExtension {
+  public JavaCommonRulesEngineProvider() {
+    super();
+  }
+
+  public JavaCommonRulesEngineProvider(Project project) {
+    super(project);
+  }
 
   @Override
-  public List provide() {
-    CommonRulesEngine engine = new CommonRulesEngine(Java.KEY);
+  protected void doActivation(CommonRulesEngine engine) {
     engine.activateRule("InsufficientBranchCoverage");
     engine.activateRule("InsufficientCommentDensity");
     engine.activateRule("DuplicatedBlocks");
     engine.activateRule("InsufficientLineCoverage");
+  }
 
-    return engine.getExtensions();
+  @Override
+  protected String getLanguageKey() {
+    return Java.KEY;
   }
 
 }

diff --git a/plugins/sonar-java-plugin/src/test/java/org/sonar/plugins/java/JavaCommonRulesEngineProviderTest.java b/plugins/sonar-java-plugin/src/test/java/org/sonar/plugins/java/JavaCommonRulesEngineProviderTest.java
index a82d1debfd022e8cfd936f46f669adc0a9db5187..b43e8eabb22c8fd04eb0be8db768c452437feb84 100644 (file)
--- a/plugins/sonar-java-plugin/src/test/java/org/sonar/plugins/java/JavaCommonRulesEngineProviderTest.java
+++ b/plugins/sonar-java-plugin/src/test/java/org/sonar/plugins/java/JavaCommonRulesEngineProviderTest.java
@@ -29,6 +29,9 @@ public class JavaCommonRulesEngineProviderTest {
   public void shouldProvideExpectedExtensions() {
     JavaCommonRulesEngineProvider provider = new JavaCommonRulesEngineProvider();
     assertThat(provider.provide().size()).isGreaterThan(1);
+
+    provider = new JavaCommonRulesEngineProvider(null);
+    assertThat(provider.provide().size()).isGreaterThan(1);
   }
 
 }