fix quality flaws

diff --git a/server/sonar-web/src/main/js/apps/account/store/reducers.js b/server/sonar-web/src/main/js/apps/account/store/reducers.js
index 813dcf15b97984f93a9a675883c331d300955b02..e129a65f17ff63b9531d9c49507000630aba604b 100644 (file)
--- a/server/sonar-web/src/main/js/apps/account/store/reducers.js
+++ b/server/sonar-web/src/main/js/apps/account/store/reducers.js
@@ -20,9 +20,7 @@
 import { RECEIVE_USER, ADD_PROJECT_NOTIFICATIONS, REMOVE_PROJECT_NOTIFICATIONS } from './actions';
 
 function addProjectNotifications (state, project) {
-  const found = state.find(notification => {
-    return notification.project.internalId === project.internalId;
-  });
+  const found = state.find(notification => notification.project.internalId === project.internalId);
 
   if (found) {
     return state;
@@ -42,9 +40,7 @@ function addProjectNotifications (state, project) {
 }
 
 function removeProjectNotifications (state, project) {
-  return state.filter(notification => {
-    return notification.project.internalId !== project.internalId;
-  });
+  return state.filter(notification => notification.project.internalId !== project.internalId);
 }
 
 export const initialState = {
@@ -52,7 +48,7 @@ export const initialState = {
   projectNotifications: window.sonarqube.notifications.project
 };
 
-export default function (state = initialState, action) {
+export default function (state = initialState, action = {}) {
   switch (action.type) {
     case RECEIVE_USER:
       return {

diff --git a/server/sonar-web/src/main/js/apps/background-tasks/store/reducers.js b/server/sonar-web/src/main/js/apps/background-tasks/store/reducers.js
index 44cb08af7fd77f06a6ff0a68fc10ec4dc2604020..82ada158894f6398e0302b51304dfc5b51f68ad8 100644 (file)
--- a/server/sonar-web/src/main/js/apps/background-tasks/store/reducers.js
+++ b/server/sonar-web/src/main/js/apps/background-tasks/store/reducers.js
@@ -47,7 +47,7 @@ function updateTask (tasks, newTask) {
   return tasks.map(task => task.id === newTask.id ? newTask : task);
 }
 
-export default function (state = initialState, action) {
+export default function (state = initialState, action = {}) {
   switch (action.type) {
     case INIT:
       return {

diff --git a/server/sonar-web/src/main/js/apps/code/reducers/index.js b/server/sonar-web/src/main/js/apps/code/reducers/index.js
index f061926e0e43196fc0f145a06915a379dd34d43a..a554d94d26d27b324601ef8ff6efd86f9810ea54 100644 (file)
--- a/server/sonar-web/src/main/js/apps/code/reducers/index.js
+++ b/server/sonar-web/src/main/js/apps/code/reducers/index.js
@@ -112,7 +112,7 @@ export const initialState = {
   errorMessage: null
 };
 
-export function current (state = initialState, action) {
+export function current (state = initialState, action = {}) {
   /* eslint no-case-declarations: 0 */
   /* FIXME fix it ^^^ */
   switch (action.type) {
@@ -183,7 +183,7 @@ export function current (state = initialState, action) {
   }
 }
 
-export function bucket (state = [], action) {
+export function bucket (state = [], action = {}) {
   switch (action.type) {
     case INIT:
       return merge(state, action.component);

diff --git a/server/sonar-web/src/main/js/apps/custom-measures/form-view.js b/server/sonar-web/src/main/js/apps/custom-measures/form-view.js
index 857c4594ece878148813bfafbbbb6d1613183772..c25c9470ef1a1aa23233244ff1482eba9229635a 100644 (file)
--- a/server/sonar-web/src/main/js/apps/custom-measures/form-view.js
+++ b/server/sonar-web/src/main/js/apps/custom-measures/form-view.js
@@ -62,7 +62,7 @@ export default ModalForm.extend({
     const isNew = !this.model;
     return _.extend(ModalForm.prototype.serializeData.apply(this, arguments), {
       metrics,
-      canCreateMetric: !isNew || (isNew && metrics.length > 0)
+      canCreateMetric: !isNew || metrics.length > 0
     });
   }
 });

diff --git a/server/sonar-web/src/main/js/apps/quality-gates/store/reducers.js b/server/sonar-web/src/main/js/apps/quality-gates/store/reducers.js
index aadba7a24154ad8339a6412f2560241824755163..0b8e06d0656505b9d6c73dc8939b078f9e7d8705 100644 (file)
--- a/server/sonar-web/src/main/js/apps/quality-gates/store/reducers.js
+++ b/server/sonar-web/src/main/js/apps/quality-gates/store/reducers.js
@@ -34,7 +34,7 @@ import { checkIfDefault, addCondition, deleteCondition, replaceCondition } from
 
 const initialState = {};
 
-export default function rootReducer (state = initialState, action) {
+export default function rootReducer (state = initialState, action = {}) {
   switch (action.type) {
     case SET_STATE:
       return { ...state, ...action.nextState };

diff --git a/server/sonar-web/src/main/js/components/source-viewer/main.js b/server/sonar-web/src/main/js/components/source-viewer/main.js
index 26add5f014b224c60694d2795ac7c9c0791c1b97..f1d4e9619e0d0a6c9151f3e6b66cf7b3eb46de65 100644 (file)
--- a/server/sonar-web/src/main/js/components/source-viewer/main.js
+++ b/server/sonar-web/src/main/js/components/source-viewer/main.js
@@ -472,7 +472,7 @@ export default Marionette.LayoutView.extend({
       const outOfBounds = b.from > line || b.from + b.size < line;
       const currentFile = b._ref === '1';
       const shouldDisplayForCurrentFile = outOfBounds || foundOne;
-      const shouldDisplay = !currentFile || (currentFile && shouldDisplayForCurrentFile);
+      const shouldDisplay = !currentFile || shouldDisplayForCurrentFile;
       const isOk = (b._ref != null) && shouldDisplay;
       if (b._ref === '1' && !outOfBounds) {
         foundOne = true;