circleId too short in some request

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

diff --git a/apps/files_sharing/lib/Controller/ShareAPIController.php b/apps/files_sharing/lib/Controller/ShareAPIController.php
index 2c2ec393d3f2b53b4d57408decb5bec20e1bb3f2..aaca16b32e6cedcd40ed4e3df04615e308f54a2c 100644 (file)
--- a/apps/files_sharing/lib/Controller/ShareAPIController.php
+++ b/apps/files_sharing/lib/Controller/ShareAPIController.php
@@ -1648,10 +1648,11 @@ class ShareAPIController extends OCSController {
                        $hasCircleId = (substr($share->getSharedWith(), -1) === ']');
                        $shareWithStart = ($hasCircleId ? strrpos($share->getSharedWith(), '[') + 1 : 0);
                        $shareWithLength = ($hasCircleId ? -1 : strpos($share->getSharedWith(), ' '));
-                       if (is_bool($shareWithLength)) {
-                               $shareWithLength = -1;
+                       if ($shareWithLength === false) {
+                               $sharedWith = substr($share->getSharedWith(), $shareWithStart);
+                       } else {
+                               $sharedWith = substr($share->getSharedWith(), $shareWithStart, $shareWithLength);
                        }
-                       $sharedWith = substr($share->getSharedWith(), $shareWithStart, $shareWithLength);
                        try {
                                $member = \OCA\Circles\Api\v1\Circles::getMember($sharedWith, $userId, 1);
                                if ($member->getLevel() >= 4) {