list.php files are only invoked via ViewController and APIController

Both of them actually check that the user is logged in before
and also the list.php files themselves would break with
getUserSession()->getUser()->getUID() which they contain.

Signed-off-by: Joas Schilling <coding@schilljs.com>

diff --git a/apps/files/list.php b/apps/files/list.php
index 259713ae68ec9156065bebc6f5ea3d4c040c121d..54bdd814ada241ed71eeb69b0c9713d0972a13c2 100644 (file)
--- a/apps/files/list.php
+++ b/apps/files/list.php
@@ -29,7 +29,7 @@ $userSession = \OC::$server->getUserSession();
 // TODO: move this to the generated config.js
 /** @var IManager $shareManager */
 $shareManager = \OC::$server->get(IManager::class);
-$publicUploadEnabled = $shareManager->shareApiLinkAllowPublicUpload() ? 'yes' : 'no';;
+$publicUploadEnabled = $shareManager->shareApiLinkAllowPublicUpload() ? 'yes' : 'no';
 
 $showgridview = $config->getUserValue($userSession->getUser()->getUID(), 'files', 'show_grid', false);
 $isIE = OC_Util::isIe();

diff --git a/apps/files/recentlist.php b/apps/files/recentlist.php
index 899591013e2e5bf4237e8e3624d2ffde50bc640c..daa69a374ef2d1a542119f3b37db1c359f0f8d40 100644 (file)
--- a/apps/files/recentlist.php
+++ b/apps/files/recentlist.php
@@ -23,8 +23,7 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  *
  */
-// Check if we are a user
-OC_Util::checkLoggedIn();
+
 $config = \OC::$server->getConfig();
 $userSession = \OC::$server->getUserSession();
 

diff --git a/apps/files_external/list.php b/apps/files_external/list.php
index 0107bf92e6fbff09b784bb0f787cc1fd81256866..00f69bf881fd919383b63f73ed63c5f20c002b7e 100644 (file)
--- a/apps/files_external/list.php
+++ b/apps/files_external/list.php
@@ -23,8 +23,7 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>
  *
  */
-// Check if we are a user
-OC_Util::checkLoggedIn();
+
 $config = \OC::$server->getConfig();
 $userSession = \OC::$server->getUserSession();
 

diff --git a/apps/files_sharing/list.php b/apps/files_sharing/list.php
index 759f87179a1e556d4df7479c0b4d96ae037b2d13..875d4251c98bd0447048ad1d5b0593a770e5d7e1 100644 (file)
--- a/apps/files_sharing/list.php
+++ b/apps/files_sharing/list.php
@@ -28,8 +28,6 @@ use OCA\Files\Event\LoadSidebar;
 use OCA\Viewer\Event\LoadViewer;
 use OCP\EventDispatcher\GenericEvent;
 
-// Check if we are a user
-OC_Util::checkLoggedIn();
 $config = \OC::$server->getConfig();
 $userSession = \OC::$server->getUserSession();
 $legacyEventDispatcher = \OC::$server->getEventDispatcher();

diff --git a/apps/files_trashbin/list.php b/apps/files_trashbin/list.php
index 9ee833319fce439855e48aa37512d6576dfb3ba9..ec348a227f5ad142cb07441203aea75988fc927f 100644 (file)
--- a/apps/files_trashbin/list.php
+++ b/apps/files_trashbin/list.php
@@ -24,8 +24,6 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>
  *
  */
-// Check if we are a user
-OC_Util::checkLoggedIn();
 
 $config = \OC::$server->getConfig();
 $userSession = \OC::$server->getUserSession();

diff --git a/apps/systemtags/list.php b/apps/systemtags/list.php
index d7ba2c9eed9ace6c6aff476106c1f1483cdb6fc0..b5bbf223f29ac6c31c5d41ff236161f17e81ec27 100644 (file)
--- a/apps/systemtags/list.php
+++ b/apps/systemtags/list.php
@@ -20,23 +20,6 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>
  *
  */
-// WARNING: this should be moved to proper AppFramework handling
-// Check if we are a user
-if (!\OC::$server->getUserSession()->isLoggedIn()) {
-       header('Location: ' . \OC::$server->getURLGenerator()->linkToRoute(
-                       'core.login.showLoginForm',
-                       [
-                               'redirect_url' => \OC::$server->getRequest()->getRequestUri(),
-                       ]
-               )
-       );
-       exit();
-}
-// Redirect to 2FA challenge selection if 2FA challenge was not solved yet
-if (\OC::$server->getTwoFactorAuthManager()->needsSecondFactor(\OC::$server->getUserSession()->getUser())) {
-       header('Location: ' . \OC::$server->getURLGenerator()->linkToRoute('core.TwoFactorChallenge.selectChallenge'));
-       exit();
-}
 
 $tmpl = new OCP\Template('systemtags', 'list', '');
 $tmpl->printPage();