Use ghost user if user was not found (#29161) (#29169)

Backport #29161

diff --git a/models/issues/comment_list.go b/models/issues/comment_list.go
index cb7df3270d6ada1af1bd84a23c17ff22787a5eca..30a437ea50dcf3a2061b831d4fddbb731b9cc2ca 100644 (file)
--- a/models/issues/comment_list.go
+++ b/models/issues/comment_list.go
@@ -225,6 +225,10 @@ func (comments CommentList) loadAssignees(ctx context.Context) error {
 
        for _, comment := range comments {
                comment.Assignee = assignees[comment.AssigneeID]
+               if comment.Assignee == nil {
+                       comment.AssigneeID = user_model.GhostUserID
+                       comment.Assignee = user_model.NewGhostUser()
+               }
        }
        return nil
 }

diff --git a/models/issues/review.go b/models/issues/review.go
index 5bfb8b9dd224204012977dc64b5514cbb06e6ed4..3fca30d7b68cd5611f7f91ee4483c953e680c778 100644 (file)
--- a/models/issues/review.go
+++ b/models/issues/review.go
@@ -159,6 +159,14 @@ func (r *Review) LoadReviewer(ctx context.Context) (err error) {
                return err
        }
        r.Reviewer, err = user_model.GetPossibleUserByID(ctx, r.ReviewerID)
+       if err != nil {
+               if !user_model.IsErrUserNotExist(err) {
+                       return fmt.Errorf("GetPossibleUserByID [%d]: %w", r.ReviewerID, err)
+               }
+               r.ReviewerID = user_model.GhostUserID
+               r.Reviewer = user_model.NewGhostUser()
+               return nil
+       }
        return err
 }