Revert "Removed legacy toString implementations as promised in 7.0

(#10916)" (accidentally merged from 7.1)

This reverts commit 5be248803b9b670cd4cf24d5173e7f580180545e.

Change-Id: If4371976f8afe68d08e814128e3256d66b8ecdb3

diff --git a/server/src/com/vaadin/ui/AbstractField.java b/server/src/com/vaadin/ui/AbstractField.java
index 619d717d97a0bd21d5df06eaee862f343216f410..422e0a1796faed6cab358a0b42afbf5d40f045cf 100644 (file)
--- a/server/src/com/vaadin/ui/AbstractField.java
+++ b/server/src/com/vaadin/ui/AbstractField.java
@@ -372,6 +372,30 @@ public abstract class AbstractField<T> extends AbstractComponent implements
 
     /* Property interface implementation */
 
+    /**
+     * Returns the (field) value converted to a String using toString().
+     * 
+     * @see java.lang.Object#toString()
+     * @deprecated As of 7.0, use {@link #getValue()} to get the value of the
+     *             field, {@link #getConvertedValue()} to get the field value
+     *             converted to the data model type or
+     *             {@link #getPropertyDataSource()} .getValue() to get the value
+     *             of the data source.
+     */
+    @Deprecated
+    @Override
+    public String toString() {
+        logger.warning("You are using AbstractField.toString() to get the value for a "
+                + getClass().getSimpleName()
+                + ". This will not be supported starting from Vaadin 7.1 "
+                + "(your debugger might call toString() and cause this message to appear).");
+        final Object value = getFieldValue();
+        if (value == null) {
+            return null;
+        }
+        return value.toString();
+    }
+
     /**
      * Gets the current value of the field.
      * 

diff --git a/server/src/com/vaadin/ui/Label.java b/server/src/com/vaadin/ui/Label.java
index f413ea47f284e86c21eb6a3c594ec535052cef98..f49a1403cf923d3d24fb71b55f91825113bcb9a6 100644 (file)
--- a/server/src/com/vaadin/ui/Label.java
+++ b/server/src/com/vaadin/ui/Label.java
@@ -202,6 +202,23 @@ public class Label extends AbstractComponent implements Property<String>,
         }
     }
 
+    /**
+     * Returns the value displayed by this label.
+     * 
+     * @see java.lang.Object#toString()
+     * @deprecated As of 7.0, use {@link #getValue()} to get the value of the
+     *             label or {@link #getPropertyDataSource()} .getValue() to get
+     *             the value of the data source.
+     */
+    @Deprecated
+    @Override
+    public String toString() {
+        logger.warning("You are using Label.toString() to get the value for a "
+                + getClass().getSimpleName()
+                + ".  This will not be supported starting from Vaadin 7.1 (your debugger might call toString() and cause this message to appear).");
+        return getValue();
+    }
+
     /**
      * Gets the type of the Property.
      *