]> source.dussan.org Git - vaadin-framework.git/commitdiff
Removed obsolete fix for webkit scrollbar issue. (#14203)
authorSergey Budkin <sergey@vaadin.com>
Tue, 16 Sep 2014 11:43:03 +0000 (14:43 +0300)
committerSergey Budkin <sergey@vaadin.com>
Wed, 1 Oct 2014 12:15:07 +0000 (15:15 +0300)
The fix was causing a flicker effect. Initial fix for #2138 was causing
a flicker effect, but the original issue is not reproducing currently
even when the previous fix is reverted.

Tested against tickets #3457, #3875, #7607, #6698 as well as filtering
out and removing rows.

Change-Id: I1aa6943eb93898d75c4e3c5b6d9326b95648bb1f

client/src/com/vaadin/client/ui/VScrollTable.java
client/src/com/vaadin/client/ui/table/TableConnector.java

index 0def8ac69c6de0ad8a4d17905b48740738d0cdd8..42fef9f0c047ace52ed1e91b6bda05e844dd6d05 100644 (file)
@@ -6989,8 +6989,6 @@ public class VScrollTable extends FlowPanel implements HasWidgets,
                 }
             }
 
-            Util.runWebkitOverflowAutoFixDeferred(scrollBodyPanel.getElement());
-
             forceRealignColumnHeaders();
         }
 
@@ -7119,15 +7117,6 @@ public class VScrollTable extends FlowPanel implements HasWidgets,
         if (initializedAndAttached) {
             updatePageLength();
         }
-        if (!rendering) {
-            // Webkit may sometimes get an odd rendering bug (white space
-            // between header and body), see bug #3875. Running
-            // overflow hack here to shake body element a bit.
-            // We must run the fix as a deferred command to prevent it from
-            // overwriting the scroll position with an outdated value, see
-            // #7607.
-            Util.runWebkitOverflowAutoFixDeferred(scrollBodyPanel.getElement());
-        }
 
         triggerLazyColumnAdjustment(false);
 
index 56b35cce56c21bddef4514b88c80d3328db2a478..7fb4bc108ab48ec830d3b054747df70be3fb0b61 100644 (file)
@@ -198,19 +198,6 @@ public class TableConnector extends AbstractHasComponentsConnector implements
                             uidl.getIntAttribute("rows"));
                     if (getWidget().headerChangedDuringUpdate) {
                         getWidget().triggerLazyColumnAdjustment(true);
-                    } else if (!getWidget().isScrollPositionVisible()
-                            || totalRowsHaveChanged
-                            || getWidget().lastRenderedHeight != getWidget().scrollBody
-                                    .getOffsetHeight()) {
-                        // webkits may still bug with their disturbing scrollbar
-                        // bug, see #3457
-                        // Run overflow fix for the scrollable area
-                        // #6698 - If there's a scroll going on, don't abort it
-                        // by changing overflows as the length of the contents
-                        // *shouldn't* have changed (unless the number of rows
-                        // or the height of the widget has also changed)
-                        Util.runWebkitOverflowAutoFixDeferred(getWidget().scrollBodyPanel
-                                .getElement());
                     }
                 } else {
                     getWidget().initializeRows(uidl, rowData);