Fix Jira FOP-2173: Invalid Postscript created with SVG and custom fonts

Patch submitted by Simon Steiner (ssteiner.at.thunderhead.com)

git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1422992 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/java/org/apache/fop/render/ps/PSTextPainter.java b/src/java/org/apache/fop/render/ps/PSTextPainter.java
index 1f89dc8f0af68d323d0ceea6fc4b16a9c1b36023..eb218802632af6d216f16d1c63a065eaffdd7bcc 100644 (file)
--- a/src/java/org/apache/fop/render/ps/PSTextPainter.java
+++ b/src/java/org/apache/fop/render/ps/PSTextPainter.java
@@ -269,6 +269,13 @@ public class PSTextPainter extends NativeTextPainter {
             this.gen = gen;
         }
 
+        public boolean isMultiByte(Font f) {
+            FontMetrics metrics = f.getFontMetrics();
+            boolean multiByte = metrics instanceof MultiByteFont || metrics instanceof LazyFont
+                    && ((LazyFont) metrics).getRealFont() instanceof MultiByteFont;
+            return multiByte;
+        }
+
         public Font selectFontForChar(char ch) {
             for (int i = 0, c = fonts.length; i < c; i++) {
                 if (fonts[i].hasChar(ch)) {
@@ -290,18 +297,21 @@ public class PSTextPainter extends NativeTextPainter {
         }
 
         public boolean isFontChanging(Font f, char mapped) {
-            if (f != getCurrentFont()) {
-                return true;
-            }
-            if (mapped / 256 != getCurrentFontEncoding()) {
-                return true;
+            // this is only applicable for single byte fonts
+            if (!isMultiByte(f)) {
+                if (f != getCurrentFont()) {
+                    return true;
+                }
+                if (mapped / 256 != getCurrentFontEncoding()) {
+                    return true;
+                }
             }
             return false; //Font is the same
         }
 
         public void selectFont(Font f, char mapped) throws IOException {
             int encoding = mapped / 256;
-            String postfix = (encoding == 0 ? null : Integer.toString(encoding));
+            String postfix = (!isMultiByte(f) && encoding > 0 ? Integer.toString(encoding) : null);
             PSFontResource res = getResourceForFont(f, postfix);
             gen.useFont("/" + res.getName(), f.getFontSize() / 1000f);
             res.notifyResourceUsageOnPage(gen.getResourceTracker());
@@ -430,10 +440,7 @@ public class PSTextPainter extends NativeTextPainter {
             textUtil.setCurrentFont(f, mapped);
             applyColor(paint, gen);
 
-            FontMetrics metrics = f.getFontMetrics();
-            boolean multiByte = metrics instanceof MultiByteFont
-                    || metrics instanceof LazyFont
-                            && ((LazyFont) metrics).getRealFont() instanceof MultiByteFont;
+            boolean multiByte = textUtil.isMultiByte(f);
             StringBuffer sb = new StringBuffer();
             sb.append(multiByte ? '<' : '(');
             for (int i = 0, c = this.currentChars.length(); i < c; i++) {
@@ -531,9 +538,9 @@ public class PSTextPainter extends NativeTextPainter {
                         || metrics instanceof LazyFont
                                 && ((LazyFont) metrics).getRealFont() instanceof MultiByteFont;
                 if (multiByte) {
-                    gen.write('<');
+                    gen.write("<");
                     gen.write(HexEncoder.encode(mapped));
-                    gen.write('>');
+                    gen.write(">");
                 } else {
                     char codepoint = (char)(mapped % 256);
                     gen.write("(" + codepoint + ")");

diff --git a/status.xml b/status.xml
index 1cae0afb1ab2b8e0d824671fca57fd3e42e9a0d2..e6a532edea7d28d02fe7a306a4661a132d30123e 100644 (file)
--- a/status.xml
+++ b/status.xml
@@ -59,6 +59,10 @@
       documents. Example: the fix of marks layering will be such a case when it's done.
     -->
     <release version="FOP Trunk" date="TBD">
+      <action context="Renderers" dev="CB" type="fix" fixes-bug="FOP-2173" due-to="Simon Steiner">
+        Invalid Postscript created if more than 255 characters in a custom font are used within 
+        SVG when generating Postscript
+      </action>
       <action context="Code" dev="PH" type="fix" fixes-bug="37114" due-to="Robert Meyer">
         Implementation of changes necessary to warn of invalid property values.
       </action>