Issue fixes for RSS feed improvements (#28380)

Follow-up for #28368

- Just replace button with an a-element with the button class
- Remove useless link-action class from template/org/home.tmpl

diff --git a/templates/org/home.tmpl b/templates/org/home.tmpl
index a84e3efc89de62bf123c25cd979bd78b2ec6c5f2..fc65d4691cbe74d4b6728bb291e271775d5fa8ed 100644 (file)
--- a/templates/org/home.tmpl
+++ b/templates/org/home.tmpl
@@ -21,9 +21,9 @@
                </div>
                <div class="right menu">
                        {{if .EnableFeed}}
-                       <button class="link-action ui basic label button gt-mr-0" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}" data-url="{{$.Org.HomeLink}}.rss">
+                       <a class="ui basic label button gt-mr-0" href="{{$.Org.HomeLink}}.rss" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}">
                                {{svg "octicon-rss" 24}}
-                       </button>
+                       </a>
                        {{end}}
                        <button class="link-action ui basic button gt-mr-0" data-url="{{.Org.HomeLink}}?action={{if $.IsFollowing}}unfollow{{else}}follow{{end}}">
                                {{if $.IsFollowing}}

diff --git a/templates/repo/header.tmpl b/templates/repo/header.tmpl
index e4aadf37e30fe693fae24649ed833e01e964dbe9..af00b2b3831ea3e5a930a1b52e769664f00eb134 100644 (file)
--- a/templates/repo/header.tmpl
+++ b/templates/repo/header.tmpl
@@ -54,9 +54,9 @@
                                        {{end}}
                                        {{if $.EnableFeed}}
                                        {{/* An extra div-element is not necessary here, as this button does not secretly contain two buttons. */}}
-                                       <button class="ui compact small basic button" data-url="{{$.RepoLink}}.rss" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}">
+                                       <a class="ui compact small basic button" href="{{$.RepoLink}}.rss" data-tooltip-content="{{ctx.Locale.Tr "rss_feed"}}">
                                                {{svg "octicon-rss" 16}}
-                                       </button>
+                                       </a>
                                        {{end}}
                                        <form method="post" action="{{$.RepoLink}}/action/{{if $.IsWatchingRepo}}un{{end}}watch?redirect_to={{$.Link}}">
                                                {{$.CsrfTokenHtml}}