]> source.dussan.org Git - vaadin-framework.git/commitdiff
Throw IAE in setExpandRatio() if given ratio is less than 0
authorMaciej Przepióra <mac@vaadin.com>
Thu, 28 Apr 2016 13:34:33 +0000 (16:34 +0300)
committerVaadin Code Review <review@vaadin.com>
Tue, 3 May 2016 10:16:46 +0000 (10:16 +0000)
Change-Id: Ie7f92edea210c54400f6dce38e1376e3c0eae575

server/src/main/java/com/vaadin/ui/AbstractOrderedLayout.java

index f517ab0af5ff149eee9fb275ccb8eeb7ca96bde9..d6df3f372a2b0f1322de083d6c9eddddd78396f3 100644 (file)
@@ -328,6 +328,10 @@ public abstract class AbstractOrderedLayout extends AbstractLayout implements
      * @param component
      *            the component in this layout which expand ratio is to be set
      * @param ratio
+     *            new expand ratio (greater or equal to 0)
+     * @throws IllegalArgumentException
+     *             if the expand ratio is negative or the component is not a
+     *             direct child of the layout
      */
     public void setExpandRatio(Component component, float ratio) {
         ChildComponentData childData = getState().childData.get(component);
@@ -335,6 +339,10 @@ public abstract class AbstractOrderedLayout extends AbstractLayout implements
             throw new IllegalArgumentException(
                     "The given component is not a child of this layout");
         }
+        if (ratio < 0.0f) {
+            throw new IllegalArgumentException(
+                    "Expand ratio can't be less than 0.0");
+        }
 
         childData.expandRatio = ratio;
     }