]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-6605 forgotten Formula in CoreMetrics for Metrics moved to CE
authorSébastien Lesaint <sebastien.lesaint@sonarsource.com>
Thu, 23 Jul 2015 10:31:30 +0000 (12:31 +0200)
committerSébastien Lesaint <sebastien.lesaint@sonarsource.com>
Thu, 23 Jul 2015 11:47:57 +0000 (13:47 +0200)
sonar-batch/src/test/java/org/sonar/batch/deprecated/decorator/FormulaDecoratorTest.java
sonar-batch/src/test/java/org/sonar/batch/mediumtest/measures/MeasuresMediumTest.java
sonar-plugin-api/src/main/java/org/sonar/api/measures/CoreMetrics.java

index 2298a09cb336c47b1cf7ff302d17560bb3c0acff..075e77efffd6c49b9489c3a7dc3b3ec5f269862c 100644 (file)
@@ -19,6 +19,9 @@
  */
 package org.sonar.batch.deprecated.decorator;
 
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
 import org.junit.Test;
 import org.sonar.api.batch.DecoratorContext;
 import org.sonar.api.measures.CoreMetrics;
@@ -29,13 +32,7 @@ import org.sonar.api.measures.Measure;
 import org.sonar.api.measures.Metric;
 import org.sonar.api.test.IsMeasure;
 
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.List;
-
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.hamcrest.core.Is.is;
-import static org.junit.Assert.assertThat;
 import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.argThat;
 import static org.mockito.Mockito.mock;
@@ -45,11 +42,6 @@ import static org.mockito.Mockito.when;
 
 public class FormulaDecoratorTest {
 
-  @Test
-  public void doAlwaysExecute() {
-    assertThat(new FormulaDecorator(CoreMetrics.LINES).shouldExecuteOnProject(null), is(true));
-  }
-
   @Test
   public void declareDependencies() {
     Formula formula = new Formula() {
index 10f7657e886a39820a9e4c78a4c975937e0274a0..ae97beaec18eeab0ec774e4f3e3b09cf77235679 100644 (file)
@@ -67,7 +67,7 @@ public class MeasuresMediumTest {
       .newScanTask(new File(tmpDir, "sonar-project.properties"))
       .start();
 
-    assertThat(result.allMeasures()).hasSize(18);
+    assertThat(result.allMeasures()).hasSize(13);
   }
 
   @Test
@@ -94,7 +94,7 @@ public class MeasuresMediumTest {
         .build())
       .start();
 
-    assertThat(result.allMeasures()).hasSize(4);
+    assertThat(result.allMeasures()).hasSize(2);
 
     assertThat(result.allMeasures()).contains(new DefaultMeasure<Integer>()
       .forMetric(CoreMetrics.LINES)
index c1705f2d947f637272d270bc7d1955bdf742330b..b6207f33ca059e8a15a4b837e049b2862c3a31c0 100644 (file)
@@ -64,7 +64,6 @@ public final class CoreMetrics {
     .setDirection(Metric.DIRECTION_WORST)
     .setQualitative(false)
     .setDomain(DOMAIN_SIZE)
-    .setFormula(new SumChildValuesFormula(false))
     .create();
 
   public static final String GENERATED_LINES_KEY = "generated_lines";
@@ -83,7 +82,6 @@ public final class CoreMetrics {
     .setDirection(Metric.DIRECTION_WORST)
     .setQualitative(false)
     .setDomain(DOMAIN_SIZE)
-    .setFormula(new SumChildValuesFormula(false))
     .create();
 
   /**