return result;
}
private static String formatRecordDetails(int globalOffset, int sid, int size, int recordCounter) {
- StringBuilder sb = new StringBuilder(64);
- sb.append("Offset=").append(HexDump.intToHex(globalOffset)).append("(").append(globalOffset).append(")");
- sb.append(" recno=").append(recordCounter);
- sb.append( " sid=").append(HexDump.shortToHex(sid));
- sb.append( " size=").append(HexDump.shortToHex(size)).append("(").append(size).append(")");
- return sb.toString();
+ return "Offset=" + HexDump.intToHex(globalOffset) + "(" + globalOffset + ")" +
+ " recno=" + recordCounter +
+ " sid=" + HexDump.shortToHex(sid) +
+ " size=" + HexDump.shortToHex(size) + "(" + size + ")";
}
}
import org.apache.poi.ss.util.CellRangeAddress;
import org.apache.poi.ss.util.CellRangeAddressBase;
import org.apache.poi.ss.util.CellReference;
-import org.apache.poi.ss.util.SheetUtil;
/**
* Evaluates Conditional Formatting constraints.<p>
/**
* lazy load by sheet since reading can be expensive
*
- * @param sheet
+ * @param sheet The sheet to look at
* @return unmodifiable list of rules
*/
protected List<EvaluationConditionalFormatRule> getRules(Sheet sheet) {
// compute and cache them
rules = new ArrayList<>();
- Sheet sheet = null;
- if (cellRef.getSheetName() != null) sheet = workbook.getSheet(cellRef.getSheetName());
- else sheet = workbook.getSheetAt(workbook.getActiveSheetIndex());
+ final Sheet sheet;
+ if (cellRef.getSheetName() != null) {
+ sheet = workbook.getSheet(cellRef.getSheetName());
+ } else {
+ sheet = workbook.getSheetAt(workbook.getActiveSheetIndex());
+ }
/*
* Per Excel help:
* formula by the relative position of the current cell, or the wrong value is checked.
* This is handled by {@link WorkbookEvaluator#evaluate(String, CellReference, CellRangeAddressBase)}.
*
- * @param cell
+ * @param cell The cell to look for
* @return Unmodifiable List of {@link EvaluationConditionalFormatRule}s that apply to the current cell value,
* in priority order, as evaluated by Excel (smallest priority # for XSSF, definition order for HSSF),
* or null if none apply
}
/**
- * @param sheetName
+ * Retrieve all formatting rules for the sheet with the given name.
+ *
+ * @param sheetName The name of the sheet to look at
* @return unmodifiable list of all Conditional format rules for the given sheet, if any
*/
public List<EvaluationConditionalFormatRule> getFormatRulesForSheet(String sheetName) {
}
/**
- * @param sheet
+ * Retrieve all formatting rules for the given sheet.
+ *
+ * @param sheet The sheet to look at
* @return unmodifiable list of all Conditional format rules for the given sheet, if any
*/
public List<EvaluationConditionalFormatRule> getFormatRulesForSheet(Sheet sheet) {
}
/**
+ * Retrieve all cells where the given formatting rule evaluates to true.
*
- * @param rule
+ * @param rule The rule to look at
* @return unmodifiable List of all cells in the rule's region matching the rule's condition
*/
public List<Cell> getMatchingCells(EvaluationConditionalFormatRule rule) {
return _sh.getColumnStyle(column);
}
- /**
+ /*
* Sets the CellStyle that applies to the given
* (0 based) column.
*/
/**
* Determines if there is a page break at the indicated row
- * @param row FIXME: Document this!
- * @return FIXME: Document this!
+ * @param row The row to check
+ * @return true if there is a page-break at the given row, false otherwise
*/
@Override
public boolean isRowBroken(int row)
/**
* Removes the page break at the indicated row
- * @param row
+ * @param row The row to remove page breaks from
*/
@Override
public void removeRowBreak(int row)
/**
* Sets a page break at the indicated column
- * @param column
+ * @param column The column to work on
*/
@Override
public void setColumnBreak(int column)
/**
* Determines if there is a page break at the indicated column
- * @param column FIXME: Document this!
- * @return FIXME: Document this!
+ * @param column The column to check for page breaks
+ * @return true if there is a page break at the given column, false otherwise
*/
@Override
public boolean isColumnBroken(int column)
/**
* Removes a page break at the indicated column
- * @param column
+ * @param column The column to remove a page break from
*/
@Override
public void removeColumnBreak(int column)
int startRow = findStartOfRowOutlineGroup(rowIndex);
// Hide all the columns until the end of the group
- int lastRow = writeHidden(row, startRow, true);
+ int lastRow = writeHidden(row, startRow);
SXSSFRow lastRowObj = getRow(lastRow);
if (lastRowObj != null) {
lastRowObj.setCollapsed(true);
return currentRow + 1;
}
- private int writeHidden(SXSSFRow xRow, int rowIndex, boolean hidden) {
+ private int writeHidden(SXSSFRow xRow, int rowIndex) {
int level = xRow.getOutlineLevel();
SXSSFRow currRow = getRow(rowIndex);
while (currRow != null && currRow.getOutlineLevel() >= level) {
- currRow.setHidden(hidden);
+ currRow.setHidden(true);
rowIndex++;
currRow = getRow(rowIndex);
}
/**
* Get a Hyperlink in this sheet anchored at row, column
*
- * @param row
- * @param column
+ * @param row The 0-base row number
+ * @param column The 0-based column number
* @return hyperlink if there is a hyperlink anchored at row, column; otherwise returns null
*/
@Override
/**
* Flush all rows to disk. After this call no rows can be accessed via getRow()
*
- * @throws IOException
+ * @throws IOException If an I/O error occurs
*/
public void flushRows() throws IOException
{
public int getRowNum(SXSSFRow row)
{
- for(Iterator<Map.Entry<Integer,SXSSFRow>> iter=_rows.entrySet().iterator();iter.hasNext();)
- {
- Map.Entry<Integer,SXSSFRow> entry=iter.next();
- if(entry.getValue()==row) {
+ for (Map.Entry<Integer, SXSSFRow> entry : _rows.entrySet()) {
+ if (entry.getValue() == row) {
return entry.getKey().intValue();
}
}
+
return -1;
}
* @exception IOException if anything can't be written.
*/
@Override
- public void write(OutputStream stream) throws IOException
- {
+ public void write(OutputStream stream) throws IOException {
flushSheets();
//Save the template
*
* @param rownum 0-based row number
* @param row a row
+ *
+ * @throws IOException If an I/O error occurs
*/
public void writeRow(int rownum, SXSSFRow row) throws IOException {
if (_numberOfFlushedRows == 0)
@Override
public CellRange<XSSFCell> setArrayFormula(String formula, CellRangeAddress range) {
-
CellRange<XSSFCell> cr = getCellRange(range);
XSSFCell mainArrayFormulaCell = cr.getTopLeftCell();
import org.apache.poi.xwpf.usermodel.XWPFDocument;
import org.junit.After;
import org.junit.Before;
+import org.junit.Ignore;
import org.junit.Test;
/**
return utcString.equals(dateTimeUtcString);
}
- //@Test
+ @Ignore("Fails to add some of the thumbnails, needs more investigation")
+ @Test
public void testThumbnails() throws Exception {
POIXMLProperties noThumbProps = sampleNoThumb.getProperties();
}
public static byte[] getImage(String filename) throws IOException {
- InputStream is = POIDataSamples.getDocumentInstance().openResourceAsStream(filename);
- try {
+ try (InputStream is = POIDataSamples.getDocumentInstance().openResourceAsStream(filename)) {
return IOUtils.toByteArray(is);
- } finally {
- is.close();
}
}
}
assertEquals(filename, attachment.getLongFilename());
assertContents(filename, attachment.getContents());
}
+
protected void assertContents(String filename, byte[] actual)
throws IOException {
- InputStream stream = _samples.openResourceAsStream("quick-contents/" + filename);
- try {
- byte[] expected = IOUtils.toByteArray(stream);
-
- assertEquals(expected.length, actual.length);
- for(int i=0; i<expected.length; i++) {
- assertEquals("Byte " + i + " wrong", expected[i], actual[i]);
- }
- } finally {
- stream.close();
- }
+ try (InputStream stream = _samples.openResourceAsStream("quick-contents/" + filename)) {
+ byte[] expected = IOUtils.toByteArray(stream);
+
+ assertEquals(expected.length, actual.length);
+ for (int i = 0; i < expected.length; i++) {
+ assertEquals("Byte " + i + " wrong", expected[i], actual[i]);
+ }
+ }
}
}
package org.apache.poi.hmef.extractor;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertArrayEquals;
File outputDirectory = TempFile.createTempDirectory("quick-winmail-main");
String[] args = new String[] { message.getAbsolutePath(), outputDirectory.getAbsolutePath() };
HMEFContentsExtractor.main(args);
-
+
String[] contents = new String[] {
"message.rtf", // from extractMessageBody
"quick.txt", "quick.pdf", "quick.xml", "quick.doc", "quick.html" // from extractAttachments
for (String filename : contents) {
File f = new File(outputDirectory, filename);
assertTrue(f + " does not exist", f.exists());
+ assertTrue(f.delete());
}
- outputDirectory.delete();
+ String[] list = outputDirectory.list();
+ assertNotNull(list);
+ assertEquals( "Had: " + Arrays.toString(list), 0, list.length);
+ assertTrue(outputDirectory.delete());
}
-
+
@Test
public void TestExtractMessageBody_OutputStream() throws IOException {
POIDataSamples samples = POIDataSamples.getHMEFInstance();
assertArrayEquals("RTF magic number", expectedMagic, magic);
out.close();
}
-
+
@Test
public void TestExtractMessageBody_File() throws IOException {
POIDataSamples samples = POIDataSamples.getHMEFInstance();
protected static NPOIFSFileSystem writeOutFileAndReadBack(NPOIFSFileSystem original) throws IOException {
final File file = TempFile.createTempFile("TestPOIFS", ".ole2");
- final OutputStream fout = new FileOutputStream(file);
- try {
- original.writeFilesystem(fout);
- } finally {
- fout.close();
- }
+ try (OutputStream fout = new FileOutputStream(file)) {
+ original.writeFilesystem(fout);
+ }
return new NPOIFSFileSystem(file, false);
}
long start = System.currentTimeMillis();
for (int i = 0; i < iterations; i++) {
- InputStream inputStream = POIDataSamples.getHSMFInstance().openResourceAsStream("lots-of-recipients.msg");
- try {
+ try (InputStream inputStream = POIDataSamples.getHSMFInstance().openResourceAsStream("lots-of-recipients.msg")) {
OPOIFSFileSystem srcFileSystem = new OPOIFSFileSystem(inputStream);
OPOIFSFileSystem destFileSystem = new OPOIFSFileSystem();
copyAllEntries(srcFileSystem.getRoot(), destFileSystem.getRoot());
File file = File.createTempFile("opoi", ".dat");
- OutputStream outputStream = new FileOutputStream(file);
- try {
+ try (OutputStream outputStream = new FileOutputStream(file)) {
destFileSystem.writeFilesystem(outputStream);
- } finally {
- outputStream.close();
}
assertTrue(file.delete());
if (i % 10 == 0) System.out.print(".");
if (i % 800 == 0 && i > 0) System.out.println();
- } finally {
- inputStream.close();
}
}
for (int i = 0; i < iterations; i++) {
- InputStream inputStream = POIDataSamples.getHSMFInstance().openResourceAsStream("lots-of-recipients.msg");
- try {
+ try (InputStream inputStream = POIDataSamples.getHSMFInstance().openResourceAsStream("lots-of-recipients.msg")) {
NPOIFSFileSystem srcFileSystem = new NPOIFSFileSystem(inputStream);
NPOIFSFileSystem destFileSystem = new NPOIFSFileSystem();
copyAllEntries(srcFileSystem.getRoot(), destFileSystem.getRoot());
File file = File.createTempFile("npoi", ".dat");
- OutputStream outputStream = new FileOutputStream(file);
- try {
+ try (OutputStream outputStream = new FileOutputStream(file)) {
destFileSystem.writeFilesystem(outputStream);
- } finally {
- outputStream.close();
}
assertTrue(file.delete());
if (i % 10 == 0) System.out.print(".");
if (i % 800 == 0 && i > 0) System.out.println();
- } finally {
- inputStream.close();
}
}
} else {
DocumentEntry srcEntry = (DocumentEntry) entry;
- InputStream inputStream = new DocumentInputStream(srcEntry);
- try {
+ try (InputStream inputStream = new DocumentInputStream(srcEntry)) {
destDirectory.createDocument(entry.getName(), inputStream);
- } finally {
- inputStream.close();
}
}
}
*/
workbook.close();
}
-
- @Ignore
+
+ @Ignore("See bug 59728")
@Test
public void shouldNotBeAbleToCreateArrayFormulaOnPreexistingMergedRegion() throws IOException {
/*
projects / poi.git / commitdiff