Remove PhantomJS from testing (#10997)

diff --git a/uitest/src/test/java/com/vaadin/tests/actions/ActionsOnDetachedComponentsTest.java b/uitest/src/test/java/com/vaadin/tests/actions/ActionsOnDetachedComponentsTest.java
index 9d7fb618adda466e64af742aed8c368aef5dbd85..a45c6292d22e3b6a64f653e2fbaec7ba01b347e1 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/actions/ActionsOnDetachedComponentsTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/actions/ActionsOnDetachedComponentsTest.java
@@ -4,13 +4,10 @@ import static org.hamcrest.CoreMatchers.endsWith;
 import static org.hamcrest.CoreMatchers.not;
 import static org.junit.Assert.assertThat;
 
-import java.util.List;
-
 import org.junit.Before;
 import org.junit.Test;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.By;
 import com.vaadin.testbench.elements.TableElement;
@@ -31,11 +28,6 @@ public class ActionsOnDetachedComponentsTest extends MultiBrowserTest {
         }
     }
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingContextMenu();
-    }
-
     @Test
     public void shortcutActionOnDetachedComponentShouldNotBeHandled()
             throws InterruptedException {

diff --git a/uitest/src/test/java/com/vaadin/tests/actions/ActionsOnInvisibleComponentsTest.java b/uitest/src/test/java/com/vaadin/tests/actions/ActionsOnInvisibleComponentsTest.java
index b171d3d1ffd5d4340ea473c207bb876955024b08..eb0cb893bad532bb8ce2a0f791118faa618f8381 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/actions/ActionsOnInvisibleComponentsTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/actions/ActionsOnInvisibleComponentsTest.java
@@ -2,33 +2,23 @@ package com.vaadin.tests.actions;
 
 import static org.junit.Assert.assertEquals;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class ActionsOnInvisibleComponentsTest extends MultiBrowserTest {
     private static final String LAST_INIT_LOG = "3. 'C' triggers a click on a visible and enabled button";
 
-    // This method should be removed once #12785 is fixed
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowserCapabilities(Browser.IE11, Browser.PHANTOMJS);
-    }
-
     @Test
     public void testShortcutsOnInvisibleDisabledButtons() {
         openTestURL();
         assertEquals(LAST_INIT_LOG, getLogRow(0));
-        invokeShortcut("A");
+        invokeShortcut("a");
         assertEquals(LAST_INIT_LOG, getLogRow(0));
-        invokeShortcut("B");
+        invokeShortcut("b");
         assertEquals(LAST_INIT_LOG, getLogRow(0));
-        invokeShortcut("C");
+        invokeShortcut("c");
         assertEquals("4. Click event for enabled button", getLogRow(0));
     }
 

diff --git a/uitest/src/test/java/com/vaadin/tests/components/abstractcomponent/ContextClickUITest.java b/uitest/src/test/java/com/vaadin/tests/components/abstractcomponent/ContextClickUITest.java
index 09ecd47d274deb5498be4d49252fc7bcaa10e3af..2dea0fbd4c746861ed989f13f338fe8a308cd78b 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/abstractcomponent/ContextClickUITest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/abstractcomponent/ContextClickUITest.java
@@ -3,11 +3,8 @@ package com.vaadin.tests.components.abstractcomponent;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.ButtonElement;
 import com.vaadin.testbench.elements.UIElement;
@@ -15,11 +12,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class ContextClickUITest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingContextMenu();
-    }
-
     @Test
     public void testContextClick() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/checkbox/CheckboxContextClickTest.java b/uitest/src/test/java/com/vaadin/tests/components/checkbox/CheckboxContextClickTest.java
index f3c6f6371bd38d6860cf25cf56d6ab6b8e8cea76..3703024cbf0767380fdcf76284a607defcccd2a7 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/checkbox/CheckboxContextClickTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/checkbox/CheckboxContextClickTest.java
@@ -2,11 +2,8 @@ package com.vaadin.tests.components.checkbox;
 
 import static org.junit.Assert.assertEquals;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.WebElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.By;
 import com.vaadin.testbench.elements.CheckBoxElement;
@@ -14,11 +11,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class CheckboxContextClickTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingContextMenu();
-    }
-
     @Test
     public void contextClickCheckboxAndText() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/grid/GridColumnAutoExpandTest.java b/uitest/src/test/java/com/vaadin/tests/components/grid/GridColumnAutoExpandTest.java
index bb946aa43d097a531e5b11f86b2e7459f49fb67c..bd0cc55cc9b7b3bef51908c31fe212fb5b9e11c5 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/grid/GridColumnAutoExpandTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/grid/GridColumnAutoExpandTest.java
@@ -2,10 +2,7 @@ package com.vaadin.tests.components.grid;
 
 import static org.junit.Assert.assertTrue;
 
-import java.util.List;
-
 import org.junit.Test;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.GridElement;
 import com.vaadin.testbench.elements.GridElement.GridCellElement;
@@ -13,13 +10,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class GridColumnAutoExpandTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // The functionality doesn't work for PHJS_1. And the test fails. It
-        // works for PHJS_2.
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void testSecondColumnHasExpanded() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/grid/GridDetailsLayoutExpandTest.java b/uitest/src/test/java/com/vaadin/tests/components/grid/GridDetailsLayoutExpandTest.java
index bf5fdb1988cbf16f702848698b47555e7885ce10..73e2794c613c0213167946029fa58a06ff305649 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/grid/GridDetailsLayoutExpandTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/grid/GridDetailsLayoutExpandTest.java
@@ -3,15 +3,11 @@ package com.vaadin.tests.components.grid;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.number.IsCloseTo.closeTo;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.By;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.GridElement;
 import com.vaadin.testbench.elements.LabelElement;
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.testbench.parallel.TestCategory;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
@@ -24,15 +20,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
 @TestCategory("grid")
 public class GridDetailsLayoutExpandTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        List<DesiredCapabilities> browsersToTest = super.getBrowsersToTest();
-        // for some reason PhantomJS doesn't find the label even if it detects
-        // the presence
-        browsersToTest.remove(Browser.PHANTOMJS.getDesiredCapabilities());
-        return browsersToTest;
-    }
-
     @Test
     public void testLabelWidths() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/grid/GridLayoutDetailsRowResizeTest.java b/uitest/src/test/java/com/vaadin/tests/components/grid/GridLayoutDetailsRowResizeTest.java
index eeb5136df5ec2406c4bec7ba58c7aae3e7659784..05b54e7d7465a56d15b9177f60ee0320daa0d856 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/grid/GridLayoutDetailsRowResizeTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/grid/GridLayoutDetailsRowResizeTest.java
@@ -19,7 +19,6 @@ import org.openqa.selenium.support.ui.ExpectedCondition;
 import com.vaadin.testbench.elements.ButtonElement;
 import com.vaadin.testbench.elements.GridElement;
 import com.vaadin.testbench.elements.LabelElement;
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.testbench.parallel.TestCategory;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
@@ -75,15 +74,6 @@ public class GridLayoutDetailsRowResizeTest extends MultiBrowserTest {
 
     @Test
     public void testMultipleDetailsRows() {
-        if (Browser.PHANTOMJS.name()
-                .equalsIgnoreCase(getDesiredCapabilities().getBrowserName())) {
-            // For some inexplicable reason PhantomJS fails to click that
-            // button, even if similar button clicks work just fine in other
-            // tests. Didn't disable PhantomJS altogether so that the other test
-            // at least could work in the initial pre-merge regression check.
-            return;
-        }
-
         setDebug(true);
         openTestURL();
         waitForElementPresent(By.className("v-grid"));

diff --git a/uitest/src/test/java/com/vaadin/tests/components/grid/GridMultiSelectEmptyTest.java b/uitest/src/test/java/com/vaadin/tests/components/grid/GridMultiSelectEmptyTest.java
index baf85cc45a36bfa99a278f6b1438ec34ff71558e..1d93a8b509d0f4c84d9dc7cd70d269995b192da5 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/grid/GridMultiSelectEmptyTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/grid/GridMultiSelectEmptyTest.java
@@ -2,10 +2,7 @@ package com.vaadin.tests.components.grid;
 
 import static org.junit.Assert.assertEquals;
 
-import java.util.List;
-
 import org.junit.Test;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.ButtonElement;
 import com.vaadin.testbench.elements.GridElement;
@@ -13,12 +10,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class GridMultiSelectEmptyTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // On PhantomJS the result is more correct before recalculation.
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void testCheckBoxColumnCorrectSize() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/grid/GridPopupViewTest.java b/uitest/src/test/java/com/vaadin/tests/components/grid/GridPopupViewTest.java
index 989fdacc82bf09b55bd96c69b2fa021d0aaa5a79..fa21b5097e7b1ddf2dde60862682ecf8d057566b 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/grid/GridPopupViewTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/grid/GridPopupViewTest.java
@@ -2,28 +2,16 @@ package com.vaadin.tests.components.grid;
 
 import static org.junit.Assert.assertEquals;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.Dimension;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.GridElement;
 import com.vaadin.testbench.elements.PopupViewElement;
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class GridPopupViewTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        List<DesiredCapabilities> l = getBrowserCapabilities(Browser.IE11,
-                Browser.FIREFOX, Browser.CHROME);
-        l.add(PHANTOMJS2());
-        return l;
-    }
-
     @Test
     public void gridSizeCorrect() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/grid/basics/GridBasicsTest.java b/uitest/src/test/java/com/vaadin/tests/components/grid/basics/GridBasicsTest.java
index 67c196a4e98e87831eb762096b26885287821cb5..81f2518afc5de3f6ce4c45d5437a6fc41b1f0dcf 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/grid/basics/GridBasicsTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/grid/basics/GridBasicsTest.java
@@ -35,7 +35,7 @@ public abstract class GridBasicsTest extends MultiBrowserTest {
     @Override
     public List<DesiredCapabilities> getBrowsersToTest() {
         // Most tests are run with only one browser.
-        return getBrowserCapabilities(Browser.PHANTOMJS);
+        return getBrowserCapabilities(Browser.CHROME);
     }
 
     @Override

diff --git a/uitest/src/test/java/com/vaadin/tests/components/orderedlayout/OrderedLayoutInfiniteLayoutPassesTest.java b/uitest/src/test/java/com/vaadin/tests/components/orderedlayout/OrderedLayoutInfiniteLayoutPassesTest.java
index 8f49903fac5f54a8dc3493fd784337c7319f2dc3..247d3b140ada3ccf8bc995892cd3867a440c8718 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/orderedlayout/OrderedLayoutInfiniteLayoutPassesTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/orderedlayout/OrderedLayoutInfiniteLayoutPassesTest.java
@@ -1,15 +1,11 @@
 package com.vaadin.tests.components.orderedlayout;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.Keys;
 import org.openqa.selenium.WebElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.ButtonElement;
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class OrderedLayoutInfiniteLayoutPassesTest extends MultiBrowserTest {
@@ -19,15 +15,6 @@ public class OrderedLayoutInfiniteLayoutPassesTest extends MultiBrowserTest {
         return true;
     }
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        List<DesiredCapabilities> b = super.getBrowsersToTest();
-        // Chrome and PhantomJS do not support browser zoom changes
-        b.remove(Browser.CHROME.getDesiredCapabilities());
-        b.remove(Browser.PHANTOMJS.getDesiredCapabilities());
-        return b;
-    }
-
     @Test
     public void ensureFiniteLayoutPhase() throws Exception {
         openTestURL("debug");

diff --git a/uitest/src/test/java/com/vaadin/tests/components/richtextarea/RichTextAreaDelegateToShortcutHandlerTest.java b/uitest/src/test/java/com/vaadin/tests/components/richtextarea/RichTextAreaDelegateToShortcutHandlerTest.java
index 0188ae74501df7955dc3f0f6e55630a44d720eca..7c67f1e8d9fea295a43cc82d8d2c4369556f54ab 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/richtextarea/RichTextAreaDelegateToShortcutHandlerTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/richtextarea/RichTextAreaDelegateToShortcutHandlerTest.java
@@ -1,25 +1,18 @@
 package com.vaadin.tests.components.richtextarea;
 
-import java.util.List;
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
 
-import com.vaadin.testbench.elements.RichTextAreaElement;
-import com.vaadin.tests.tb3.MultiBrowserTest;
 import org.junit.Test;
 import org.openqa.selenium.Keys;
 import org.openqa.selenium.WebElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
-import static org.hamcrest.Matchers.containsString;
-import static org.junit.Assert.assertThat;
+import com.vaadin.testbench.elements.RichTextAreaElement;
+import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class RichTextAreaDelegateToShortcutHandlerTest
         extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void shouldDelegateToShortcutActionHandler() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/richtextarea/RichTextAreaReadOnlyDisabledTest.java b/uitest/src/test/java/com/vaadin/tests/components/richtextarea/RichTextAreaReadOnlyDisabledTest.java
index 767f50f62744cc5b80f403eab4fe7062613ca993..ebfbee95c47704c67626fdda17fb91407c8ccde5 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/richtextarea/RichTextAreaReadOnlyDisabledTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/richtextarea/RichTextAreaReadOnlyDisabledTest.java
@@ -1,20 +1,13 @@
 package com.vaadin.tests.components.richtextarea;
 
-import com.vaadin.tests.tb3.MultiBrowserTest;
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
-import java.util.List;
+import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class RichTextAreaReadOnlyDisabledTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void shouldDelegateToShortcutActionHandler() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/table/ContextMenuSizeTest.java b/uitest/src/test/java/com/vaadin/tests/components/table/ContextMenuSizeTest.java
index 663eb59cd266f9543b65f746d95a911aac3f722a..6dab60b655b1d03f76d9d7174d70167eff879266 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/table/ContextMenuSizeTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/table/ContextMenuSizeTest.java
@@ -4,13 +4,10 @@ import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.lessThan;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
@@ -21,11 +18,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
  */
 public class ContextMenuSizeTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingContextMenu();
-    }
-
     @Override
     public void setup() throws Exception {
         super.setup();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/table/TableContextMenuAndIconsTest.java b/uitest/src/test/java/com/vaadin/tests/components/table/TableContextMenuAndIconsTest.java
index 1eab7f22e4e790a2da1113bb6ec66fb2366955dc..5410477af1f9c42a06d4d98f6b5179892dd4f790 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/table/TableContextMenuAndIconsTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/table/TableContextMenuAndIconsTest.java
@@ -1,10 +1,7 @@
 package com.vaadin.tests.components.table;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.TestBenchElement;
 import com.vaadin.testbench.elements.TableElement;
@@ -16,11 +13,6 @@ public class TableContextMenuAndIconsTest extends MultiBrowserTest {
         return com.vaadin.tests.components.table.Tables.class;
     }
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingContextMenu();
-    }
-
     @Test
     public void tableContextMenuWithIcons() throws Exception {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/tabsheet/TabSheetFocusedTabTest.java b/uitest/src/test/java/com/vaadin/tests/components/tabsheet/TabSheetFocusedTabTest.java
index 060126f3684a8312f2a0a2117dfc2ba46cd35ff0..b8921bd0a7718df259b208fbd5db4dd67c4ec03a 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/tabsheet/TabSheetFocusedTabTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/tabsheet/TabSheetFocusedTabTest.java
@@ -3,26 +3,16 @@ package com.vaadin.tests.components.tabsheet;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.Keys;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.By;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class TabSheetFocusedTabTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // PhantomJS doesn't send Focus / Blur events when clicking or
-        // navigating with keyboard
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Override
     protected Class<?> getUIClass() {
         return TabsheetScrolling.class;

diff --git a/uitest/src/test/java/com/vaadin/tests/components/ui/ComboboxSelectedItemTextTest.java b/uitest/src/test/java/com/vaadin/tests/components/ui/ComboboxSelectedItemTextTest.java
index 1a8c0203521bf1a5f5f77b43bfe56fb380238199..406a6f3177aed7d69bfd9b7e90c3088a727c7d7a 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/ui/ComboboxSelectedItemTextTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/ui/ComboboxSelectedItemTextTest.java
@@ -8,7 +8,6 @@ import org.openqa.selenium.WebElement;
 import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.By;
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 /**
@@ -28,9 +27,8 @@ public class ComboboxSelectedItemTextTest extends MultiBrowserTest {
 
     @Override
     public List<DesiredCapabilities> getBrowsersToTest() {
-        // Ignoring Chrome 40 because of a regression. See #16636.
-        return getBrowserCapabilities(Browser.IE11, Browser.FIREFOX,
-                Browser.PHANTOMJS);
+        // Regression. See #16636.
+        return getBrowsersExcludingChrome();
     }
 
     @Test

diff --git a/uitest/src/test/java/com/vaadin/tests/components/ui/TextAreaEventPropagationModifierKeysTest.java b/uitest/src/test/java/com/vaadin/tests/components/ui/TextAreaEventPropagationModifierKeysTest.java
index 9ff676463a93483593eda345be525553843f97a7..243efb114f5e6839507ce5e6459db19e841fcbd8 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/ui/TextAreaEventPropagationModifierKeysTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/ui/TextAreaEventPropagationModifierKeysTest.java
@@ -2,16 +2,12 @@ package com.vaadin.tests.components.ui;
 
 import static org.junit.Assert.assertEquals;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.Keys;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.TextAreaElement;
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class TextAreaEventPropagationModifierKeysTest extends MultiBrowserTest {
@@ -24,9 +20,7 @@ public class TextAreaEventPropagationModifierKeysTest extends MultiBrowserTest {
         Actions builder = new Actions(driver);
         builder.click(textArea);
         builder.sendKeys(textArea, "first line asdf");
-        builder.keyDown(Keys.SHIFT);
-        builder.sendKeys(Keys.ENTER);
-        builder.keyUp(Keys.SHIFT);
+        builder.sendKeys(Keys.chord(Keys.SHIFT, Keys.ENTER));
         builder.sendKeys(textArea, "second line jkl;");
         builder.perform();
 
@@ -43,9 +37,7 @@ public class TextAreaEventPropagationModifierKeysTest extends MultiBrowserTest {
         Actions builder = new Actions(driver);
         builder.click(textArea);
         builder.sendKeys(textArea, "first line asdf");
-        builder.keyDown(Keys.CONTROL);
-        builder.sendKeys(Keys.ENTER);
-        builder.keyUp(Keys.CONTROL);
+        builder.sendKeys(Keys.chord(Keys.CONTROL, Keys.ENTER));
         builder.sendKeys(textArea, "second line jkl;");
         builder.perform();
 
@@ -53,13 +45,6 @@ public class TextAreaEventPropagationModifierKeysTest extends MultiBrowserTest {
         assertEquals("1. Ctrl-Enter button pressed", getLogRow(0));
     }
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // Firefox can't handle ctrl.
-        // IE11 has issues with shift and ctrl
-        return getBrowserCapabilities(Browser.CHROME, Browser.PHANTOMJS);
-    }
-
     @Override
     protected Class<?> getUIClass() {
         return TextAreaEventPropagation.class;

diff --git a/uitest/src/test/java/com/vaadin/tests/components/upload/InterruptUploadTest.java b/uitest/src/test/java/com/vaadin/tests/components/upload/InterruptUploadTest.java
index 987019044948cb7a5ba394e9ac016df8262a8c47..b956820303c66038e0dae02d1505a07b2e1b1d72 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/upload/InterruptUploadTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/upload/InterruptUploadTest.java
@@ -6,13 +6,11 @@ import java.io.BufferedWriter;
 import java.io.File;
 import java.io.FileWriter;
 import java.io.IOException;
-import java.util.List;
 
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.internal.WrapsElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 import org.openqa.selenium.remote.LocalFileDetector;
 import org.openqa.selenium.remote.RemoteWebElement;
 
@@ -24,12 +22,6 @@ import com.vaadin.tests.util.LoremIpsum;
 
 public class InterruptUploadTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // PhantomJS fails to upload files for unknown reasons
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void testInterruptUpload() throws Exception {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/upload/TestFileUploadTest.java b/uitest/src/test/java/com/vaadin/tests/components/upload/TestFileUploadTest.java
index 1a31d24f43953d7dc727eb54917e5ae92e45f307..daff475fc4087a638184ed35c12cf0264f727113 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/upload/TestFileUploadTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/upload/TestFileUploadTest.java
@@ -9,13 +9,11 @@ import java.io.IOException;
 import java.math.BigInteger;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
-import java.util.List;
 
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.internal.WrapsElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 import org.openqa.selenium.remote.LocalFileDetector;
 import org.openqa.selenium.remote.RemoteWebElement;
 
@@ -24,12 +22,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class TestFileUploadTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // PhantomJS fails to upload files for unknown reasons
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void testUploadAnyFile() throws Exception {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/components/upload/UploadInTabsheetTest.java b/uitest/src/test/java/com/vaadin/tests/components/upload/UploadInTabsheetTest.java
index 910588d192ee90410f038c75bbe26b4a0ba8c0f0..f54f59141e884e1d1dfd0db4a54a8d6baa56d94f 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/upload/UploadInTabsheetTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/upload/UploadInTabsheetTest.java
@@ -4,13 +4,11 @@ import java.io.BufferedWriter;
 import java.io.File;
 import java.io.FileWriter;
 import java.io.IOException;
-import java.util.List;
 
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.internal.WrapsElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 import org.openqa.selenium.remote.LocalFileDetector;
 import org.openqa.selenium.remote.RemoteWebElement;
 
@@ -23,12 +21,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
  */
 public class UploadInTabsheetTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // PhantomJS fails to upload files for unknown reasons
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void testThatChangingTabAfterUploadDoesntCauseErrors()
             throws Exception {

diff --git a/uitest/src/test/java/com/vaadin/tests/components/window/ComboboxScrollableWindowTest.java b/uitest/src/test/java/com/vaadin/tests/components/window/ComboboxScrollableWindowTest.java
index 878314f284618d9f92b681f641e6331eba66815e..c4cb78eeef6f9773a6a4a12ad7738d4b0c019ebb 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/components/window/ComboboxScrollableWindowTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/window/ComboboxScrollableWindowTest.java
@@ -3,11 +3,8 @@ package com.vaadin.tests.components.window;
 import static com.vaadin.tests.components.window.ComboboxScrollableWindow.COMBOBOX_ID;
 import static com.vaadin.tests.components.window.ComboboxScrollableWindow.WINDOW_ID;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.WebElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.By;
 import com.vaadin.testbench.commands.TestBenchElementCommands;
@@ -22,12 +19,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
  */
 public class ComboboxScrollableWindowTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // Fix to #10652 broke this for PhantomJS
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void testWindowScrollbars() throws Exception {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/contextclick/AbstractContextClickTest.java b/uitest/src/test/java/com/vaadin/tests/contextclick/AbstractContextClickTest.java
index 24816845c56181eeaa84f9ce14ec16db7297bcb6..e8663a687cf7192dfffdb19fd8994ea2302da7c7 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/contextclick/AbstractContextClickTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/contextclick/AbstractContextClickTest.java
@@ -3,7 +3,6 @@ package com.vaadin.tests.contextclick;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 
-import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
@@ -12,7 +11,6 @@ import org.junit.Test;
 import org.openqa.selenium.Point;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.AbstractComponentElement;
 import com.vaadin.testbench.elements.ButtonElement;
@@ -26,11 +24,6 @@ public abstract class AbstractContextClickTest extends MultiBrowserTest {
     private Pattern defaultLog = Pattern
             .compile("[0-9]+. ContextClickEvent: [(]([0-9]+), ([0-9]+)[)]");
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingContextMenu();
-    }
-
     @Before
     public void setUp() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/extensions/SetThemeAndResponsiveLayoutTest.java b/uitest/src/test/java/com/vaadin/tests/extensions/SetThemeAndResponsiveLayoutTest.java
index 1c41207c6224f35edd41e37eb7c51891e369047b..b76177f8cfcd8d4e0b2abd83dc86b579c0626aa3 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/extensions/SetThemeAndResponsiveLayoutTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/extensions/SetThemeAndResponsiveLayoutTest.java
@@ -2,13 +2,9 @@ package com.vaadin.tests.extensions;
 
 import static org.junit.Assert.assertEquals;
 
-import java.util.List;
-
 import org.junit.Before;
 import org.junit.Test;
-import org.openqa.selenium.remote.DesiredCapabilities;
 import org.openqa.selenium.support.ui.ExpectedConditions;
-import org.openqa.selenium.support.ui.WebDriverWait;
 
 import com.vaadin.testbench.By;
 import com.vaadin.testbench.elements.ButtonElement;
@@ -24,13 +20,6 @@ public class SetThemeAndResponsiveLayoutTest extends MultiBrowserTest {
         testBench().resizeViewPortTo(1024, 768);
     }
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // Seems like stylesheet onload is not fired on PhantomJS
-        // https://github.com/ariya/phantomjs/issues/12332
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void testWidthAndHeightRanges() throws Exception {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/htmlimport/HtmlImportUITest.java b/uitest/src/test/java/com/vaadin/tests/htmlimport/HtmlImportUITest.java
index 588d42acae9256c2f12269882d70244671c20776..36b108f05202343011b7760d3dcb9b9f28c06f16 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/htmlimport/HtmlImportUITest.java
+++ b/uitest/src/test/java/com/vaadin/tests/htmlimport/HtmlImportUITest.java
@@ -7,36 +7,15 @@ import static org.junit.Assert.assertTrue;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.stream.Collectors;
 
 import org.junit.Test;
 import org.openqa.selenium.WebElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.By;
-import com.vaadin.testbench.parallel.BrowserUtil;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class HtmlImportUITest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-
-        List<DesiredCapabilities> browsers = getBrowsersExcludingPhantomJS();
-        browsers.add(PHANTOMJS2());
-
-        return browsers.stream().filter(dc -> {
-            // Won't work on Firefox 24, will work when testing is done on a
-            // modern Firefox
-            if (BrowserUtil.isFirefox(dc) && dc.getVersion().equals("24")) {
-                return false;
-            }
-
-            return true;
-
-        }).collect(Collectors.toList());
-    }
-
     @Test
     public void importsLoadedAfterJs() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/push/BasicPushWebsocketTest.java b/uitest/src/test/java/com/vaadin/tests/push/BasicPushWebsocketTest.java
index 1143ba59ed66603f42c68bd143889a3708595ba5..f59ba0814a9230a664cbfb94854b9be5f51543c4 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/push/BasicPushWebsocketTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/push/BasicPushWebsocketTest.java
@@ -1,12 +1,4 @@
 package com.vaadin.tests.push;
 
-import java.util.List;
-
-import org.openqa.selenium.remote.DesiredCapabilities;
-
 public class BasicPushWebsocketTest extends BasicPushTest {
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingWebSocket();
-    }
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/push/BasicPushWebsocketXhrTest.java b/uitest/src/test/java/com/vaadin/tests/push/BasicPushWebsocketXhrTest.java
index d2ce3c5e7af6e9c03371771d489889eb78186210..bcba9d0aa5872d3add6fd77a4979d5450e90c3fd 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/push/BasicPushWebsocketXhrTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/push/BasicPushWebsocketXhrTest.java
@@ -1,12 +1,4 @@
 package com.vaadin.tests.push;
 
-import java.util.List;
-
-import org.openqa.selenium.remote.DesiredCapabilities;
-
 public class BasicPushWebsocketXhrTest extends BasicPushTest {
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingWebSocket();
-    }
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/push/ExtremelyLongPushTimeWebsocketTest.java b/uitest/src/test/java/com/vaadin/tests/push/ExtremelyLongPushTimeWebsocketTest.java
index c90a48ee042ae97c3e78de0ef5dc0cc0aa6b9830..19792b136ecc3bdd06845c624a9190a794fc4be8 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/push/ExtremelyLongPushTimeWebsocketTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/push/ExtremelyLongPushTimeWebsocketTest.java
@@ -1,14 +1,5 @@
 package com.vaadin.tests.push;
 
-import java.util.List;
-
-import org.openqa.selenium.remote.DesiredCapabilities;
-
 public class ExtremelyLongPushTimeWebsocketTest
         extends ExtremelyLongPushTimeTest {
-
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingWebSocket();
-    }
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/push/IdlePushChannelWebsocketTest.java b/uitest/src/test/java/com/vaadin/tests/push/IdlePushChannelWebsocketTest.java
index 7885b6c911ec8a1951ae7715ad506f34655a704b..b91103844c4dc41bcc5835cc2e41040e5e05537a 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/push/IdlePushChannelWebsocketTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/push/IdlePushChannelWebsocketTest.java
@@ -1,18 +1,9 @@
 package com.vaadin.tests.push;
 
-import java.util.List;
-
-import org.openqa.selenium.remote.DesiredCapabilities;
-
 public class IdlePushChannelWebsocketTest extends IdlePushChannelTest {
 
     @Override
     protected Class<?> getUIClass() {
         return BasicPushWebsocket.class;
     }
-
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingWebSocket();
-    }
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/push/PushConfigurationWebSocketTest.java b/uitest/src/test/java/com/vaadin/tests/push/PushConfigurationWebSocketTest.java
index faa7f45ab33fc249f77e644fe34e61976441390f..53a7852b212612992c91d60f25e90f5a0a6e4339 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/push/PushConfigurationWebSocketTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/push/PushConfigurationWebSocketTest.java
@@ -4,18 +4,10 @@ import static org.hamcrest.CoreMatchers.containsString;
 import static org.hamcrest.CoreMatchers.not;
 import static org.hamcrest.MatcherAssert.assertThat;
 
-import java.util.List;
-
 import org.junit.Test;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 public class PushConfigurationWebSocketTest extends PushConfigurationTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingWebSocket();
-    }
-
     @Test
     public void testWebsocket() throws InterruptedException {
         getTransportSelect().selectByText("Websocket");

diff --git a/uitest/src/test/java/com/vaadin/tests/push/ReconnectLongPollingTest.java b/uitest/src/test/java/com/vaadin/tests/push/ReconnectLongPollingTest.java
index 1f0e904cdc0dbfe39b2296e0b3d6bdcb41b9cf14..6ac0da840d027137472116b8ae7d1fa095bd89c8 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/push/ReconnectLongPollingTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/push/ReconnectLongPollingTest.java
@@ -1,20 +1,7 @@
 package com.vaadin.tests.push;
 
-import java.util.List;
-
-import org.openqa.selenium.remote.DesiredCapabilities;
-
 public class ReconnectLongPollingTest extends ReconnectTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-
-        // PhantomJS doesn't seem to detect disconnection on
-        // Long-Polling/Streaming:
-        // https://github.com/ariya/phantomjs/issues/11938
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Override
     protected Class<?> getUIClass() {
         return BasicPushLongPolling.class;

diff --git a/uitest/src/test/java/com/vaadin/tests/push/ReconnectStreamingTest.java b/uitest/src/test/java/com/vaadin/tests/push/ReconnectStreamingTest.java
index bc2318e2cea0fdd67b381e0899b1a44047c33548..c70a806d2c9497fd5376215f2d7943d04cf2596d 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/push/ReconnectStreamingTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/push/ReconnectStreamingTest.java
@@ -1,20 +1,6 @@
 package com.vaadin.tests.push;
 
-import java.util.List;
-
-import org.openqa.selenium.remote.DesiredCapabilities;
-
 public class ReconnectStreamingTest extends ReconnectTest {
-
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-
-        // PhantomJS doesn't seem to detect disconnection on
-        // Long-Polling/Streaming:
-        // https://github.com/ariya/phantomjs/issues/11938
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Override
     protected Class<?> getUIClass() {
         return BasicPushStreaming.class;

diff --git a/uitest/src/test/java/com/vaadin/tests/push/ReconnectWebsocketTest.java b/uitest/src/test/java/com/vaadin/tests/push/ReconnectWebsocketTest.java
index 4ed74f914a9681c1db8e746e8bf77214921573d5..52b5b284665286b98bf9c8903af1a8c1357625bd 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/push/ReconnectWebsocketTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/push/ReconnectWebsocketTest.java
@@ -1,16 +1,7 @@
 package com.vaadin.tests.push;
 
-import java.util.List;
-
-import org.openqa.selenium.remote.DesiredCapabilities;
-
 public class ReconnectWebsocketTest extends ReconnectTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingWebSocket();
-    }
-
     @Override
     protected Class<?> getUIClass() {
         return BasicPushWebsocket.class;

diff --git a/uitest/src/test/java/com/vaadin/tests/push/RefreshCloseConnectionTest.java b/uitest/src/test/java/com/vaadin/tests/push/RefreshCloseConnectionTest.java
index c175385d567f9f65049f4d6a51955e3705a89161..27641fc3558a400530ca05449ca5d53a2f903019 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/push/RefreshCloseConnectionTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/push/RefreshCloseConnectionTest.java
@@ -2,10 +2,7 @@ package com.vaadin.tests.push;
 
 import static org.junit.Assert.assertEquals;
 
-import java.util.List;
-
 import org.junit.Test;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.parallel.TestCategory;
 import com.vaadin.tests.tb3.MultiBrowserTest;
@@ -24,9 +21,4 @@ public class RefreshCloseConnectionTest extends MultiBrowserTest {
         assertEquals("2. Refresh", getLogRow(1));
         assertEquals("3. Push", getLogRow(0));
     }
-
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingWebSocket();
-    }
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/push/SendMultibyteCharactersWebSocketTest.java b/uitest/src/test/java/com/vaadin/tests/push/SendMultibyteCharactersWebSocketTest.java
index f898d74f71fc349285d979773d01801359df2515..bedd2da5c8349f4ca40dc27c59c622d26171948d 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/push/SendMultibyteCharactersWebSocketTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/push/SendMultibyteCharactersWebSocketTest.java
@@ -1,17 +1,8 @@
 package com.vaadin.tests.push;
 
-import java.util.List;
-
-import org.openqa.selenium.remote.DesiredCapabilities;
-
 public class SendMultibyteCharactersWebSocketTest
         extends SendMultibyteCharactersTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingWebSocket();
-    }
-
     @Override
     protected String getTransport() {
         return "websocket";

diff --git a/uitest/src/test/java/com/vaadin/tests/resources/FrontendInitialResourceUITest.java b/uitest/src/test/java/com/vaadin/tests/resources/FrontendInitialResourceUITest.java
index a387b89486dc21bb9139e0e2ea747f84714a80f9..7f2748461c6b3636b875c6e8a8aa27eadfdf3691 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/resources/FrontendInitialResourceUITest.java
+++ b/uitest/src/test/java/com/vaadin/tests/resources/FrontendInitialResourceUITest.java
@@ -1,24 +1,15 @@
 package com.vaadin.tests.resources;
 
-import java.util.List;
-
 import static org.junit.Assert.assertEquals;
 
 import org.junit.Test;
 import org.openqa.selenium.By;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.testbench.parallel.BrowserUtil;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class FrontendInitialResourceUITest extends MultiBrowserTest {
 
-    @Override
-    protected List<DesiredCapabilities> getBrowserCapabilities(Browser... browsers) {
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void correctEs5Es6FileImportedThroughFrontend() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/resources/FrontendLaterLoadedResourceUITest.java b/uitest/src/test/java/com/vaadin/tests/resources/FrontendLaterLoadedResourceUITest.java
index 2f3223317f8ff1fa6c911528f7a236e42725bc9a..36f70948a4f7c66ba270a3fb110300554691796d 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/resources/FrontendLaterLoadedResourceUITest.java
+++ b/uitest/src/test/java/com/vaadin/tests/resources/FrontendLaterLoadedResourceUITest.java
@@ -1,25 +1,15 @@
 package com.vaadin.tests.resources;
 
-import java.util.List;
-
 import static org.junit.Assert.assertEquals;
 
 import org.junit.Test;
 import org.openqa.selenium.By;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.ButtonElement;
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.testbench.parallel.BrowserUtil;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class FrontendLaterLoadedResourceUITest extends MultiBrowserTest {
-
-    @Override
-    protected List<DesiredCapabilities> getBrowserCapabilities(Browser... browsers) {
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void correctEs5Es6FileImportedThroughFrontend() {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/serialization/SerializerTestTest.java b/uitest/src/test/java/com/vaadin/tests/serialization/SerializerTestTest.java
index 60062af62bea7ae375a0f149f530e0ce8630ba03..eece869929f0154bd5cf6465deebf8efad147f00 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/serialization/SerializerTestTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/serialization/SerializerTestTest.java
@@ -3,21 +3,16 @@ package com.vaadin.tests.serialization;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 
-import java.text.DateFormat;
 import java.text.SimpleDateFormat;
 import java.util.Arrays;
 import java.util.Date;
-import java.util.List;
 import java.util.Locale;
 import java.util.TimeZone;
 import java.util.stream.Collectors;
 
 import org.junit.Test;
 import org.openqa.selenium.JavascriptExecutor;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
-import com.vaadin.testbench.annotations.RunLocally;
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class SerializerTestTest extends MultiBrowserTest {
@@ -25,12 +20,6 @@ public class SerializerTestTest extends MultiBrowserTest {
     private static final SimpleDateFormat FORMAT = new SimpleDateFormat(
             "EEE MMM dd HH:mm:ss 'GMT'Z yyyy", new Locale("en", "fi"));
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // IE11 and PhantomJS don't support getting timezone
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void testSerialization() {
         // Set up formatting with browsers timezone

diff --git a/uitest/src/test/java/com/vaadin/tests/tb3/AbstractTB3Test.java b/uitest/src/test/java/com/vaadin/tests/tb3/AbstractTB3Test.java
index 72cccbe27259c1fc7e2c430b3c7251edbc945090..768624f3dcc0e70248f4877dbf7e20a1b29bd0eb 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/tb3/AbstractTB3Test.java
+++ b/uitest/src/test/java/com/vaadin/tests/tb3/AbstractTB3Test.java
@@ -25,7 +25,6 @@ import org.apache.http.HttpResponse;
 import org.apache.http.impl.client.DefaultHttpClient;
 import org.apache.http.message.BasicHttpEntityEnclosingRequest;
 import org.junit.Rule;
-import org.junit.rules.ExternalResource;
 import org.junit.rules.TestName;
 import org.junit.runner.Description;
 import org.junit.runner.RunWith;
@@ -115,15 +114,6 @@ public abstract class AbstractTB3Test extends ParallelTest {
      */
     private static final int BROWSER_TIMEOUT_IN_MS = 30 * 1000;
 
-    protected static DesiredCapabilities PHANTOMJS2() {
-        DesiredCapabilities phantomjs2 = new VaadinBrowserFactory()
-                .create(Browser.PHANTOMJS, "2");
-        // Hack for the test cluster
-        phantomjs2.setCapability("phantomjs.binary.path",
-                "/usr/bin/phantomjs2");
-        return phantomjs2;
-    }
-
     private boolean debug = false;
 
     private boolean push = false;

diff --git a/uitest/src/test/java/com/vaadin/tests/tb3/BrowserStackBrowserFactory.java b/uitest/src/test/java/com/vaadin/tests/tb3/BrowserStackBrowserFactory.java
index 69f0467c8cdb80242e5ba5321e4b32649a2e0b05..05bf9e4c8938095839730dafb2a55d49bd6fb5f6 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/tb3/BrowserStackBrowserFactory.java
+++ b/uitest/src/test/java/com/vaadin/tests/tb3/BrowserStackBrowserFactory.java
@@ -6,7 +6,6 @@ import org.openqa.selenium.Platform;
 import org.openqa.selenium.ie.InternetExplorerDriver;
 import org.openqa.selenium.remote.DesiredCapabilities;
 
-import com.vaadin.shared.Version;
 import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.testbench.parallel.DefaultBrowserFactory;
 

diff --git a/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserTest.java b/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserTest.java
index 1febf9d9525c81732dedd7763a6f8d71d3b84f47..eca7ee35653bae07c68df635f4ad1655905f62c4 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserTest.java
@@ -25,27 +25,16 @@ import com.vaadin.testbench.parallel.Browser;
  */
 public abstract class MultiBrowserTest extends PrivateTB3Configuration {
 
-    protected List<DesiredCapabilities> getBrowsersSupportingWebSocket() {
-        // No WebSocket support in PhantomJS 1
-        return getBrowserCapabilities(Browser.IE11, Browser.FIREFOX,
-                Browser.CHROME);
-    }
-
-    protected List<DesiredCapabilities> getBrowsersExcludingPhantomJS() {
-        return getBrowserCapabilities(Browser.IE11, Browser.CHROME,
-                Browser.FIREFOX);
+    protected List<DesiredCapabilities> getBrowsersExcludingChrome() {
+        return getBrowserCapabilities(Browser.FIREFOX, Browser.IE11);
     }
 
     protected List<DesiredCapabilities> getBrowsersExcludingIE() {
-        return getBrowserCapabilities(Browser.FIREFOX, Browser.CHROME,
-                Browser.PHANTOMJS);
+        return getBrowserCapabilities(Browser.FIREFOX, Browser.CHROME);
     }
 
     protected List<DesiredCapabilities> getBrowsersExcludingFirefox() {
-        // this is sometimes needed as the Firefox driver causes extra mouseOut
-        // events that make tooltips disappear etc.
-        return getBrowserCapabilities(Browser.IE11, Browser.CHROME,
-                Browser.PHANTOMJS);
+        return getBrowserCapabilities(Browser.IE11, Browser.CHROME);
     }
 
     protected List<DesiredCapabilities> getBrowsersSupportingShiftClick() {
@@ -56,12 +45,6 @@ public abstract class MultiBrowserTest extends PrivateTB3Configuration {
         return getBrowserCapabilities(Browser.IE11);
     }
 
-    protected List<DesiredCapabilities> getBrowsersSupportingContextMenu() {
-        // context menu doesn't work in phantom JS
-        return getBrowserCapabilities(Browser.IE11, Browser.FIREFOX,
-                Browser.CHROME);
-    }
-
     protected List<DesiredCapabilities> getBrowsersSupportingTooltip() {
         // With IEDriver, the cursor seems to jump to default position after the
         // mouse move, so we are not able to test the tooltip behavior properly
@@ -70,13 +53,13 @@ public abstract class MultiBrowserTest extends PrivateTB3Configuration {
         // On Firefox, the driver causes additional mouseOut events causing the
         // tooltip to disappear immediately. Tooltips may work in some
         // particular cases, but not in general.
-        return getBrowserCapabilities(Browser.CHROME, Browser.PHANTOMJS);
+        return getBrowserCapabilities(Browser.CHROME);
     }
 
     @Override
     public List<DesiredCapabilities> getBrowsersToTest() {
         return getBrowserCapabilities(Browser.IE11, Browser.FIREFOX,
-                Browser.CHROME, Browser.PHANTOMJS);
+                Browser.CHROME);
     }
 
     protected List<DesiredCapabilities> getBrowserCapabilities(

diff --git a/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserThemeTest.java b/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserThemeTest.java
index ab9758f6480921b9732b74f885e88c25c0c0913b..95cf55f09ff38bf86fa0c1f64bc351598c775ffb 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserThemeTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserThemeTest.java
@@ -9,7 +9,6 @@ import java.util.Set;
 
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized.Parameters;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 /**
  * Test which uses theme returned by {@link #getTheme()} for running the test
@@ -43,11 +42,4 @@ public abstract class MultiBrowserThemeTest extends MultiBrowserTest {
         params.add("theme=" + theme);
         super.openTestURL(uiClass, params.toArray(new String[params.size()]));
     }
-
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        List<DesiredCapabilities> browsersToTest = getBrowsersExcludingPhantomJS();
-        browsersToTest.add(PHANTOMJS2());
-        return browsersToTest;
-    }
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserThemeTestWithProxy.java b/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserThemeTestWithProxy.java
index 38f02e8c613361e5a775cde60033e6b9df24139b..78f5ca42e89dee6db62c655ea183113535ad514c 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserThemeTestWithProxy.java
+++ b/uitest/src/test/java/com/vaadin/tests/tb3/MultiBrowserThemeTestWithProxy.java
@@ -3,12 +3,10 @@ package com.vaadin.tests.tb3;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.HashSet;
-import java.util.List;
 import java.util.Set;
 
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized.Parameters;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 @RunWith(ParameterizedTB3Runner.class)
 public abstract class MultiBrowserThemeTestWithProxy
@@ -37,11 +35,4 @@ public abstract class MultiBrowserThemeTestWithProxy
         params.add("theme=" + theme);
         super.openTestURL(uiClass, params.toArray(new String[params.size()]));
     }
-
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        List<DesiredCapabilities> browsersToTest = getBrowsersExcludingPhantomJS();
-        browsersToTest.add(PHANTOMJS2());
-        return browsersToTest;
-    }
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/tb3/WebsocketTest.java b/uitest/src/test/java/com/vaadin/tests/tb3/WebsocketTest.java
index 73119557bc821ccbf4ad24a24a942378e0ded99a..35857d078aa4fbac579a8b9a4cf04f5090d063af 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/tb3/WebsocketTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/tb3/WebsocketTest.java
@@ -1,9 +1,5 @@
 package com.vaadin.tests.tb3;
 
-import java.util.List;
-
-import org.openqa.selenium.remote.DesiredCapabilities;
-
 import com.vaadin.testbench.parallel.TestCategory;
 
 /**
@@ -14,9 +10,4 @@ import com.vaadin.testbench.parallel.TestCategory;
  */
 @TestCategory("push")
 public abstract class WebsocketTest extends MultiBrowserTest {
-
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingWebSocket();
-    }
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/themes/LegacyComponentThemeChangeTest.java b/uitest/src/test/java/com/vaadin/tests/themes/LegacyComponentThemeChangeTest.java
index 950f7daa7389b237e88417ff0bea48431b860055..0151e31da7981006c6c0229081c86cdce43d44bb 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/themes/LegacyComponentThemeChangeTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/themes/LegacyComponentThemeChangeTest.java
@@ -15,7 +15,6 @@ import com.vaadin.testbench.elements.ComboBoxElement;
 import com.vaadin.testbench.elements.EmbeddedElement;
 import com.vaadin.testbench.elements.MenuBarElement;
 import com.vaadin.testbench.elements.TableElement;
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.testbench.parallel.BrowserUtil;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
@@ -23,14 +22,9 @@ public class LegacyComponentThemeChangeTest extends MultiBrowserTest {
 
     @Override
     public List<DesiredCapabilities> getBrowsersToTest() {
-        // Seems like stylesheet onload is not fired on PhantomJS
-        // https://github.com/ariya/phantomjs/issues/12332
-        List<DesiredCapabilities> l = getBrowsersExcludingPhantomJS();
-
         // For some reason, IE times out when trying to open the combobox,
         // #18341
-        l.remove(Browser.IE11.getDesiredCapabilities());
-        return l;
+        return getBrowsersExcludingIE();
     }
 
     @Test

diff --git a/uitest/src/test/java/com/vaadin/tests/themes/ThemeChangeOnTheFlyTest.java b/uitest/src/test/java/com/vaadin/tests/themes/ThemeChangeOnTheFlyTest.java
index 2f7ab3ab17b6f00ca839dfbc474037c8a2abebad..2f82d74b31236de4b66224385571ef625c3f072e 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/themes/ThemeChangeOnTheFlyTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/themes/ThemeChangeOnTheFlyTest.java
@@ -4,25 +4,16 @@ import static org.hamcrest.CoreMatchers.containsString;
 import static org.hamcrest.MatcherAssert.assertThat;
 
 import java.io.IOException;
-import java.util.List;
 
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.ButtonElement;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class ThemeChangeOnTheFlyTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // Seems like stylesheet onload is not fired on PhantomJS
-        // https://github.com/ariya/phantomjs/issues/12332
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void injectedStyleAndThemeChange() throws IOException {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/tests/themes/valo/ImmediateUploadTest.java b/uitest/src/test/java/com/vaadin/tests/themes/valo/ImmediateUploadTest.java
index 511c1a430cce8ad4b5b2de977dbe01f6bf3a9af9..d749997fa8cf95897434c9bc1c934370cc06b18d 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/themes/valo/ImmediateUploadTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/themes/valo/ImmediateUploadTest.java
@@ -77,9 +77,8 @@ public class ImmediateUploadTest extends MultiBrowserTest {
     }
 
     @Test
-    public void testAcceptAttribute()
-    {
+    public void testAcceptAttribute() {
         WebElement input = getUploadFileInput("immediateupload");
-        assertThat(input.getAttribute("accept"),is(TEST_MIME_TYPE));
+        assertThat(input.getAttribute("accept"), is(TEST_MIME_TYPE));
     }
 }

diff --git a/uitest/src/test/java/com/vaadin/tests/themes/valo/ValoThemeUITest.java b/uitest/src/test/java/com/vaadin/tests/themes/valo/ValoThemeUITest.java
index 9559b6246f8654a27787a8e0852d7bc5bd96be5a..6ab6f94aae9b24266eb0dbaef576a38becc593f4 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/themes/valo/ValoThemeUITest.java
+++ b/uitest/src/test/java/com/vaadin/tests/themes/valo/ValoThemeUITest.java
@@ -1,17 +1,13 @@
 package com.vaadin.tests.themes.valo;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.ButtonElement;
 import com.vaadin.testbench.elements.CheckBoxElement;
 import com.vaadin.testbench.elements.CssLayoutElement;
 import com.vaadin.testbench.elements.LabelElement;
-import com.vaadin.testbench.parallel.Browser;
 import com.vaadin.tests.tb3.MultiBrowserTest;
 import com.vaadin.v7.testbench.elements.TreeElement;
 
@@ -300,13 +296,4 @@ public class ValoThemeUITest extends MultiBrowserTest {
     protected boolean usePersistentHoverForIE() {
         return false;
     }
-
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        List<DesiredCapabilities> browsersToTest = getBrowserCapabilities(
-                Browser.IE11, Browser.FIREFOX, Browser.CHROME);
-        browsersToTest.add(PHANTOMJS2());
-        return browsersToTest;
-    }
-
 }

diff --git a/uitest/src/test/java/com/vaadin/v7/tests/components/grid/GridThemeChangeTest.java b/uitest/src/test/java/com/vaadin/v7/tests/components/grid/GridThemeChangeTest.java
index ed8e269f70e73c292e5d826605a890fe0909bc90..a0220e6764f3a5cfa1fed4b13959c87c0074cc45 100644 (file)
--- a/uitest/src/test/java/com/vaadin/v7/tests/components/grid/GridThemeChangeTest.java
+++ b/uitest/src/test/java/com/vaadin/v7/tests/components/grid/GridThemeChangeTest.java
@@ -2,10 +2,7 @@ package com.vaadin.v7.tests.components.grid;
 
 import static org.junit.Assert.assertTrue;
 
-import java.util.List;
-
 import org.junit.Test;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.GridElement;
 import com.vaadin.testbench.parallel.TestCategory;
@@ -13,12 +10,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
 
 @TestCategory("grid")
 public class GridThemeChangeTest extends MultiBrowserTest {
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // Seems like stylesheet onload is not fired on PhantomJS
-        // https://github.com/ariya/phantomjs/issues/12332
-        return super.getBrowsersExcludingPhantomJS();
-    }
 
     @Test
     public void testThemeChange() {

diff --git a/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/GridSortingIndicatorsTest.java b/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/GridSortingIndicatorsTest.java
index 2054c497f0a6eea4570d6b6875f0f6a97b5e20c1..ee92550bc5a742d27d1b90fddc53b8380d57d7b2 100644 (file)
--- a/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/GridSortingIndicatorsTest.java
+++ b/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/GridSortingIndicatorsTest.java
@@ -1,10 +1,8 @@
 package com.vaadin.v7.tests.components.grid.basicfeatures;
 
 import java.io.IOException;
-import java.util.List;
 
 import org.junit.Test;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.elements.ButtonElement;
 import com.vaadin.testbench.parallel.TestCategory;
@@ -13,13 +11,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
 @TestCategory("grid")
 public class GridSortingIndicatorsTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        List<DesiredCapabilities> browsers = getBrowsersExcludingPhantomJS();
-        browsers.add(PHANTOMJS2());
-        return browsers;
-    }
-
     @Test
     public void testSortingIndicators() throws IOException {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/client/GridClientContextMenuEventTest.java b/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/client/GridClientContextMenuEventTest.java
index 3d8d9aa22cce408fc533a97ad456d47125ea647b..0f64105b0674ca684b1afad60e6efc975181b49d 100644 (file)
--- a/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/client/GridClientContextMenuEventTest.java
+++ b/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/client/GridClientContextMenuEventTest.java
@@ -2,24 +2,15 @@ package com.vaadin.v7.tests.components.grid.basicfeatures.client;
 
 import static org.junit.Assert.assertTrue;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.v7.tests.components.grid.basicfeatures.GridBasicClientFeaturesTest;
 
 public class GridClientContextMenuEventTest
         extends GridBasicClientFeaturesTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // PhantomJS doesn't support context click..
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void testContextMenuEventIsHandledCorrectly() {
         setDebug(true);

diff --git a/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/server/GridSidebarThemeTest.java b/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/server/GridSidebarThemeTest.java
index 2fc0cce68fa54577f5aad46c6d15eb2a4ff17214..0ddf80e2e0f8f7d6da598140349fe589b4b93dca 100644 (file)
--- a/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/server/GridSidebarThemeTest.java
+++ b/uitest/src/test/java/com/vaadin/v7/tests/components/grid/basicfeatures/server/GridSidebarThemeTest.java
@@ -1,11 +1,9 @@
 package com.vaadin.v7.tests.components.grid.basicfeatures.server;
 
 import java.io.IOException;
-import java.util.List;
 
 import org.junit.Test;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.v7.tests.components.grid.basicfeatures.GridBasicFeaturesTest;
 import com.vaadin.v7.tests.components.grid.basicfeatures.GridSidebarFeatures;
@@ -60,10 +58,4 @@ public class GridSidebarThemeTest extends GridBasicFeaturesTest {
 
         compareScreen(theme + "-SidebarClosed2");
     }
-
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // phantom JS looks wrong from the beginning, so not tested
-        return getBrowsersExcludingPhantomJS();
-    }
 }

diff --git a/uitest/src/test/java/com/vaadin/v7/tests/components/tree/TreeContextMenuAndIconsTest.java b/uitest/src/test/java/com/vaadin/v7/tests/components/tree/TreeContextMenuAndIconsTest.java
index be69425560461278fcaadd5df8491c89cf2c3629..391b953f75a011f3e1d16cdb05e3743abd6d955b 100644 (file)
--- a/uitest/src/test/java/com/vaadin/v7/tests/components/tree/TreeContextMenuAndIconsTest.java
+++ b/uitest/src/test/java/com/vaadin/v7/tests/components/tree/TreeContextMenuAndIconsTest.java
@@ -2,13 +2,10 @@ package com.vaadin.v7.tests.components.tree;
 
 import static org.junit.Assert.assertEquals;
 
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.Dimension;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
-import org.openqa.selenium.remote.DesiredCapabilities;
 
 import com.vaadin.testbench.By;
 import com.vaadin.tests.tb3.MultiBrowserTest;
@@ -20,11 +17,6 @@ public class TreeContextMenuAndIconsTest extends MultiBrowserTest {
         return Trees.class;
     }
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        return getBrowsersSupportingContextMenu();
-    }
-
     @Test
     public void testSimpleContextMenu() throws Exception {
         openTestURL();

diff --git a/uitest/src/test/java/com/vaadin/v7/tests/components/upload/TestFileUploadTest.java b/uitest/src/test/java/com/vaadin/v7/tests/components/upload/TestFileUploadTest.java
index 2a655e02a698c524b308e2ba50af1d991cf63a19..e1d4058904edee000afd51d6e3f32ba2c28aae6b 100644 (file)
--- a/uitest/src/test/java/com/vaadin/v7/tests/components/upload/TestFileUploadTest.java
+++ b/uitest/src/test/java/com/vaadin/v7/tests/components/upload/TestFileUploadTest.java
@@ -9,13 +9,11 @@ import java.io.IOException;
 import java.math.BigInteger;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
-import java.util.List;
 
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.internal.WrapsElement;
-import org.openqa.selenium.remote.DesiredCapabilities;
 import org.openqa.selenium.remote.LocalFileDetector;
 import org.openqa.selenium.remote.RemoteWebElement;
 
@@ -24,12 +22,6 @@ import com.vaadin.tests.tb3.MultiBrowserTest;
 
 public class TestFileUploadTest extends MultiBrowserTest {
 
-    @Override
-    public List<DesiredCapabilities> getBrowsersToTest() {
-        // PhantomJS fails to upload files for unknown reasons
-        return getBrowsersExcludingPhantomJS();
-    }
-
     @Test
     public void testUploadAnyFile() throws Exception {
         openTestURL();