]> source.dussan.org Git - sonarqube.git/commitdiff
Rename Visitor to ComponentVisitor 468/head
authorJulien Lancelot <julien.lancelot@sonarsource.com>
Fri, 7 Aug 2015 15:32:06 +0000 (17:32 +0200)
committerSébastien Lesaint <sebastien.lesaint@sonarsource.com>
Mon, 10 Aug 2015 12:18:19 +0000 (14:18 +0200)
46 files changed:
server/sonar-server/src/main/java/org/sonar/server/computation/component/ComponentVisitor.java [new file with mode: 0644]
server/sonar-server/src/main/java/org/sonar/server/computation/component/DepthTraversalTypeAwareCrawler.java
server/sonar-server/src/main/java/org/sonar/server/computation/component/PathAwareCrawler.java
server/sonar-server/src/main/java/org/sonar/server/computation/component/PathAwareVisitor.java
server/sonar-server/src/main/java/org/sonar/server/computation/component/PathAwareVisitorWrapper.java
server/sonar-server/src/main/java/org/sonar/server/computation/component/TreeRootHolderImpl.java
server/sonar-server/src/main/java/org/sonar/server/computation/component/TypeAwareVisitor.java
server/sonar-server/src/main/java/org/sonar/server/computation/component/TypeAwareVisitorWrapper.java
server/sonar-server/src/main/java/org/sonar/server/computation/component/Visitor.java [deleted file]
server/sonar-server/src/main/java/org/sonar/server/computation/component/VisitorsCrawler.java
server/sonar-server/src/main/java/org/sonar/server/computation/container/ComputeEngineContainer.java
server/sonar-server/src/main/java/org/sonar/server/computation/container/ComputeEngineContainerImpl.java
server/sonar-server/src/main/java/org/sonar/server/computation/formula/FormulaExecutorComponentCrawler.java
server/sonar-server/src/main/java/org/sonar/server/computation/measure/MeasureComputersVisitor.java
server/sonar-server/src/main/java/org/sonar/server/computation/sqale/SqaleMeasuresVisitor.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/ComponentVisitors.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/ComputeQProfileMeasureStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/CustomMeasuresCopyStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/ExecuteVisitorsStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/FillMeasuresWithVariationsStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/IntegrateIssuesStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistDuplicationsStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistEventsStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistFileSourcesStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistMeasuresStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistNumberOfDaysSinceLastCommitStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistProjectLinksStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistTestsStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityGateEventsStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityGateLoadingStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityGateMeasuresStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityProfileEventsStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/SizeMeasuresStep.java
server/sonar-server/src/main/java/org/sonar/server/computation/step/ValidateProjectStep.java
server/sonar-server/src/test/java/org/sonar/server/computation/batch/TreeRootHolderRule.java
server/sonar-server/src/test/java/org/sonar/server/computation/component/PathAwareCrawlerTest.java
server/sonar-server/src/test/java/org/sonar/server/computation/component/PostOrderDepthTraversalTypeAwareCrawlerTest.java
server/sonar-server/src/test/java/org/sonar/server/computation/component/PreOrderDepthTraversalTypeAwareCrawlerTest.java
server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerTest.java
server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerWithPathAwareVisitorTest.java
server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerWithPostOrderTypeAwareVisitorTest.java
server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerWithPreOrderTypeAwareVisitorTest.java
server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureComputersVisitorTest.java
server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureRepositoryRule.java
server/sonar-server/src/test/java/org/sonar/server/computation/sqale/SqaleMeasuresVisitorTest.java
server/sonar-server/src/test/java/org/sonar/server/computation/step/ExecuteVisitorsStepTest.java

diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/component/ComponentVisitor.java b/server/sonar-server/src/main/java/org/sonar/server/computation/component/ComponentVisitor.java
new file mode 100644 (file)
index 0000000..e24d7ef
--- /dev/null
@@ -0,0 +1,42 @@
+/*
+ * SonarQube, open source software quality management tool.
+ * Copyright (C) 2008-2014 SonarSource
+ * mailto:contact AT sonarsource DOT com
+ *
+ * SonarQube is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * SonarQube is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+package org.sonar.server.computation.component;
+
+public interface ComponentVisitor {
+
+  Order getOrder();
+
+  Component.Type getMaxDepth();
+
+  enum Order {
+    /**
+     * Each component is visited BEFORE its children. Top-down traversal of
+     * tree of components.
+     */
+    PRE_ORDER,
+
+    /**
+     * Each component is visited AFTER its children. Bottom-up traversal of
+     * tree of components.
+     */
+    POST_ORDER
+  }
+}
index 5557e22c38d2b8bd4a1d5eb56f3fe607673a591f..e629528dcdbcc56a7593894b46eae48b9c3103d2 100644 (file)
@@ -29,9 +29,9 @@ import static java.util.Objects.requireNonNull;
  */
 public abstract class DepthTraversalTypeAwareCrawler implements TypeAwareCrawler {
   private final Component.Type maxDepth;
-  private final Visitor.Order order;
+  private final ComponentVisitor.Order order;
 
-  protected DepthTraversalTypeAwareCrawler(Component.Type maxDepth, Visitor.Order order) {
+  protected DepthTraversalTypeAwareCrawler(Component.Type maxDepth, ComponentVisitor.Order order) {
     this.maxDepth = requireNonNull(maxDepth);
     this.order = requireNonNull(order);
   }
@@ -42,13 +42,13 @@ public abstract class DepthTraversalTypeAwareCrawler implements TypeAwareCrawler
       return;
     }
 
-    if (order == Visitor.Order.PRE_ORDER) {
+    if (order == ComponentVisitor.Order.PRE_ORDER) {
       visitNode(component);
     }
 
     visitChildren(component);
 
-    if (order == Visitor.Order.POST_ORDER) {
+    if (order == ComponentVisitor.Order.POST_ORDER) {
       visitNode(component);
     }
   }
index c73e78c355d1b09c3eb268022e6f8417b4a4d09a..d0a0d7e27f07c1b6b2bb637bdd5bd12504182780 100644 (file)
@@ -19,8 +19,8 @@
  */
 package org.sonar.server.computation.component;
 
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 /**
  * A {@link ComponentCrawler} which provide access to a representation of the path from the root to the currently visited
@@ -32,7 +32,7 @@ public abstract class PathAwareCrawler<T> extends PathAwareVisitorAdapter<T> imp
 
   private final DequeBasedPath<T> stack = new DequeBasedPath<>();
 
-  public PathAwareCrawler(Component.Type maxDepth, Visitor.Order order, StackElementFactory<T> factory) {
+  public PathAwareCrawler(Component.Type maxDepth, ComponentVisitor.Order order, StackElementFactory<T> factory) {
     super(maxDepth, order, factory);
   }
 
index 3c4473fe21bafa37c9abda1fb78230099afb96a7..1dd23d7b6ac08b60161180ca3deba3211c8c1fbc 100644 (file)
@@ -23,11 +23,11 @@ package org.sonar.server.computation.component;
 import java.util.NoSuchElementException;
 
 /**
- * A {@link Visitor} which provide access to a representation of the path from the root to the currently visited
+ * A {@link ComponentVisitor} which provide access to a representation of the path from the root to the currently visited
  * Component. It also provides a way to have an object associated to each Component and access it and all of its
  * parent's.
  */
-public interface PathAwareVisitor<T> extends Visitor {
+public interface PathAwareVisitor<T> extends ComponentVisitor {
 
   StackElementFactory<T> getFactory();
 
index ba36b285aeb0fa8830e291be0dc6712fa080dc5b..101932dbae4ec15c24cc8bf76ba287275b776379 100644 (file)
@@ -66,7 +66,7 @@ public class PathAwareVisitorWrapper<T> implements VisitorWrapper {
   }
 
   @Override
-  public Visitor.Order getOrder() {
+  public ComponentVisitor.Order getOrder() {
     return delegate.getOrder();
   }
 
index 11337d9ee3ec324e4003afc3eda81c7639f8b67b..edd7124819e4270c8d6a04979e905b1924eea6b0 100644 (file)
@@ -23,7 +23,7 @@ import java.util.HashMap;
 import java.util.Map;
 import java.util.Objects;
 
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
 
 /**
  * Holds the reference to the root of the {@link Component} tree for the current CE run.
index 180ad426ff1d4bffdef06a3746a2c3db1dbdbf61..d49db4b8f895501516e07c571fb187b8c8aa610c 100644 (file)
@@ -21,9 +21,9 @@
 package org.sonar.server.computation.component;
 
 /**
- * A {@link Visitor} which can exposes methods which ensure the type of the visited Component.
+ * A {@link ComponentVisitor} which can exposes methods which ensure the type of the visited Component.
  */
-public interface TypeAwareVisitor extends Visitor {
+public interface TypeAwareVisitor extends ComponentVisitor {
   /**
    * Called when encountering a Component of type {@link Component.Type#PROJECT}
    */
index fb28c9b972ad5f00dbb4ad89cb5c80df21764d20..814cb8a0370b0fc71272178c0913bec06a19501f 100644 (file)
@@ -64,7 +64,7 @@ public class TypeAwareVisitorWrapper implements VisitorWrapper {
   }
 
   @Override
-  public Visitor.Order getOrder() {
+  public ComponentVisitor.Order getOrder() {
     return delegate.getOrder();
   }
 
diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/component/Visitor.java b/server/sonar-server/src/main/java/org/sonar/server/computation/component/Visitor.java
deleted file mode 100644 (file)
index 017d597..0000000
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- * SonarQube, open source software quality management tool.
- * Copyright (C) 2008-2014 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * SonarQube is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * SonarQube is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
- */
-
-package org.sonar.server.computation.component;
-
-public interface Visitor {
-
-  Order getOrder();
-
-  Component.Type getMaxDepth();
-
-  enum Order {
-    /**
-     * Each component is visited BEFORE its children. Top-down traversal of
-     * tree of components.
-     */
-    PRE_ORDER,
-
-    /**
-     * Each component is visited AFTER its children. Bottom-up traversal of
-     * tree of components.
-     */
-    POST_ORDER
-  }
-}
index 134ff9f8b48dee7981b1550c0e2b51c2ed9a5177..c3b4f4b9ac3bf336a81edf00426ad69806c8893a 100644 (file)
@@ -36,7 +36,7 @@ public class VisitorsCrawler implements ComponentCrawler {
   private final List<VisitorWrapper> preOrderVisitorWrappers;
   private final List<VisitorWrapper> postOrderVisitorWrappers;
 
-  public VisitorsCrawler(Iterable<Visitor> visitors) {
+  public VisitorsCrawler(Iterable<ComponentVisitor> visitors) {
     List<VisitorWrapper> visitorWrappers = from(visitors).transform(ToVisitorWrapper.INSTANCE).toList();
     this.preOrderVisitorWrappers = from(visitorWrappers).filter(MathPreOrderVisitor.INSTANCE).toList();
     this.postOrderVisitorWrappers = from(visitorWrappers).filter(MatchPostOrderVisitor.INSTANCE).toList();
@@ -95,15 +95,15 @@ public class VisitorsCrawler implements ComponentCrawler {
     }
   }
 
-  private enum ToVisitorWrapper implements Function<Visitor, VisitorWrapper> {
+  private enum ToVisitorWrapper implements Function<ComponentVisitor, VisitorWrapper> {
     INSTANCE;
 
     @Override
-    public VisitorWrapper apply(@Nonnull Visitor visitor) {
-      if (visitor instanceof TypeAwareVisitor) {
-        return new TypeAwareVisitorWrapper((TypeAwareVisitor) visitor);
-      } else if (visitor instanceof PathAwareVisitor) {
-        return new PathAwareVisitorWrapper((PathAwareVisitor) visitor);
+    public VisitorWrapper apply(@Nonnull ComponentVisitor componentVisitor) {
+      if (componentVisitor instanceof TypeAwareVisitor) {
+        return new TypeAwareVisitorWrapper((TypeAwareVisitor) componentVisitor);
+      } else if (componentVisitor instanceof PathAwareVisitor) {
+        return new PathAwareVisitorWrapper((PathAwareVisitor) componentVisitor);
       } else {
         throw new IllegalArgumentException("Only TypeAwareVisitor and PathAwareVisitor can be used");
       }
@@ -128,7 +128,7 @@ public class VisitorsCrawler implements ComponentCrawler {
 
     @Override
     public boolean apply(@Nonnull VisitorWrapper visitorWrapper) {
-      return visitorWrapper.getOrder() == Visitor.Order.PRE_ORDER;
+      return visitorWrapper.getOrder() == ComponentVisitor.Order.PRE_ORDER;
     }
   }
 
@@ -137,7 +137,7 @@ public class VisitorsCrawler implements ComponentCrawler {
 
     @Override
     public boolean apply(@Nonnull VisitorWrapper visitorWrapper) {
-      return visitorWrapper.getOrder() == Visitor.Order.POST_ORDER;
+      return visitorWrapper.getOrder() == ComponentVisitor.Order.POST_ORDER;
     }
   }
 }
index 742d898059d12ca2cb15f5fc0d7e4fd9a7bca21b..f931517d94e114d9fedfdae934a5ddb57ff91718 100644 (file)
@@ -21,7 +21,7 @@ package org.sonar.server.computation.container;
 
 import org.sonar.core.platform.ComponentContainer;
 import org.sonar.server.computation.ReportQueue.Item;
-import org.sonar.server.computation.component.Visitor;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.step.ComputationStep;
 
 /**
@@ -46,7 +46,7 @@ public interface ComputeEngineContainer {
    */
   <T extends ComputationStep> T getStep(Class<T> type);
 
-  <T extends Visitor> T getComponentVisitor(Class<T> type);
+  <T extends ComponentVisitor> T getComponentVisitor(Class<T> type);
 
 
 }
index add42ca7f7181167aeaf79badf03eb833e2bcdf9..2d2ca9fef80e993bdfd0c1b3b08d630c1d7cdd2b 100644 (file)
@@ -43,10 +43,10 @@ import org.sonar.server.computation.ReportQueue;
 import org.sonar.server.computation.activity.ActivityManager;
 import org.sonar.server.computation.batch.BatchReportDirectoryHolderImpl;
 import org.sonar.server.computation.batch.BatchReportReaderImpl;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.DbIdsRepository;
 import org.sonar.server.computation.component.ProjectSettingsRepository;
 import org.sonar.server.computation.component.TreeRootHolderImpl;
-import org.sonar.server.computation.component.Visitor;
 import org.sonar.server.computation.debt.DebtModelHolderImpl;
 import org.sonar.server.computation.event.EventRepositoryImpl;
 import org.sonar.server.computation.issue.BaseIssuesLoader;
@@ -274,7 +274,7 @@ public class ComputeEngineContainerImpl extends ComponentContainer implements Co
   }
 
   @Override
-  public <T extends Visitor> T getComponentVisitor(Class<T> type) {
+  public <T extends ComponentVisitor> T getComponentVisitor(Class<T> type) {
     return getComponentByType(type);
   }
 
index 9b86cec3a3015e700da50deff52a95033842f83f..ceb690538795bcef831e955b9d547354defed43f 100644 (file)
@@ -26,8 +26,8 @@ import java.util.List;
 import java.util.Map;
 import javax.annotation.CheckForNull;
 import org.sonar.server.computation.component.Component;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.PathAwareCrawler;
-import org.sonar.server.computation.component.Visitor;
 import org.sonar.server.computation.measure.Measure;
 import org.sonar.server.computation.measure.MeasureRepository;
 import org.sonar.server.computation.metric.Metric;
@@ -59,7 +59,7 @@ public class FormulaExecutorComponentCrawler extends PathAwareCrawler<FormulaExe
   private final List<Formula> formulas;
 
   private FormulaExecutorComponentCrawler(Builder builder, List<Formula> formulas) {
-    super(Component.Type.FILE, Visitor.Order.POST_ORDER, COUNTERS_FACTORY);
+    super(Component.Type.FILE, ComponentVisitor.Order.POST_ORDER, COUNTERS_FACTORY);
     this.periodsHolder = builder.periodsHolder;
     this.measureRepository = builder.measureRepository;
     this.metricRepository = builder.metricRepository;
index e0e105a547f4f5032d148ed6546ba3e670290f2e..488b09d5c63d6389f6f427fb202bfafa2cc9c903 100644 (file)
@@ -27,7 +27,7 @@ import org.sonar.server.computation.measure.api.MeasureComputerImplementationCon
 import org.sonar.server.computation.metric.MetricRepository;
 
 import static org.sonar.server.computation.component.Component.Type.FILE;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 public class MeasureComputersVisitor extends TypeAwareVisitorAdapter {
 
index 8a9170a24763b6c01ea02968949a0f8d36809fa6..cd12577cd2bbdc7b34d8108b02e0cff4997e0865 100644 (file)
@@ -23,8 +23,8 @@ package org.sonar.server.computation.sqale;
 import com.google.common.base.Optional;
 import org.sonar.api.measures.CoreMetrics;
 import org.sonar.server.computation.component.Component;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.PathAwareVisitorAdapter;
-import org.sonar.server.computation.component.Visitor;
 import org.sonar.server.computation.measure.Measure;
 import org.sonar.server.computation.measure.MeasureRepository;
 import org.sonar.server.computation.metric.Metric;
@@ -44,7 +44,7 @@ public class SqaleMeasuresVisitor extends PathAwareVisitorAdapter<SqaleMeasuresV
   private final Metric sqaleRatingMetric;
 
   public SqaleMeasuresVisitor(MetricRepository metricRepository, MeasureRepository measureRepository, SqaleRatingSettings sqaleRatingSettings) {
-    super(Component.Type.FILE, Visitor.Order.POST_ORDER, new SimpleStackElementFactory<DevelopmentCost>() {
+    super(Component.Type.FILE, ComponentVisitor.Order.POST_ORDER, new SimpleStackElementFactory<DevelopmentCost>() {
       @Override
       public DevelopmentCost createForAny(Component component) {
         return new DevelopmentCost();
index 34257d49906a27f6ed823bbf94be6ebe499d23f7..64b9b64bea14dc36f5bb560fb093144125c30fb2 100644 (file)
@@ -26,7 +26,7 @@ import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Iterables;
 import java.util.List;
 import javax.annotation.Nonnull;
-import org.sonar.server.computation.component.Visitor;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.container.ComputeEngineContainer;
 import org.sonar.server.computation.measure.MeasureComputersVisitor;
 import org.sonar.server.computation.sqale.SqaleMeasuresVisitor;
@@ -36,7 +36,7 @@ import org.sonar.server.computation.sqale.SqaleMeasuresVisitor;
  */
 public class ComponentVisitors {
 
-  private static final List<Class<? extends Visitor>> ORDERED_VISITOR_CLASSES = ImmutableList.of(
+  private static final List<Class<? extends ComponentVisitor>> ORDERED_VISITOR_CLASSES = ImmutableList.of(
     SqaleMeasuresVisitor.class,
 
     // Must be after all other visitors as it requires measures computed by previous visitors
@@ -44,9 +44,9 @@ public class ComponentVisitors {
   );
 
   /**
-   * List of all {@link Visitor}, ordered by execution sequence.
+   * List of all {@link ComponentVisitor}, ordered by execution sequence.
    */
-  public List<Class<? extends Visitor>> orderedClasses() {
+  public List<Class<? extends ComponentVisitor>> orderedClasses() {
     return ORDERED_VISITOR_CLASSES;
   }
 
@@ -56,13 +56,13 @@ public class ComponentVisitors {
     this.computeEngineContainer = computeEngineContainer;
   }
 
-  public Iterable<Visitor> instances() {
-    return Iterables.transform(orderedClasses(), new Function<Class<? extends Visitor>, Visitor>() {
+  public Iterable<ComponentVisitor> instances() {
+    return Iterables.transform(orderedClasses(), new Function<Class<? extends ComponentVisitor>, ComponentVisitor>() {
       @Override
-      public Visitor apply(@Nonnull Class<? extends Visitor> input) {
-        Visitor visitor = computeEngineContainer.getComponentVisitor(input);
-        Preconditions.checkState(visitor != null, String.format("Visitor not found: %s", input));
-        return visitor;
+      public ComponentVisitor apply(@Nonnull Class<? extends ComponentVisitor> input) {
+        ComponentVisitor componentVisitor = computeEngineContainer.getComponentVisitor(input);
+        Preconditions.checkState(componentVisitor != null, String.format("Visitor not found: %s", input));
+        return componentVisitor;
       }
     });
   }
index 1ba19ba8ec9bc72774200a2130b0ce831a538add..6ba2faed8ff3439d7f158251a831269fc763f530 100644 (file)
@@ -36,7 +36,7 @@ import org.sonar.server.computation.qualityprofile.QPMeasureData;
 import org.sonar.server.computation.qualityprofile.QualityProfile;
 
 import static org.sonar.server.computation.component.Component.Type.MODULE;
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
 
 /**
  * Aggregates quality profile on lower-level module nodes on their parent modules and project
index bc5e02d52e91053a6a2a491f8c34174fcd64e70f..ab5788e4848b47f9b88d8ff0e7557bc1bb38450b 100644 (file)
@@ -27,9 +27,9 @@ import org.sonar.db.DbSession;
 import org.sonar.db.MyBatis;
 import org.sonar.db.measure.custom.CustomMeasureDto;
 import org.sonar.server.computation.component.Component;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
 import org.sonar.server.computation.component.TreeRootHolder;
-import org.sonar.server.computation.component.Visitor;
 import org.sonar.server.computation.measure.Measure;
 import org.sonar.server.computation.measure.MeasureRepository;
 import org.sonar.server.computation.metric.Metric;
@@ -52,7 +52,7 @@ public class CustomMeasuresCopyStep implements ComputationStep {
 
   @Override
   public void execute() {
-    new DepthTraversalTypeAwareCrawler(Component.Type.FILE, Visitor.Order.PRE_ORDER) {
+    new DepthTraversalTypeAwareCrawler(Component.Type.FILE, ComponentVisitor.Order.PRE_ORDER) {
       @Override
       public void visitAny(Component component) {
         copy(component);
index 7d93a3e78299d5df335eb57c35734cddb181baa2..31137c5f607e5e28d6b53d1663675b02279e23ab 100644 (file)
 
 package org.sonar.server.computation.step;
 
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.TreeRootHolder;
-import org.sonar.server.computation.component.Visitor;
 import org.sonar.server.computation.component.VisitorsCrawler;
 
 public class ExecuteVisitorsStep implements ComputationStep {
   private final TreeRootHolder treeRootHolder;
-  private final Iterable<Visitor> visitors;
+  private final Iterable<ComponentVisitor> visitors;
 
   public ExecuteVisitorsStep(TreeRootHolder treeRootHolder, ComponentVisitors visitors) {
     this.treeRootHolder = treeRootHolder;
index b2a87eb2a6cff0534fcec17b9fc2f2971c0c42cd..cdd4a48173e0aef4eb84758495518d2e1a1075ee 100644 (file)
@@ -46,7 +46,7 @@ import org.sonar.server.computation.metric.MetricRepository;
 import org.sonar.server.computation.period.Period;
 import org.sonar.server.computation.period.PeriodsHolder;
 
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 /**
  * Set variations on all numeric measures found in the repository.
index 1e357c6b62452fa37ad278b55148fcf8564b2078..56184e7df992ae03c18e5de19a15d7fd5c4094e8 100644 (file)
@@ -36,7 +36,7 @@ import org.sonar.server.computation.issue.IssueVisitors;
 import org.sonar.server.computation.issue.TrackerExecution;
 import org.sonar.server.util.cache.DiskCache;
 
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
 
 public class IntegrateIssuesStep implements ComputationStep {
 
index 920dcbf13308cd37409b05c03fbd69764b31fd58..0f1149523478ed9f8137c9cb330f49ec863fe9f0 100644 (file)
@@ -36,7 +36,7 @@ import org.sonar.server.computation.component.DbIdsRepository;
 import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
 import org.sonar.server.computation.component.TreeRootHolder;
 
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 /**
  * Persist duplications into
index 152dd24c662fd9afe7a83e38bd75e695b3ad25d4..2fa50e978720a9e1f4e3a56efa29702847c6f83f 100644 (file)
@@ -29,10 +29,10 @@ import org.sonar.db.MyBatis;
 import org.sonar.db.event.EventDto;
 import org.sonar.server.computation.batch.BatchReportReader;
 import org.sonar.server.computation.component.Component;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.DbIdsRepository;
 import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
 import org.sonar.server.computation.component.TreeRootHolder;
-import org.sonar.server.computation.component.Visitor;
 import org.sonar.server.computation.event.Event;
 import org.sonar.server.computation.event.EventRepository;
 
@@ -139,7 +139,7 @@ public class PersistEventsStep implements ComputationStep {
     private final long analysisDate;
 
     public PersistEventComponentCrawler(DbSession session, long analysisDate) {
-      super(Component.Type.FILE, Visitor.Order.PRE_ORDER);
+      super(Component.Type.FILE, ComponentVisitor.Order.PRE_ORDER);
       this.session = session;
       this.analysisDate = analysisDate;
     }
index 0a188c1a4cdb97a2114a061854b676224160fc1d..f1b058ee6e65fbca1a8d44b8e2c8f4ffb9f17ee9 100644 (file)
@@ -49,7 +49,7 @@ import org.sonar.server.computation.source.LineReader;
 import org.sonar.server.computation.source.ScmLineReader;
 import org.sonar.server.computation.source.SymbolsLineReader;
 
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 public class PersistFileSourcesStep implements ComputationStep {
 
index 6cd01463a9bae8d1a188b8ddd876453558747359..7985bacda405f4ad964c689ff5e09bbc5b2df45d 100644 (file)
@@ -46,7 +46,7 @@ import static com.google.common.collect.FluentIterable.from;
 import static org.sonar.api.measures.CoreMetrics.CLASS_COMPLEXITY_DISTRIBUTION_KEY;
 import static org.sonar.api.measures.CoreMetrics.FILE_COMPLEXITY_DISTRIBUTION_KEY;
 import static org.sonar.api.measures.CoreMetrics.FUNCTION_COMPLEXITY_DISTRIBUTION_KEY;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 public class PersistMeasuresStep implements ComputationStep {
 
index e40475f2ef1a0d709942c2807375af215d182c21..2f2f59459d8fe5f9624b40e09f314fb2230a971d 100644 (file)
@@ -39,7 +39,7 @@ import org.sonar.server.computation.metric.MetricRepository;
 import org.sonar.server.source.index.SourceLineIndex;
 
 import static com.google.common.base.Objects.firstNonNull;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 public class PersistNumberOfDaysSinceLastCommitStep implements ComputationStep {
 
index d6c04562054891e9244d528e1cd84092ca921c74..3c5c8e3bce31a33e2d340b88d2eb73ad6d85eccc 100644 (file)
@@ -41,7 +41,7 @@ import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
 import org.sonar.server.computation.component.TreeRootHolder;
 
 import static com.google.common.collect.Sets.newHashSet;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 /**
  * Persist project and module links
index d3f27f950b80873cd047d6ca895bc846880d0b45..373717e58ec8a0f475278470ec7d69567b8f7268 100644 (file)
@@ -49,9 +49,9 @@ import org.sonar.db.source.FileSourceDto;
 import org.sonar.db.source.FileSourceDto.Type;
 import org.sonar.server.computation.batch.BatchReportReader;
 import org.sonar.server.computation.component.Component;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
 import org.sonar.server.computation.component.TreeRootHolder;
-import org.sonar.server.computation.component.Visitor;
 
 public class PersistTestsStep implements ComputationStep {
 
@@ -97,7 +97,7 @@ public class PersistTestsStep implements ComputationStep {
     boolean hasUnprocessedCoverageDetails = false;
 
     public TestDepthTraversalTypeAwareCrawler(DbSession session) {
-      super(Component.Type.FILE, Visitor.Order.PRE_ORDER);
+      super(Component.Type.FILE, ComponentVisitor.Order.PRE_ORDER);
       this.session = session;
       this.existingFileSourcesByUuid = new HashMap<>();
       this.projectUuid = treeRootHolder.getRoot().getUuid();
index 450e4abe1503394c20676a6b0180de118cae99f6..7d68599b27826ab43b9413362f8a877f275c0c68 100644 (file)
@@ -26,9 +26,9 @@ import org.sonar.api.notifications.Notification;
 import org.sonar.api.utils.log.Logger;
 import org.sonar.api.utils.log.Loggers;
 import org.sonar.server.computation.component.Component;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
 import org.sonar.server.computation.component.TreeRootHolder;
-import org.sonar.server.computation.component.Visitor;
 import org.sonar.server.computation.event.Event;
 import org.sonar.server.computation.event.EventRepository;
 import org.sonar.server.computation.measure.Measure;
@@ -62,7 +62,7 @@ public class QualityGateEventsStep implements ComputationStep {
 
   @Override
   public void execute() {
-    new DepthTraversalTypeAwareCrawler(Component.Type.PROJECT, Visitor.Order.PRE_ORDER) {
+    new DepthTraversalTypeAwareCrawler(Component.Type.PROJECT, ComponentVisitor.Order.PRE_ORDER) {
       @Override
       public void visitProject(Component project) {
         executeForProject(project);
index 818416f671a1f1c0c51afe9de04cca4415b4880f..6ebeccd2b1c0fc6d339c22c26591065501615d1c 100644 (file)
@@ -34,7 +34,7 @@ import org.sonar.server.computation.qualitygate.QualityGate;
 import org.sonar.server.computation.qualitygate.QualityGateService;
 
 import static org.sonar.server.computation.component.Component.Type.PROJECT;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 /**
  * This step retrieves the QualityGate for the current {@link ReportQueue.Item} and stores it in
index 12f512483dcf4f64ac0ad4a3cb1f125a243b1d39..5ee4d43ff0c4b31fc3c438347d09702123ec843d 100644 (file)
@@ -44,7 +44,7 @@ import org.sonar.server.computation.qualitygate.QualityGate;
 import org.sonar.server.computation.qualitygate.QualityGateHolder;
 
 import static org.sonar.server.computation.component.Component.Type.PROJECT;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 /**
  * This step:
index f84a1dec15ffd55abf505f57d8e13088b3831693..5b5e8593ebae0977ab4c9693b17f593cd615abb9 100644 (file)
@@ -42,7 +42,7 @@ import org.sonar.server.computation.metric.MetricRepository;
 import org.sonar.server.computation.qualityprofile.QPMeasureData;
 import org.sonar.server.computation.qualityprofile.QualityProfile;
 
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
 
 /**
  * Computation of quality profile events
index 2c2f6700f2251e84345decc1b22826c910dd910e..8dea286a6e4261691da9c7cff36bd230403987fd 100644 (file)
@@ -40,7 +40,7 @@ import static org.sonar.api.measures.CoreMetrics.LINES_KEY;
 import static org.sonar.api.measures.CoreMetrics.NCLOC_KEY;
 import static org.sonar.api.measures.CoreMetrics.STATEMENTS_KEY;
 import static org.sonar.server.computation.component.Component.Type.FILE;
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
 import static org.sonar.server.computation.measure.Measure.newMeasureBuilder;
 
 /**
index f28b30abb12e6d8a3537d0a30ea3b1f1521d38a8..41efe8506c79d16d309b13a77cf0d7d647d5b6c2 100644 (file)
@@ -42,9 +42,9 @@ import org.sonar.db.component.ComponentDto;
 import org.sonar.db.component.SnapshotDto;
 import org.sonar.server.computation.batch.BatchReportReader;
 import org.sonar.server.computation.component.Component;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
 import org.sonar.server.computation.component.TreeRootHolder;
-import org.sonar.server.computation.component.Visitor;
 
 import static org.sonar.api.utils.DateUtils.formatDateTime;
 
@@ -108,7 +108,7 @@ public class ValidateProjectStep implements ComputationStep {
     private Component rawProject;
 
     public ValidateProjectsCrawler(DbSession session, ComponentDao componentDao, boolean preventAutomaticProjectCreation, Map<String, ComponentDto> baseModulesByKey) {
-      super(Component.Type.MODULE, Visitor.Order.PRE_ORDER);
+      super(Component.Type.MODULE, ComponentVisitor.Order.PRE_ORDER);
       this.session = session;
       this.componentDao = componentDao;
 
index bbf7aeb57fda40cbf52ddad101624ccf216cab5a..e77c132b607b35265a6d00788c7a7f1dc38838a9 100644 (file)
@@ -30,7 +30,7 @@ import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
 import org.sonar.server.computation.component.MutableTreeRootHolder;
 import org.sonar.server.computation.component.TreeRootHolder;
 
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
 
 public class TreeRootHolderRule implements TestRule, MutableTreeRootHolder {
   private Component root;
index 5bf623620d8f909c1ae308082adc48cc2bfb4fe9..615c413fc679bec9260f6e855a3816fb5c91940a 100644 (file)
@@ -38,8 +38,8 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
 import static org.sonar.server.computation.component.Component.Type.FILE;
 import static org.sonar.server.computation.component.Component.Type.MODULE;
 import static org.sonar.server.computation.component.Component.Type.PROJECT;
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 public class PathAwareCrawlerTest {
 
@@ -258,7 +258,7 @@ public class PathAwareCrawlerTest {
   private static class TestPathAwareCrawler extends PathAwareCrawler<Integer> {
     private final List<CallRecord> callsRecords = new ArrayList<>();
 
-    public TestPathAwareCrawler(Component.Type maxDepth, Visitor.Order order) {
+    public TestPathAwareCrawler(Component.Type maxDepth, ComponentVisitor.Order order) {
       super(maxDepth, order, new SimpleStackElementFactory<Integer>() {
         @Override
         public Integer createForAny(Component component) {
index 9ba230af816b124d94c7552a0122b3962b975c43..a6e8cb98f22ad9a8fff0277cd0c5cc6e194ae37f 100644 (file)
@@ -29,7 +29,7 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
 import static org.sonar.server.computation.component.Component.Type.FILE;
 import static org.sonar.server.computation.component.Component.Type.MODULE;
 import static org.sonar.server.computation.component.Component.Type.PROJECT;
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
 
 public class PostOrderDepthTraversalTypeAwareCrawlerTest {
 
index aeb2c28c823b422591a9d5d8300bc6df828a2e81..d3d858c77342746d19b28252d3cce13785b790e7 100644 (file)
@@ -29,7 +29,7 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
 import static org.sonar.server.computation.component.Component.Type.FILE;
 import static org.sonar.server.computation.component.Component.Type.MODULE;
 import static org.sonar.server.computation.component.Component.Type.PROJECT;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 public class PreOrderDepthTraversalTypeAwareCrawlerTest {
 
index a381ed210071a7c27cdb27c4ff369d2828c33e09..da80d003f7d2f4e443a676729e38c466da9d8ddd 100644 (file)
@@ -34,8 +34,8 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
 import static org.sonar.server.computation.component.Component.Type.FILE;
 import static org.sonar.server.computation.component.Component.Type.MODULE;
 import static org.sonar.server.computation.component.Component.Type.PROJECT;
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 public class VisitorsCrawlerTest {
 
@@ -87,7 +87,7 @@ public class VisitorsCrawlerTest {
   @Test
   public void execute_pre_visitor_before_post_visitor() throws Exception {
     InOrder inOrder = inOrder(spyPreOrderTypeAwareVisitor, spyPostOrderTypeAwareVisitor);
-    VisitorsCrawler underTest = new VisitorsCrawler(Arrays.<Visitor>asList(spyPreOrderTypeAwareVisitor, spyPostOrderTypeAwareVisitor));
+    VisitorsCrawler underTest = new VisitorsCrawler(Arrays.<ComponentVisitor>asList(spyPreOrderTypeAwareVisitor, spyPostOrderTypeAwareVisitor));
     underTest.visit(COMPONENT_TREE);
 
     inOrder.verify(spyPreOrderTypeAwareVisitor).visitProject(COMPONENT_TREE);
@@ -108,7 +108,7 @@ public class VisitorsCrawlerTest {
     thrown.expect(IllegalArgumentException.class);
     thrown.expectMessage("Only TypeAwareVisitor and PathAwareVisitor can be used");
 
-    Visitor visitor = new Visitor() {
+    ComponentVisitor componentVisitor = new ComponentVisitor() {
       @Override
       public Order getOrder() {
         return PRE_ORDER;
@@ -119,7 +119,7 @@ public class VisitorsCrawlerTest {
         return FILE;
       }
     };
-    new VisitorsCrawler(Arrays.asList(visitor));
+    new VisitorsCrawler(Arrays.asList(componentVisitor));
   }
 
   private static Component component(final Component.Type type, final int ref, final Component... children) {
@@ -128,14 +128,14 @@ public class VisitorsCrawlerTest {
 
   private static class TestTypeAwareVisitor extends TypeAwareVisitorAdapter {
 
-    public TestTypeAwareVisitor(Component.Type maxDepth, Visitor.Order order) {
+    public TestTypeAwareVisitor(Component.Type maxDepth, ComponentVisitor.Order order) {
       super(maxDepth, order);
     }
   }
 
   private static class TestPathAwareVisitor extends PathAwareVisitorAdapter<Integer> {
 
-    public TestPathAwareVisitor(Component.Type maxDepth, Visitor.Order order) {
+    public TestPathAwareVisitor(Component.Type maxDepth, ComponentVisitor.Order order) {
       super(maxDepth, order, new SimpleStackElementFactory<Integer>() {
         @Override
         public Integer createForAny(Component component) {
index fb7741eb68d353adec474654b5473cb33f9e9792..24b9162fd5e6baa1a3511765e7a9bc74e32df232 100644 (file)
@@ -40,8 +40,8 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
 import static org.sonar.server.computation.component.Component.Type.FILE;
 import static org.sonar.server.computation.component.Component.Type.MODULE;
 import static org.sonar.server.computation.component.Component.Type.PROJECT;
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 public class VisitorsCrawlerWithPathAwareVisitorTest {
 
@@ -265,14 +265,14 @@ public class VisitorsCrawlerWithPathAwareVisitorTest {
     return new CallRecord(method, currentRef, currentRef, parentRef, ROOT_REF, path);
   }
 
-  private static VisitorsCrawler newVisitorsCrawler(Visitor visitor) {
-    return new VisitorsCrawler(Arrays.asList(visitor));
+  private static VisitorsCrawler newVisitorsCrawler(ComponentVisitor componentVisitor) {
+    return new VisitorsCrawler(Arrays.asList(componentVisitor));
   }
 
   private static class TestPathAwareVisitor extends PathAwareVisitorAdapter<Integer> {
     private final List<CallRecord> callsRecords = new ArrayList<>();
 
-    public TestPathAwareVisitor(Component.Type maxDepth, Visitor.Order order) {
+    public TestPathAwareVisitor(Component.Type maxDepth, ComponentVisitor.Order order) {
       super(maxDepth, order, new SimpleStackElementFactory<Integer>() {
         @Override
         public Integer createForAny(Component component) {
index ceddd9b92e6ed67cdc058907e2cefd0a1da9a853..1044f4754db53a396036b05230c46c400b807eba 100644 (file)
@@ -31,7 +31,7 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
 import static org.sonar.server.computation.component.Component.Type.FILE;
 import static org.sonar.server.computation.component.Component.Type.MODULE;
 import static org.sonar.server.computation.component.Component.Type.PROJECT;
-import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
 
 public class VisitorsCrawlerWithPostOrderTypeAwareVisitorTest {
 
@@ -296,8 +296,8 @@ public class VisitorsCrawlerWithPostOrderTypeAwareVisitorTest {
     return DumbComponent.builder(type, ref).addChildren(children).build();
   }
 
-  private static VisitorsCrawler newVisitorsCrawler(Visitor visitor) {
-    return new VisitorsCrawler(Arrays.asList(visitor));
+  private static VisitorsCrawler newVisitorsCrawler(ComponentVisitor componentVisitor) {
+    return new VisitorsCrawler(Arrays.asList(componentVisitor));
   }
 
 }
index 5ceabfcdd5e3e582d5b7f4fa00439d28f16d8a94..43b606ed194b6f38a0cffae1e26797b76974143d 100644 (file)
@@ -31,7 +31,7 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
 import static org.sonar.server.computation.component.Component.Type.FILE;
 import static org.sonar.server.computation.component.Component.Type.MODULE;
 import static org.sonar.server.computation.component.Component.Type.PROJECT;
-import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
+import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;
 
 public class VisitorsCrawlerWithPreOrderTypeAwareVisitorTest {
 
@@ -289,8 +289,8 @@ public class VisitorsCrawlerWithPreOrderTypeAwareVisitorTest {
     return DumbComponent.builder(type, ref).addChildren(children).build();
   }
 
-  private static VisitorsCrawler newVisitorsCrawler(Visitor visitor) {
-    return new VisitorsCrawler(Arrays.asList(visitor));
+  private static VisitorsCrawler newVisitorsCrawler(ComponentVisitor componentVisitor) {
+    return new VisitorsCrawler(Arrays.asList(componentVisitor));
   }
 
 }
index 1780a7200258962521ad72b7b1da17679a4b53b4..cb4c8ea6f1d5298ba5935f0efe41d1ddcb958ce8 100644 (file)
@@ -26,7 +26,7 @@ import org.junit.Rule;
 import org.junit.Test;
 import org.sonar.api.ce.measure.MeasureComputer;
 import org.sonar.server.computation.component.Component;
-import org.sonar.server.computation.component.Visitor;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.VisitorsCrawler;
 import org.sonar.server.computation.measure.api.MeasureComputerImpl;
 import org.sonar.server.computation.metric.MetricRepositoryRule;
@@ -116,7 +116,7 @@ public class MeasureComputersVisitorTest {
         .build()
       ));
 
-    VisitorsCrawler visitorsCrawler = new VisitorsCrawler(Arrays.<Visitor>asList(new MeasureComputersVisitor(metricRepository, measureRepository, null, measureComputersHolder)));
+    VisitorsCrawler visitorsCrawler = new VisitorsCrawler(Arrays.<ComponentVisitor>asList(new MeasureComputersVisitor(metricRepository, measureRepository, null, measureComputersHolder)));
     visitorsCrawler.visit(ROOT);
 
     assertThat(toEntries(measureRepository.getAddedRawMeasures(FILE_1_REF))).containsOnly(entryOf(NEW_METRIC_KEY, newMeasureBuilder().create(12)));
@@ -140,7 +140,7 @@ public class MeasureComputersVisitorTest {
     measureRepository.addRawMeasure(ROOT_REF, COMMENT_LINES_KEY, newMeasureBuilder().create(7));
 
     measureComputersHolder.setMeasureComputers(Collections.<MeasureComputer>emptyList());
-    VisitorsCrawler visitorsCrawler = new VisitorsCrawler(Arrays.<Visitor>asList(new MeasureComputersVisitor(metricRepository, measureRepository, null, measureComputersHolder)));
+    VisitorsCrawler visitorsCrawler = new VisitorsCrawler(Arrays.<ComponentVisitor>asList(new MeasureComputersVisitor(metricRepository, measureRepository, null, measureComputersHolder)));
     visitorsCrawler.visit(ROOT);
 
     assertThat(toEntries(measureRepository.getAddedRawMeasures(FILE_1_REF))).isEmpty();
index e2effb13ea3e0552fe9f01993f878ccaa6e54953..80828720b7c1794fc24074fa25db76b8044c64d4 100644 (file)
@@ -33,9 +33,9 @@ import javax.annotation.Nullable;
 import org.junit.rules.ExternalResource;
 import org.sonar.db.rule.RuleDto;
 import org.sonar.server.computation.component.Component;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
 import org.sonar.server.computation.component.TreeRootHolder;
-import org.sonar.server.computation.component.Visitor;
 import org.sonar.server.computation.debt.Characteristic;
 import org.sonar.server.computation.metric.Metric;
 import org.sonar.server.computation.metric.MetricRepositoryRule;
@@ -386,7 +386,7 @@ public class MeasureRepositoryRule extends ExternalResource implements MeasureRe
     private final Map<Integer, Component> componentsByRef = new HashMap<>();
 
     public TreeComponentProvider(Component root) {
-      new DepthTraversalTypeAwareCrawler(Component.Type.FILE, Visitor.Order.PRE_ORDER) {
+      new DepthTraversalTypeAwareCrawler(Component.Type.FILE, ComponentVisitor.Order.PRE_ORDER) {
         @Override
         public void visitAny(Component component) {
           checkState(!componentsByRef.containsKey(component.getRef()), "Tree contains more than one component with ref " + component.getRef());
index e0f846fc5abdf8f9b0b46c05a2fbffb00c6256ad..4e4e7f9e3e7556f9c872afc0c9f0df368f289ae0 100644 (file)
@@ -26,9 +26,9 @@ import org.junit.Rule;
 import org.junit.Test;
 import org.sonar.api.measures.CoreMetrics;
 import org.sonar.server.computation.batch.TreeRootHolderRule;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.DumbComponent;
 import org.sonar.server.computation.component.FileAttributes;
-import org.sonar.server.computation.component.Visitor;
 import org.sonar.server.computation.component.VisitorsCrawler;
 import org.sonar.server.computation.measure.Measure;
 import org.sonar.server.computation.measure.MeasureRepoEntry;
@@ -82,7 +82,7 @@ public class SqaleMeasuresVisitorTest {
 
   private SqaleRatingSettings sqaleRatingSettings = mock(SqaleRatingSettings.class);
 
-  private VisitorsCrawler underTest = new VisitorsCrawler(Arrays.<Visitor>asList(new SqaleMeasuresVisitor(metricRepository, measureRepository, sqaleRatingSettings)));
+  private VisitorsCrawler underTest = new VisitorsCrawler(Arrays.<ComponentVisitor>asList(new SqaleMeasuresVisitor(metricRepository, measureRepository, sqaleRatingSettings)));
 
   @Before
   public void setUp() {
index 137fdd8a75fa6a63e57ef03c2752994c588a10bd..f7bd96ada45bffd4e25ee644b69bfa62c7b1d387 100644 (file)
@@ -26,9 +26,9 @@ import org.junit.Rule;
 import org.junit.Test;
 import org.sonar.server.computation.batch.TreeRootHolderRule;
 import org.sonar.server.computation.component.Component;
+import org.sonar.server.computation.component.ComponentVisitor;
 import org.sonar.server.computation.component.PathAwareVisitorAdapter;
 import org.sonar.server.computation.component.TypeAwareVisitorAdapter;
-import org.sonar.server.computation.component.Visitor;
 import org.sonar.server.computation.measure.MeasureRepositoryRule;
 import org.sonar.server.computation.metric.Metric;
 import org.sonar.server.computation.metric.MetricImpl;
@@ -87,7 +87,7 @@ public class ExecuteVisitorsStepTest {
 
   @Test
   public void execute_with_type_aware_visitor() throws Exception {
-    when(visitors.instances()).thenReturn(Arrays.<Visitor>asList(new TestTypeAwareVisitor()));
+    when(visitors.instances()).thenReturn(Arrays.<ComponentVisitor>asList(new TestTypeAwareVisitor()));
     ExecuteVisitorsStep underStep = new ExecuteVisitorsStep(treeRootHolder, visitors);
 
     measureRepository.addRawMeasure(FILE_1_REF, NCLOC_KEY, newMeasureBuilder().create(1));
@@ -107,7 +107,7 @@ public class ExecuteVisitorsStepTest {
 
   @Test
   public void execute_with_path_aware_visitor() throws Exception {
-    when(visitors.instances()).thenReturn(Arrays.<Visitor>asList(new TestPathAwareVisitor()));
+    when(visitors.instances()).thenReturn(Arrays.<ComponentVisitor>asList(new TestPathAwareVisitor()));
     ExecuteVisitorsStep underStep = new ExecuteVisitorsStep(treeRootHolder, visitors);
 
     measureRepository.addRawMeasure(FILE_1_REF, NCLOC_KEY, newMeasureBuilder().create(1));
@@ -125,7 +125,7 @@ public class ExecuteVisitorsStepTest {
   private class TestTypeAwareVisitor extends TypeAwareVisitorAdapter {
 
     public TestTypeAwareVisitor() {
-      super(Component.Type.FILE, Visitor.Order.POST_ORDER);
+      super(Component.Type.FILE, ComponentVisitor.Order.POST_ORDER);
     }
 
     @Override
@@ -138,7 +138,7 @@ public class ExecuteVisitorsStepTest {
   private class TestPathAwareVisitor extends PathAwareVisitorAdapter<Counter> {
 
     public TestPathAwareVisitor() {
-      super(Component.Type.FILE, Visitor.Order.POST_ORDER, new SimpleStackElementFactory<Counter>() {
+      super(Component.Type.FILE, ComponentVisitor.Order.POST_ORDER, new SimpleStackElementFactory<Counter>() {
         @Override
         public Counter createForAny(Component component) {
           return new Counter();