When finding the CTCol object for a XSSF Sheet column, as we often have to traverse...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1600319 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/helpers/ColumnHelper.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/helpers/ColumnHelper.java
index 767fb6e0b65c9c7521f1fea1706547f1430e5a01..41beb6f2593adc8ece5bc8b80210552d96a85920 100644 (file)
--- a/src/ooxml/java/org/apache/poi/xssf/usermodel/helpers/ColumnHelper.java
+++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/helpers/ColumnHelper.java
@@ -199,8 +199,15 @@ public class ColumnHelper {
      */
     public CTCol getColumn1Based(long index1, boolean splitColumns) {
         CTCols colsArray = worksheet.getColsArray(0);
-        for (int i = 0; i < colsArray.sizeOfColArray(); i++) {
-            CTCol colArray = colsArray.getColArray(i);
+        
+        // Fetching the array is quicker than working on the new style
+        //  list, assuming we need to read many of them (which we often do),
+        //  and assuming we're not making many changes (which we're not)
+        @SuppressWarnings("deprecation")
+        CTCol[] cols = colsArray.getColArray();
+        
+        for (int i = 0; i < cols.length; i++) {
+            CTCol colArray = cols[i];
             if (colArray.getMin() <= index1 && colArray.getMax() >= index1) {
                 if (splitColumns) {
                     if (colArray.getMin() < index1) {