]> source.dussan.org Git - jquery-ui.git/commitdiff
Tabs: Use event.preventDefault() instead of return false. Fixes #6765 - Tabs: Use...
authorMaxPower15 <max.schnur@gmail.com>
Mon, 20 Dec 2010 13:50:23 +0000 (08:50 -0500)
committerScott González <scott.gonzalez@gmail.com>
Mon, 20 Dec 2010 13:50:23 +0000 (08:50 -0500)
ui/jquery.ui.tabs.js [changed mode: 0644->0755]

old mode 100644 (file)
new mode 100755 (executable)
index 13e1c25..82da51d
@@ -330,7 +330,8 @@ $.widget( "ui.tabs", {
                        };
 
                // attach tab event handler, unbind to avoid duplicates from former tabifying...
-               this.anchors.bind( o.event + ".tabs", function() {
+               this.anchors.bind( o.event + ".tabs", function( event ) {
+      event.preventDefault();
                        var el = this,
                                $li = $(el).closest( "li" ),
                                $hide = self.panels.filter( ":not(.ui-tabs-hide)" ),
@@ -346,7 +347,7 @@ $.widget( "ui.tabs", {
                                self.panels.filter( ":animated" ).length ||
                                self._trigger( "select", null, self._ui( this, $show[ 0 ] ) ) === false ) {
                                this.blur();
-                               return false;
+        return;
                        }
 
                        o.selected = self.anchors.index( this );
@@ -367,7 +368,7 @@ $.widget( "ui.tabs", {
                                        }).dequeue( "tabs" );
 
                                        this.blur();
-                                       return false;
+                                       return;
                                } else if ( !$hide.length ) {
                                        if ( o.cookie ) {
                                                self._cookie( o.selected, o.cookie );
@@ -381,7 +382,7 @@ $.widget( "ui.tabs", {
                                        self.load( self.anchors.index( this ) );
 
                                        this.blur();
-                                       return false;
+                                       return;
                                }
                        }
 
@@ -415,8 +416,8 @@ $.widget( "ui.tabs", {
                });
 
                // disable click in any case
-               this.anchors.bind( "click.tabs", function(){
-                       return false;
+               this.anchors.bind( "click.tabs", function( event ){
+                       event.preventDefault();
                });
        },