Expose disposeBody() on RevCommit and RevTag

Applications that use a commit message once and do not
need it again can free the body to save memory. Expose
the disposeBody() methods to support this and use it in
pgm.Log which only visits each commit once.

Change-Id: I4142a0749c24f15386ee7fb119934a0432234de3

diff --git a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Log.java b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Log.java
index 048526ee8a32b446b54b46f8d956bdafda330350..688de2c499ddd9b83653379cceac191adf355065 100644 (file)
--- a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Log.java
+++ b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Log.java
@@ -267,6 +267,7 @@ class Log extends RevWalkTextBuiltin {
                        outw.print(s);
                        outw.println();
                }
+               c.disposeBody();
 
                outw.println();
                if (showNotes(c))

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommit.java b/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommit.java
index 37f1d7b8dac07b808b9a26c8d022c73de99ba203..c23e4e3288daad250596e5309a72b8e3248ed483 100644 (file)
--- a/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommit.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommit.java
@@ -609,7 +609,19 @@ public class RevCommit extends RevObject {
                inDegree = 0;
        }
 
-       final void disposeBody() {
+       /**
+        * Discard the message buffer to reduce memory usage.
+        * <p>
+        * After discarding the memory usage of the {@code RevCommit} is reduced to
+        * only the {@link #getTree()} and {@link #getParents()} pointers and the
+        * time in {@link #getCommitTime()}. Accessing other properties such as
+        * {@link #getAuthorIdent()}, {@link #getCommitterIdent()} or either message
+        * function requires reloading the buffer by invoking
+        * {@link RevWalk#parseBody(RevObject)}.
+        *
+        * @since 4.0
+        */
+       public final void disposeBody() {
                buffer = null;
        }
 

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevTag.java b/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevTag.java
index 75201164c1446a20ddf2754e1e763f03991fc137..bf2785e0d76803073dc4dda81ab34a6f290fe8e0 100644 (file)
--- a/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevTag.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevTag.java
@@ -270,7 +270,18 @@ public class RevTag extends RevObject {
                return tagName;
        }
 
-       final void disposeBody() {
+       /**
+        * Discard the message buffer to reduce memory usage.
+        * <p>
+        * After discarding the memory usage of the {@code RevTag} is reduced to
+        * only the {@link #getObject()} pointer and {@link #getTagName()}.
+        * Accessing other properties such as {@link #getTaggerIdent()} or either
+        * message function requires reloading the buffer by invoking
+        * {@link RevWalk#parseBody(RevObject)}.
+        *
+        * @since 4.0
+        */
+       public final void disposeBody() {
                buffer = null;
        }
 }