Set the comment link on render instead of creation

Signed-off-by: Joas Schilling <coding@schilljs.com>

diff --git a/apps/comments/lib/Notification/Listener.php b/apps/comments/lib/Notification/Listener.php
index d30c59c93d5557750aea743f65a5949c543e5bb3..2f94b8a3d752050526530ec3357cbebe1d70fd21 100644 (file)
--- a/apps/comments/lib/Notification/Listener.php
+++ b/apps/comments/lib/Notification/Listener.php
@@ -100,11 +100,7 @@ class Listener {
                        ->setApp('comments')
                        ->setObject('comment', $comment->getId())
                        ->setSubject('mention', [ $comment->getObjectType(), $comment->getObjectId() ])
-                       ->setDateTime($comment->getCreationDateTime())
-                       ->setLink($this->urlGenerator->linkToRouteAbsolute(
-                               'comments.Notifications.view',
-                               ['id' => $comment->getId()])
-                       );
+                       ->setDateTime($comment->getCreationDateTime());
 
                return $notification;
        }

diff --git a/apps/comments/lib/Notification/Notifier.php b/apps/comments/lib/Notification/Notifier.php
index 170538512d8f3910f730adb92ea0e7a7b5fa8f0b..a9daef3031fca2567505ff7cc9245a704f30911d 100644 (file)
--- a/apps/comments/lib/Notification/Notifier.php
+++ b/apps/comments/lib/Notification/Notifier.php
@@ -139,7 +139,11 @@ class Notifier implements INotifier {
                                                        ]
                                                );
                                }
-                               $notification->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/comment.svg')));
+                               $notification->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/comment.svg')))
+                                       ->setLink($this->url->linkToRouteAbsolute(
+                                               'comments.Notifications.view',
+                                               ['id' => $comment->getId()])
+                                       );
 
                                return $notification;
                                break;