]> source.dussan.org Git - nextcloud-server.git/commitdiff
adjust files app, and integrate files_external into that section
authorArthur Schiwon <blizzz@arthur-schiwon.de>
Thu, 11 Aug 2016 16:39:16 +0000 (18:39 +0200)
committerLukas Reschke <lukas@statuscode.ch>
Tue, 16 Aug 2016 19:08:16 +0000 (21:08 +0200)
apps/files/admin.php [deleted file]
apps/files/appinfo/app.php
apps/files/appinfo/info.xml
apps/files/lib/Settings/Admin.php [new file with mode: 0644]
apps/files/lib/Settings/Section.php [new file with mode: 0644]
apps/files_external/appinfo/info.xml
apps/files_external/lib/Settings/Admin.php
apps/files_external/lib/Settings/Section.php [deleted file]

diff --git a/apps/files/admin.php b/apps/files/admin.php
deleted file mode 100644 (file)
index ad7b16a..0000000
+++ /dev/null
@@ -1,51 +0,0 @@
-<?php
-/**
- * @copyright Copyright (c) 2016, ownCloud, Inc.
- *
- * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
- * @author Clark Tomlinson <fallen013@gmail.com>
- * @author Frank Karlitschek <frank@karlitschek.de>
- * @author Michael Göhler <somebody.here@gmx.de>
- * @author Morris Jobke <hey@morrisjobke.de>
- * @author Robin Appelman <robin@icewind.nl>
- * @author Robin McCorkell <robin@mccorkell.me.uk>
- * @author Thomas Müller <thomas.mueller@tmit.eu>
- *
- * @license AGPL-3.0
- *
- * This code is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License, version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License, version 3,
- * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *
- */
-
-$htaccessWorking=(getenv('htaccessWorking')=='true');
-$upload_max_filesize = OC::$server->getIniWrapper()->getBytes('upload_max_filesize');
-$post_max_size = OC::$server->getIniWrapper()->getBytes('post_max_size');
-$maxUploadFilesize = OCP\Util::humanFileSize(min($upload_max_filesize, $post_max_size));
-if($_POST && \OC::$server->getRequest()->passesCSRFCheck()) {
-       if(isset($_POST['maxUploadSize'])) {
-               if(($setMaxSize = OC_Files::setUploadLimit(OCP\Util::computerFileSize($_POST['maxUploadSize']))) !== false) {
-                       $maxUploadFilesize = OCP\Util::humanFileSize($setMaxSize);
-               }
-       }
-}
-
-$htaccessWritable=is_writable(OC::$SERVERROOT.'/.htaccess');
-$userIniWritable=is_writable(OC::$SERVERROOT.'/.user.ini');
-
-$tmpl = new OCP\Template( 'files', 'admin' );
-$tmpl->assign( 'uploadChangable', ($htaccessWorking and $htaccessWritable) or $userIniWritable );
-$tmpl->assign( 'uploadMaxFilesize', $maxUploadFilesize);
-// max possible makes only sense on a 32 bit system
-$tmpl->assign( 'displayMaxPossibleUploadSize', PHP_INT_SIZE===4);
-$tmpl->assign( 'maxPossibleUploadSize', OCP\Util::humanFileSize(PHP_INT_MAX));
-return $tmpl->fetchPage();
index cc86e9bf27096bd6307c8e0ee5018f3709cdf516..0cd7870a426122cc9d31a2b657d2c30b55d978bc 100644 (file)
@@ -26,8 +26,8 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>
  *
  */
-\OCP\App::registerAdmin('files', 'admin');
 
+$l = \OC::$server->getL10N('files');
 
 \OC::$server->getNavigationManager()->add(function () {
        $urlGenerator = \OC::$server->getURLGenerator();
index 573285f8b3b1f1a43c335202ff8306d1f02a5810..0339f19cbab7d0ff09b600c84ef7e261f3ab868c 100644 (file)
@@ -6,7 +6,7 @@
        <licence>AGPL</licence>
        <author>Robin Appelman, Vincent Petry</author>
        <default_enable/>
-       <version>1.5.1</version>
+       <version>1.5.2</version>
        <types>
                <filesystem/>
        </types>
@@ -22,4 +22,9 @@
                <job>OCA\Files\BackgroundJob\DeleteOrphanedItems</job>
                <job>OCA\Files\BackgroundJob\CleanupFileLocks</job>
        </background-jobs>
+
+       <settings>
+               <admin>OCA\Files\Settings\Admin</admin>
+               <admin-section>OCA\Files\Settings\Section</admin-section>
+       </settings>
 </info>
diff --git a/apps/files/lib/Settings/Admin.php b/apps/files/lib/Settings/Admin.php
new file mode 100644 (file)
index 0000000..d0a691f
--- /dev/null
@@ -0,0 +1,93 @@
+<?php
+/**
+ * @copyright Copyright (c) 2016 Arthur Schiwon <blizzz@arthur-schiwon.de>
+ *
+ * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Files\Settings;
+
+use bantu\IniGetWrapper\IniGetWrapper;
+use OCP\AppFramework\Http\TemplateResponse;
+use OCP\IRequest;
+use OCP\Settings\ISettings;
+use OCP\Util;
+
+class Admin implements ISettings {
+
+       /** @var IniGetWrapper */
+       private $iniWrapper;
+
+       /** @var IRequest */
+       private $request;
+
+       public function __construct(IniGetWrapper $iniWrapper, IRequest $request) {
+               $this->iniWrapper = $iniWrapper;
+               $this->request = $request;
+       }
+
+       /**
+        * @return TemplateResponse
+        */
+       public function getForm() {
+               $htaccessWorking  = (getenv('htaccessWorking') == 'true');
+               $htaccessWritable = is_writable(\OC::$SERVERROOT.'/.htaccess');
+               $userIniWritable  = is_writable(\OC::$SERVERROOT.'/.user.ini');
+
+               $upload_max_filesize = $this->iniWrapper->getBytes('upload_max_filesize');
+               $post_max_size = $this->iniWrapper->getBytes('post_max_size');
+               $maxUploadFilesize = Util::humanFileSize(min($upload_max_filesize, $post_max_size));
+               if($_POST && $this->request->passesCSRFCheck()) {
+                       if(isset($_POST['maxUploadSize'])) {
+                               if(($setMaxSize = \OC_Files::setUploadLimit(Util::computerFileSize($_POST['maxUploadSize']))) !== false) {
+                                       $maxUploadFilesize = Util::humanFileSize($setMaxSize);
+                               }
+                       }
+               }
+
+               $parameters = [
+                       'uploadChangable'              => (($htaccessWorking and $htaccessWritable) or $userIniWritable ),
+                       'uploadMaxFilesize'            => $maxUploadFilesize,
+                       // max possible makes only sense on a 32 bit system
+                       'displayMaxPossibleUploadSize' => PHP_INT_SIZE === 4,
+                       'maxPossibleUploadSize'        => Util::humanFileSize(PHP_INT_MAX),
+               ];
+
+               return new TemplateResponse('files', 'admin', $parameters, '');
+       }
+
+       /**
+        * @return string the section ID, e.g. 'sharing'
+        */
+       public function getSection() {
+               return 'files';
+       }
+
+       /**
+        * @return int whether the form should be rather on the top or bottom of
+        * the admin section. The forms are arranged in ascending order of the
+        * priority values. It is required to return a value between 0 and 100.
+        *
+        * E.g.: 70
+        */
+       public function getPriority() {
+               return 5;
+       }
+
+}
diff --git a/apps/files/lib/Settings/Section.php b/apps/files/lib/Settings/Section.php
new file mode 100644 (file)
index 0000000..2323870
--- /dev/null
@@ -0,0 +1,67 @@
+<?php
+/**
+ * @copyright Copyright (c) 2016 Arthur Schiwon <blizzz@arthur-schiwon.de>
+ *
+ * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Files\Settings;
+
+use OCP\IL10N;
+use OCP\Settings\ISection;
+
+class Section implements ISection {
+       /** @var IL10N */
+       private $l;
+
+       public function __construct(IL10N $l) {
+               $this->l = $l;
+       }
+
+       /**
+        * returns the ID of the section. It is supposed to be a lower case string,
+        * e.g. 'ldap'
+        *
+        * @returns string
+        */
+       public function getID() {
+               return 'files';
+       }
+
+       /**
+        * returns the translated name as it should be displayed, e.g. 'LDAP / AD
+        * integration'. Use the L10N service to translate it.
+        *
+        * @return string
+        */
+       public function getName() {
+               return $this->l->t('Files & Storages');
+       }
+
+       /**
+        * @return int whether the form should be rather on the top or bottom of
+        * the settings navigation. The sections are arranged in ascending order of
+        * the priority values. It is required to return a value between 0 and 99.
+        *
+        * E.g.: 70
+        */
+       public function getPriority() {
+               return 10;
+       }
+}
index 8e37aa413ab838bc5604dda0e7c37db4137f624d..a155c38ae4769758bfaa8a5263ed32ff8dd8d727 100644 (file)
@@ -13,7 +13,7 @@
                <admin>admin-external-storage</admin>
        </documentation>
        <rememberlogin>false</rememberlogin>
-       <version>1.0.1</version>
+       <version>1.0.2</version>
        <types>
                <filesystem/>
        </types>
@@ -27,6 +27,5 @@
 
        <settings>
                <admin>OCA\Files_External\Settings\Admin</admin>
-               <admin-section>OCA\Files_External\Settings\Section</admin-section>
        </settings>
 </info>
index eebfd71287431c54167dfedc3f690e42b85d57d0..102680d0341a778550f7c2111cae110f32cef84f 100644 (file)
@@ -79,7 +79,7 @@ class Admin implements ISettings {
         * @return string the section ID, e.g. 'sharing'
         */
        public function getSection() {
-               return 'externalstorage';
+               return 'files';
        }
 
        /**
@@ -90,7 +90,7 @@ class Admin implements ISettings {
         * E.g.: 70
         */
        public function getPriority() {
-               return 5;
+               return 40;
        }
 
 }
diff --git a/apps/files_external/lib/Settings/Section.php b/apps/files_external/lib/Settings/Section.php
deleted file mode 100644 (file)
index 850b042..0000000
+++ /dev/null
@@ -1,67 +0,0 @@
-<?php
-/**
- * @copyright Copyright (c) 2016 Arthur Schiwon <blizzz@arthur-schiwon.de>
- *
- * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- */
-
-namespace OCA\Files_External\Settings;
-
-use OCP\IL10N;
-use OCP\Settings\ISection;
-
-class Section implements ISection {
-       /** @var IL10N */
-       private $l;
-
-       public function __construct(IL10N $l) {
-               $this->l = $l;
-       }
-
-       /**
-        * returns the ID of the section. It is supposed to be a lower case string,
-        * e.g. 'ldap'
-        *
-        * @returns string
-        */
-       public function getID() {
-               return 'externalstorage';
-       }
-
-       /**
-        * returns the translated name as it should be displayed, e.g. 'LDAP / AD
-        * integration'. Use the L10N service to translate it.
-        *
-        * @return string
-        */
-       public function getName() {
-               return $this->l->t('External Storage');
-       }
-
-       /**
-        * @return int whether the form should be rather on the top or bottom of
-        * the settings navigation. The sections are arranged in ascending order of
-        * the priority values. It is required to return a value between 0 and 99.
-        *
-        * E.g.: 70
-        */
-       public function getPriority() {
-               return 35;
-       }
-}