]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-15340 - Increase DevOps form fields max length
authorBelen Pruvost <belen.pruvost@sonarsource.com>
Wed, 25 Aug 2021 16:17:09 +0000 (18:17 +0200)
committersonartech <sonartech@sonarsource.com>
Mon, 30 Aug 2021 20:08:19 +0000 (20:08 +0000)
server/sonar-web/src/main/js/apps/settings/components/almIntegration/AzureForm.tsx
server/sonar-web/src/main/js/apps/settings/components/almIntegration/BitbucketCloudForm.tsx
server/sonar-web/src/main/js/apps/settings/components/almIntegration/BitbucketServerForm.tsx
server/sonar-web/src/main/js/apps/settings/components/almIntegration/GithubForm.tsx
server/sonar-web/src/main/js/apps/settings/components/almIntegration/GitlabForm.tsx
server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AzureForm-test.tsx.snap
server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/BitbucketCloudForm-test.tsx.snap
server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/BitbucketServerForm-test.tsx.snap
server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/GithubForm-test.tsx.snap
server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/GitlabForm-test.tsx.snap

index 30835e23826a1d17c9de5e14c9c8364e04f1ac36..128f260f341ce6c0df09785728af125e8a30c7cf 100644 (file)
@@ -93,6 +93,7 @@ export default function AzureForm(props: AzureFormProps) {
         overwriteOnly={Boolean(formData.key)}
         propKey="personalAccessToken"
         value={formData.personalAccessToken}
+        maxLength={2000}
         isSecret={true}
       />
     </>
index 928163cf8e01fd53d5f82dd0f2a182e1b6c0e823..f6d08382860a3a635f60a1216f67472c560846cc 100644 (file)
@@ -104,6 +104,7 @@ export default function BitbucketCloudForm(props: BitbucketCloudFormProps) {
         overwriteOnly={Boolean(formData.key)}
         propKey="clientSecret"
         value={formData.clientSecret || ''}
+        maxLength={160}
         isSecret={true}
       />
     </>
index b9e8721fb2c74cc27602ce61678094e92b4d39b7..9779db9e32964960993fe55fe88c207560ea41e2 100644 (file)
@@ -92,6 +92,7 @@ export default function BitbucketServerForm(props: BitbucketServerFormProps) {
         overwriteOnly={Boolean(formData.key)}
         propKey="personalAccessToken"
         value={formData.personalAccessToken || ''}
+        maxLength={2000}
         isSecret={true}
       />
     </>
index d279943900641280f39009e872b26e5e80a31585..a94593e57aa738e3eca1c97d590833d00f2fe221 100644 (file)
@@ -95,7 +95,7 @@ export default function GithubForm(props: GithubFormProps) {
       <AlmBindingDefinitionFormField
         id="client_secret.github"
         help={translate('settings.almintegration.form.client_secret.github.help')}
-        maxLength={80}
+        maxLength={160}
         onFieldChange={onFieldChange}
         overwriteOnly={Boolean(formData.key)}
         propKey="clientSecret"
@@ -110,6 +110,7 @@ export default function GithubForm(props: GithubFormProps) {
         overwriteOnly={Boolean(formData.key)}
         propKey="privateKey"
         value={formData.privateKey}
+        maxLength={2500}
         isSecret={true}
       />
     </>
index 6f938ef6f299fbf5d846954874cbfcbaee0a89af..015fbc581aaf0f44fe47333bc5e2255d50cffaa3 100644 (file)
@@ -89,6 +89,7 @@ export default function GitlabForm(props: GitlabFormProps) {
         overwriteOnly={Boolean(formData.key)}
         propKey="personalAccessToken"
         value={formData.personalAccessToken}
+        maxLength={2000}
         isSecret={true}
       />
     </>
index 6120baaa2426f60c33072cef2add648290696811..d03d8b8f90a1234c98cb7cc072025409fa677d15 100644 (file)
@@ -65,6 +65,7 @@ exports[`should render correctly: create 1`] = `
     id="personal_access_token"
     isSecret={true}
     isTextArea={true}
+    maxLength={2000}
     onFieldChange={[MockFunction]}
     overwriteOnly={false}
     propKey="personalAccessToken"
@@ -138,6 +139,7 @@ exports[`should render correctly: edit 1`] = `
     id="personal_access_token"
     isSecret={true}
     isTextArea={true}
+    maxLength={2000}
     onFieldChange={[MockFunction]}
     overwriteOnly={true}
     propKey="personalAccessToken"
index 02b2f021223dfb04c8a72cc38a9b89de98706ed4..4fd3e07e4fa58aec31a122e3a3aa3d3123c00963 100644 (file)
@@ -77,6 +77,7 @@ exports[`should render correctly 1`] = `
     help="settings.almintegration.form.oauth_secret.bitbucketcloud.help"
     id="client_secret.bitbucketcloud"
     isSecret={true}
+    maxLength={160}
     onFieldChange={[MockFunction]}
     overwriteOnly={true}
     propKey="clientSecret"
index 086b09f83cdad607442e5b421212c1cbdd87e5a2..168036c2123585ab95acaae1bd59196014d54a9b 100644 (file)
@@ -61,6 +61,7 @@ exports[`should render correctly 1`] = `
     id="personal_access_token"
     isSecret={true}
     isTextArea={true}
+    maxLength={2000}
     onFieldChange={[MockFunction]}
     overwriteOnly={true}
     propKey="personalAccessToken"
index 4499dc5e2a1eef72fa5c7b833f4d55d028d6b558..2eaa2b199955954a40c20aaab1d5f1018c0cab2a 100644 (file)
@@ -74,7 +74,7 @@ exports[`should render correctly 1`] = `
     help="settings.almintegration.form.client_secret.github.help"
     id="client_secret.github"
     isSecret={true}
-    maxLength={80}
+    maxLength={160}
     onFieldChange={[MockFunction]}
     overwriteOnly={false}
     propKey="clientSecret"
@@ -85,6 +85,7 @@ exports[`should render correctly 1`] = `
     id="private_key"
     isSecret={true}
     isTextArea={true}
+    maxLength={2500}
     onFieldChange={[MockFunction]}
     overwriteOnly={false}
     propKey="privateKey"
@@ -167,7 +168,7 @@ exports[`should render correctly 2`] = `
     help="settings.almintegration.form.client_secret.github.help"
     id="client_secret.github"
     isSecret={true}
-    maxLength={80}
+    maxLength={160}
     onFieldChange={[MockFunction]}
     overwriteOnly={true}
     propKey="clientSecret"
@@ -178,6 +179,7 @@ exports[`should render correctly 2`] = `
     id="private_key"
     isSecret={true}
     isTextArea={true}
+    maxLength={2500}
     onFieldChange={[MockFunction]}
     overwriteOnly={true}
     propKey="privateKey"
index f8b95437d64320775529a5459aa3359f2d5fe0d2..33452300e00e952fc9217e569aff7ad898d40eab 100644 (file)
@@ -61,6 +61,7 @@ exports[`should render correctly 1`] = `
     id="personal_access_token"
     isSecret={true}
     isTextArea={true}
+    maxLength={2000}
     onFieldChange={[MockFunction]}
     overwriteOnly={false}
     propKey="personalAccessToken"
@@ -130,6 +131,7 @@ exports[`should render correctly 2`] = `
     id="personal_access_token"
     isSecret={true}
     isTextArea={true}
+    maxLength={2000}
     onFieldChange={[MockFunction]}
     overwriteOnly={true}
     propKey="personalAccessToken"