FOP-3158: Switch to spotbugs

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 661a5557335eb8c70239f0df6bcfa2d91249fe06..3945645312eb0cba3bd978afd45388f161e1dde1 100644 (file)
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -28,7 +28,7 @@ jobs:
         distribution: 'temurin'
         cache: maven
     - name: Build with Maven
-      run: mvn -B package checkstyle:check findbugs:check --file pom.xml
+      run: mvn -B package checkstyle:check spotbugs:check --file pom.xml
 
     # Optional: Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
     #- name: Update dependency graph

diff --git a/fop-core/pom.xml b/fop-core/pom.xml
index 221465ddd262a473954578c4db9795d29f605f43..bc2c56781b4a96dc9837a57d8c4ce28c4ee1e204 100644 (file)
--- a/fop-core/pom.xml
+++ b/fop-core/pom.xml
@@ -328,8 +328,8 @@
       </plugin>
       <!-- code analysis - checkstyle -->
       <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>findbugs-maven-plugin</artifactId>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
         <version>${findbugs.plugin.version}</version>
         <configuration>
           <excludeFilterFile>src/tools/resources/findbugs/exclusions.xml</excludeFilterFile>
@@ -378,8 +378,8 @@
       <build>
         <plugins>
           <plugin>
-            <groupId>org.codehaus.mojo</groupId>
-            <artifactId>findbugs-maven-plugin</artifactId>
+            <groupId>com.github.spotbugs</groupId>
+            <artifactId>spotbugs-maven-plugin</artifactId>
             <version>${findbugs.plugin.version}</version>
             <configuration>
               <excludeFilterFile>src/tools/resources/findbugs/exclusions.xml</excludeFilterFile>

diff --git a/fop-events/pom.xml b/fop-events/pom.xml
index ac0df8625afcd7786b93062129ff099b1aeb94a6..a7a6d2d0e1e85652cdb1bd002c63627e06570ae2 100644 (file)
--- a/fop-events/pom.xml
+++ b/fop-events/pom.xml
@@ -110,8 +110,8 @@
       </plugin>
       <!-- code analysis - findbugs -->
       <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>findbugs-maven-plugin</artifactId>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
         <version>${findbugs.plugin.version}</version>
         <configuration>
           <excludeFilterFile>../fop-core/src/tools/resources/findbugs/exclusions.xml</excludeFilterFile>

diff --git a/fop-sandbox/pom.xml b/fop-sandbox/pom.xml
index 9fefca9b68b7d7f937cf12ccb1411b7d1df7dded..880195c65fcd5ac11808d8325adce58897b46a01 100644 (file)
--- a/fop-sandbox/pom.xml
+++ b/fop-sandbox/pom.xml
@@ -105,8 +105,8 @@
       </plugin>
       <!-- code analysis - findbugs -->
       <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>findbugs-maven-plugin</artifactId>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
         <version>${findbugs.plugin.version}</version>
         <configuration>
           <excludeFilterFile>src/tools/resources/findbugs/exclusions.xml</excludeFilterFile>

diff --git a/fop-util/pom.xml b/fop-util/pom.xml
index 020d97fef622ff132d37d8445edd6578a7b1183d..33fc903c3e8268ae4407b362db605a69082d8828 100644 (file)
--- a/fop-util/pom.xml
+++ b/fop-util/pom.xml
@@ -58,8 +58,8 @@
       </plugin>
       <!-- code analysis - findbugs -->
       <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>findbugs-maven-plugin</artifactId>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
         <version>${findbugs.plugin.version}</version>
         <configuration>
           <excludeFilterFile>../fop-core/src/tools/resources/findbugs/exclusions.xml</excludeFilterFile>

diff --git a/pom.xml b/pom.xml
index 637bafc801f6ce7662f679d2755e4dab2eacbc52..608c4b93bb62bfada5bd320153bfe999074096b7 100644 (file)
--- a/pom.xml
+++ b/pom.xml
@@ -20,7 +20,7 @@
     <commons.logging.version>1.0.4</commons.logging.version>
     <compiler.plugin.version>3.11.0</compiler.plugin.version>
     <exec.plugin.version>1.4.0</exec.plugin.version>
-    <findbugs.plugin.version>3.0.4</findbugs.plugin.version>
+    <findbugs.plugin.version>3.1.12.2</findbugs.plugin.version>
     <jar.plugin.version>3.1.1</jar.plugin.version>
     <java.version>8</java.version>
     <junit.version>4.11</junit.version>
@@ -102,6 +102,11 @@
           <artifactId>maven-surefire-plugin</artifactId>
           <version>${surefire.plugin.version}</version>
         </plugin>
+        <plugin>
+          <groupId>com.github.spotbugs</groupId>
+          <artifactId>spotbugs-maven-plugin</artifactId>
+          <version>${findbugs.plugin.version}</version>
+        </plugin>        
       </plugins>
     </pluginManagement>
   </build>