only log diagnostic events if a treshhold is set

this prevents log spam and it's rare that you actually want to very short events logged anyway

Signed-off-by: Robin Appelman <robin@icewind.nl>

diff --git a/config/config.sample.php b/config/config.sample.php
index 5c34563f63dbac2840c844d3c5f439305904ad72..bf6643458fa3baf2caaeaacb0d4228d973fd23b4 100644 (file)
--- a/config/config.sample.php
+++ b/config/config.sample.php
@@ -1791,7 +1791,7 @@ $CONFIG = [
 
 /**
  * Enforce the user theme. This will disable the user theming settings
- * This must be a valid ITheme ID. 
+ * This must be a valid ITheme ID.
  * E.g. light, dark, highcontrast, dark-highcontrast...
  */
 'enforce_theme' => '',
@@ -2146,6 +2146,8 @@ $CONFIG = [
 
 /**
  * Limit diagnostics event logging to events longer than the configured threshold in ms
+ *
+ * when set to 0 no diagnostics events will be logged
  */
 'diagnostics.logging.threshold' => 0,
 

diff --git a/lib/private/Diagnostics/EventLogger.php b/lib/private/Diagnostics/EventLogger.php
index c7b89002ea97d78300b1c5f4d4b5060361fb5f53..7b9bd9630ab2cd1577598ce0eb1238134bf24708 100644 (file)
--- a/lib/private/Diagnostics/EventLogger.php
+++ b/lib/private/Diagnostics/EventLogger.php
@@ -126,7 +126,7 @@ class EventLogger implements IEventLogger {
                        $timeInMs = round($duration * 1000, 4);
 
                        $loggingMinimum = (int)$this->config->getValue('diagnostics.logging.threshold', 0);
-                       if ($loggingMinimum > 0 && $timeInMs < $loggingMinimum) {
+                       if ($loggingMinimum === 0 || $timeInMs < $loggingMinimum) {
                                return;
                        }