Fix setting version table in dump (#15753)

* Fix setting version table in dump

As noted on Discord there is a problem with gitea dump where the version table
is not being dumped correctly.

This is due to a missing pointer in the TableInfo.

This PR fixes this.

Signed-off-by: Andrew Thornton <art27@cantab.net>
* Update models_test.go

diff --git a/models/models.go b/models/models.go
index 73e65d828bdf1b1485d483c5eeb30cf2b84137bd..b0a9062566ee3f9e47e926ddaf5049a59f647eba 100644 (file)
--- a/models/models.go
+++ b/models/models.go
@@ -320,7 +320,7 @@ func DumpDatabase(filePath, dbType string) error {
                ID      int64 `xorm:"pk autoincr"`
                Version int64
        }
-       t, err := x.TableInfo(Version{})
+       t, err := x.TableInfo(&Version{})
        if err != nil {
                return err
        }

diff --git a/models/models_test.go b/models/models_test.go
index 2441ad7fb064edc61ac50766cfc8a769ea57ffab..9793394e0b6f247fe1a14df46fedd385ad653b28 100644 (file)
--- a/models/models_test.go
+++ b/models/models_test.go
@@ -25,7 +25,7 @@ func TestDumpDatabase(t *testing.T) {
                ID      int64 `xorm:"pk autoincr"`
                Version int64
        }
-       assert.NoError(t, x.Sync2(Version{}))
+       assert.NoError(t, x.Sync2(new(Version)))
 
        for _, dbName := range setting.SupportedDatabases {
                dbType := setting.GetDBTypeByName(dbName)