Fix middleware function's placements for `/user/...` (#19377) (#19378)

- Backport #19377
  - Add reqSignIn to `/user/task/{task}` as it specific to a logged in user currently not-logged in user could cause a NPE.
  - Remove `/user/active` reqSignIn middleware, because when you want to active a account you're not "signed in" so it doesn't make sense to add that middleware.

diff --git a/routers/web/web.go b/routers/web/web.go
index d3b891ce3157b280df5be8ebd82ae8700e8daaf8..e18ed8f8ee0abe7062904038ab251e11a6f8f9ca 100644 (file)
--- a/routers/web/web.go
+++ b/routers/web/web.go
@@ -374,8 +374,8 @@ func RegisterRoutes(m *web.Route) {
 
        m.Group("/user", func() {
                // r.Get("/feeds", binding.Bind(auth.FeedsForm{}), user.Feeds)
-               m.Get("/activate", auth.Activate, reqSignIn)
-               m.Post("/activate", auth.ActivatePost, reqSignIn)
+               m.Get("/activate", auth.Activate)
+               m.Post("/activate", auth.ActivatePost)
                m.Any("/activate_email", auth.ActivateEmail)
                m.Get("/avatar/{username}/{size}", user.AvatarByUserName)
                m.Get("/recover_account", auth.ResetPasswd)
@@ -383,7 +383,7 @@ func RegisterRoutes(m *web.Route) {
                m.Get("/forgot_password", auth.ForgotPasswd)
                m.Post("/forgot_password", auth.ForgotPasswdPost)
                m.Post("/logout", auth.SignOut)
-               m.Get("/task/{task}", user.TaskStatus)
+               m.Get("/task/{task}", reqSignIn, user.TaskStatus)
        })
        // ***** END: User *****