Remove pointless boolean during native push

The boolean field sentCommand is always true at this point, as it
was assigned just 5 lines above.  So we always set the status of
the update command object to AWAITING_REPORT.

Simplify the logic by dropping the ?: operator.  I assume this is
older code from an attempt to manage dry-run push support within
the native connection, but in fact dry-run support is done higher
up inside of PushProcess.

Change-Id: I450d491bbbb5afecdbf5444ab7169222e856a3bb
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java
index b1ce28d35f4c860733b05b0ae9d8c56cd0bba3c6..2603ca2879411f549a5cadc14bba47d39eb24495 100644 (file)
--- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java
@@ -178,7 +178,7 @@ class BasePackPushConnection extends BasePackConnection implements
                        }
 
                        pckOut.writeString(sb.toString());
-                       rru.setStatus(sentCommand ? Status.AWAITING_REPORT : Status.OK);
+                       rru.setStatus(Status.AWAITING_REPORT);
                        if (!rru.isDelete())
                                writePack = true;
                }