]> source.dussan.org Git - jquery-ui.git/commitdiff
Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn...
authorJörn Zaefferer <joern.zaefferer@gmail.com>
Thu, 15 Nov 2012 22:12:54 +0000 (23:12 +0100)
committerJörn Zaefferer <joern.zaefferer@gmail.com>
Mon, 26 Nov 2012 09:28:22 +0000 (10:28 +0100)
ui/jquery.ui.dialog.js

index 24fada4795ba5392fd28e912e7854b064821432b..60bcca0c62f3c25ebf55584d3ac10d1bd070e44a 100644 (file)
@@ -93,8 +93,6 @@ $.widget("ui.dialog", {
                var that = this,
                        options = this.options,
                        title = options.title || "&#160;",
-                       // TODO should use this.uiDialogTitlebar instead
-                       uiDialogTitlebar,
                        uiDialogTitle,
                        uiDialogButtonPane;
 
@@ -124,11 +122,11 @@ $.widget("ui.dialog", {
                                .addClass( "ui-dialog-content ui-widget-content" )
                                .appendTo( this.uiDialog );
 
-                       // TODO extract this and the next three into a _createTitlebar method
-                       uiDialogTitlebar = ( this.uiDialogTitlebar = $( "<div>" ) )
+                       // TODO extract this and the next two into a _createTitlebar method
+                       this.uiDialogTitlebar = $( "<div>" )
                                .addClass( "ui-dialog-titlebar  ui-widget-header ui-corner-all  ui-helper-clearfix" )
                                .prependTo( this.uiDialog );
-                       this._on( uiDialogTitlebar, {
+                       this._on( this.uiDialogTitlebar, {
                                mousedown: function() {
                                        // TODO call _focusTabbable or _keepFocus
                                        // Dialog isn't getting focus when dragging (#8063)
@@ -149,13 +147,13 @@ $.widget("ui.dialog", {
                                        event.preventDefault();
                                        that.close( event );
                                })
-                               .appendTo( uiDialogTitlebar );
+                               .appendTo( this.uiDialogTitlebar );
 
                        uiDialogTitle = $( "<span>" )
                                .uniqueId()
                                .addClass( "ui-dialog-title" )
                                .html( title )
-                               .prependTo( uiDialogTitlebar );
+                               .prependTo( this.uiDialogTitlebar );
 
                        // TODO extract this one and the next into a _createButtonPane method
                        uiDialogButtonPane = ( this.uiDialogButtonPane = $( "<div>" ) )