]> source.dussan.org Git - jquery-ui.git/commitdiff
Tests: Fix improper async sortable test
authorLeonardo Balter <leonardo.balter@gmail.com>
Tue, 27 Oct 2015 16:33:44 +0000 (12:33 -0400)
committerScott González <scott.gonzalez@gmail.com>
Thu, 9 Jun 2016 21:27:28 +0000 (17:27 -0400)
Caught when testing jQuery UI against the new QUnit version, where start throws
an error if called with a non-numeric error.

Closes gh-1630

(cherry picked from commit 60fa118955aab65e66995454f4e7b228a49c4177)

tests/unit/sortable/sortable_options.js

index 90cf765a2b58554e20d1a6a5f4d0c2f9759a1199..235dec9c60483ea93410dfc15b03002048203e0f 100644 (file)
@@ -87,7 +87,6 @@ asyncTest( "#7415: Incorrect revert animation with axis: 'y'", function() {
                element = $( "#sortable" ).sortable({
                        axis: "y",
                        revert: true,
-                       stop: start,
                        sort: function() {
                                expectedLeft = item.css( "left" );
                        }
@@ -103,6 +102,7 @@ asyncTest( "#7415: Incorrect revert animation with axis: 'y'", function() {
                var top = parseFloat( item.css( "top" ) );
                equal( item.css( "left" ), expectedLeft, "left not animated" );
                ok( top > 0 && top < 300, "top is animated" );
+               start();
        }, 100 );
 });