Defined RPC in a field rather than inline for clarity

diff --git a/src/com/vaadin/ui/Button.java b/src/com/vaadin/ui/Button.java
index fc564c3237278ae1217edc3478ec0effdc67dd67..daa7e20ca73a8e05e60b59f57fc01e265c183598 100644 (file)
--- a/src/com/vaadin/ui/Button.java
+++ b/src/com/vaadin/ui/Button.java
@@ -38,22 +38,23 @@ public class Button extends AbstractComponent implements
         FieldEvents.BlurNotifier, FieldEvents.FocusNotifier, Focusable,
         Action.ShortcutNotifier {
 
+    private ButtonServerRpc rpc = new ButtonServerRpc() {
+        public void click(MouseEventDetails mouseEventDetails) {
+            fireClick(mouseEventDetails);
+        }
+
+        public void disableOnClick() {
+            // Could be optimized so the button is not repainted because of
+            // this (client side has already disabled the button)
+            setEnabled(false);
+        }
+    };
+
     /**
      * Creates a new push button.
      */
     public Button() {
-        // TODO take the implementation out of an anonymous class?
-        registerRpcImplementation(new ButtonServerRpc() {
-            public void click(MouseEventDetails mouseEventDetails) {
-                fireClick(mouseEventDetails);
-            }
-
-            public void disableOnClick() {
-                // Could be optimized so the button is not repainted because of
-                // this (client side has already disabled the button)
-                setEnabled(false);
-            }
-        }, ButtonServerRpc.class);
+        registerRpcImplementation(rpc, ButtonServerRpc.class);
     }
 
     /**