[spotbugs] FileReftableDatabase: extract lock to local variable

This fixes UL_UNRELEASED_LOCK_EXCEPTION_PATH raised by spotbugs in
#compactFully.

Change-Id: I370578ad9a027c5c9709d60a1dfafdac0cfca908
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java
index e613a58062c3c1c3cdbf52a65ef420f11ac73a67..ad1e753128808fdc1d4f13d8bbc08ad6eb133751 100644 (file)
--- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java
@@ -22,6 +22,7 @@ import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.TreeSet;
+import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
 import java.util.stream.Collectors;
 
@@ -107,12 +108,13 @@ public class FileReftableDatabase extends RefDatabase {
         * @throws IOException on I/O errors
         */
        public void compactFully() throws IOException {
-               reftableDatabase.getLock().lock();
+               Lock l = reftableDatabase.getLock();
+               l.lock();
                try {
                        reftableStack.compactFully();
                        reftableDatabase.clearCache();
                } finally {
-                       reftableDatabase.getLock().unlock();
+                       l.unlock();
                }
        }