Fixes #8129. Fix cloning multiple selected options in IE8.

diff --git a/src/manipulation.js b/src/manipulation.js
index 1ef19f83b54ee56b2d7a2c2baf141b1e8c7dd0e1..19a6c22ba8d4dd4b7aac8b50da802d897d98473f 100644 (file)
--- a/src/manipulation.js
+++ b/src/manipulation.js
@@ -503,6 +503,8 @@ jQuery.extend({
                        // proprietary methods to clear the events. Thanks to MooTools
                        // guys for this hotness.
 
+                       cloneFixAttributes( elem, clone );
+
                        // Using Sizzle here is crazy slow, so we use getElementsByTagName
                        // instead
                        srcElements = elem.getElementsByTagName("*");
@@ -514,8 +516,6 @@ jQuery.extend({
                        for ( i = 0; srcElements[i]; ++i ) {
                                cloneFixAttributes( srcElements[i], destElements[i] );
                        }
-
-                       cloneFixAttributes( elem, clone );
                }
 
                // Copy the events from the original to the clone

diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
index e07108696aa2aa17f55c133cca44dd2861604928..1313783e0be4e2da4da6c02ab43608cc4944de4f 100644 (file)
--- a/test/unit/manipulation.js
+++ b/test/unit/manipulation.js
@@ -1006,7 +1006,7 @@ test("clone()", function() {
 
 test("clone(form element) (Bug #3879, #6655)", function() {
        expect(6);
-       element = jQuery("<select><option>Foo</option><option selected>Bar</option></select>");
+       var element = jQuery("<select><option>Foo</option><option selected>Bar</option></select>");
 
        equals( element.clone().find("option:selected").val(), element.find("option:selected").val(), "Selected option cloned correctly" );
 
@@ -1026,6 +1026,14 @@ test("clone(form element) (Bug #3879, #6655)", function() {
        equals( clone[0].defaultValue, "foo", "Textarea defaultValue cloned correctly" );
 });
 
+test("clone(multiple selected options) (Bug #8129)", function() {
+       expect(1);
+       var element = jQuery("<select><option>Foo</option><option selected>Bar</option><option selected>Baz</option></select>");
+
+       equals( element.clone().find("option:selected").length, element.find("option:selected").length, "Multiple selected options cloned correctly" );
+
+});
+
 if (!isLocal) {
 test("clone() on XML nodes", function() {
        expect(2);