]> source.dussan.org Git - jquery.git/commitdiff
No global vars allowed. Declare 'body' in support.
authortimmywil <timmywillisn@gmail.com>
Fri, 18 Nov 2011 14:28:54 +0000 (09:28 -0500)
committertimmywil <timmywillisn@gmail.com>
Fri, 18 Nov 2011 14:29:10 +0000 (09:29 -0500)
src/support.js
test/unit/support.js

index 2d9107ac9c14f889d542e1efd21c64b22fd63efb..da5fec8ff2d6b1b61700ead1f93f850c584635df 100644 (file)
@@ -184,28 +184,27 @@ jQuery.support = (function() {
        fragment.removeChild( div );
 
        // Null elements to avoid leaks in IE
-       fragment = select = opt = body = marginDiv = div = input = null;
+       fragment = select = opt = marginDiv = div = input = null;
 
-       // Run fixed position tests at doc ready to avoid a crash
-       // related to the invisible body in IE8
+       // Run tests that need a body at doc ready
        jQuery(function() {
                var container, outer, inner, table, td, offsetSupport,
-                       conMarginTop = 1,
-                       ptlm = "position:absolute;top:0;left:0;width:1px;height:1px;margin:0;",
-                       vb = "visibility:hidden;border:0;",
-                       style = "style='" + ptlm + "border:5px solid #000;padding:0;'",
-                       html = "<div " + style + "><div></div></div>" +
-                               "<table " + style + " cellpadding='0' cellspacing='0'>" +
-                               "<tr><td></td></tr></table>";
-
-               // Reconstruct a container
-               body = document.getElementsByTagName("body")[0];
+                       conMarginTop, ptlm, vb, style, html,
+                       body = document.getElementsByTagName("body")[0];
+
                if ( !body ) {
                        // Return for frameset docs that don't have a body
-                       // These tests cannot be done
                        return;
                }
 
+               conMarginTop = 1;
+               ptlm = "position:absolute;top:0;left:0;width:1px;height:1px;margin:0;";
+               vb = "visibility:hidden;border:0;";
+               style = "style='" + ptlm + "border:5px solid #000;padding:0;'";
+               html = "<div " + style + "><div></div></div>" +
+                       "<table " + style + " cellpadding='0' cellspacing='0'>" +
+                       "<tr><td></td></tr></table>";
+
                container = document.createElement("div");
                container.style.cssText = vb + "width:0;height:0;position:static;top:0;margin-top:" + conMarginTop + "px";
                body.insertBefore( container, body.firstChild );
index 8352ad5e33bde012a90eb1cecae652f411a6143a..b714a1cec83ecdc30748480820643f32aef9c801 100644 (file)
@@ -50,7 +50,7 @@ supportIFrameTest( "body background is not lost if set prior to loading jQuery (
        for ( i in support ) {
                if ( !( i in jQuery.support ) ) {
                        passed = false;
-                       strictEqual( src[ i ], dest[ i ], "Unexpected property: " + i );
+                       strictEqual( jQuery.support[ i ], support[ i ], "Unexpected property: " + i );
                }
        }
        ok( passed, "Same support properties" );